Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1206372 > unrolled thread

Re: [PATCH V8 03/25] perf tools: Add Intel PT instruction decoder

Started byArnaldo Carvalho de Melo <acme@kernel.org>
First post2015-08-12 23:00 +0200
Last post2015-08-13 14:40 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH V8 03/25] perf tools: Add Intel PT instruction decoder Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-12 23:00 +0200
    Re: [PATCH V8 03/25] perf tools: Add Intel PT instruction decoder Adrian Hunter <adrian.hunter@intel.com> - 2015-08-13 09:00 +0200
      Re: [PATCH V9 03/25] perf tools: Add Intel PT instruction decoder Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-13 14:40 +0200

#1206372 — Re: [PATCH V8 03/25] perf tools: Add Intel PT instruction decoder

FromArnaldo Carvalho de Melo <acme@kernel.org>
Date2015-08-12 23:00 +0200
SubjectRe: [PATCH V8 03/25] perf tools: Add Intel PT instruction decoder
Message-ID<pWLhU-7cQ-17@gated-at.bofh.it>
Em Fri, Jul 17, 2015 at 07:33:38PM +0300, Adrian Hunter escreveu:
> Add support for decoding instructions for Intel Processor Trace.  The
> kernel x86 instruction decoder is copied for this.
> 
> This essentially provides intel_pt_get_insn() which takes a binary
> buffer, uses the kernel's x86 instruction decoder to get details of the
> instruction and then categorizes it for consumption by an Intel PT
> decoder.


[acme@felicio linux]$ rm -rf /tmp/build/perf ; mkdir -p /tmp/build/perf ; make -C tools/perf O=/tmp/build/perf install-bin
make: Entering directory `/home/acme/git/linux/tools/perf'
  BUILD:   Doing 'make -j4' parallel build

Auto-detecting system features:
...                         dwarf: [ on  ]
...                         glibc: [ on  ]
...                          gtk2: [ on  ]
...                      libaudit: [ on  ]
...                        libbfd: [ on  ]
...                        libelf: [ on  ]
...                       libnuma: [ on  ]
...                       libperl: [ on  ]
...                     libpython: [ on  ]
...                      libslang: [ on  ]
...                     libunwind: [ on  ]
...            libdw-dwarf-unwind: [ on  ]
...                          zlib: [ on  ]
...                          lzma: [ on  ]

<SNIP>

  CC       /tmp/build/perf/util/thread-stack.o
  MKDIR    /tmp/build/perf/ui/tui/
  CC       /tmp/build/perf/ui/tui/setup.o
  CC       /tmp/build/perf/util/auxtrace.o
  MKDIR    /tmp/build/perf/ui/browsers/
  MKDIR    /tmp/build/perf/util/intel-pt-decoder/
  CC       /tmp/build/perf/ui/browsers/hists.o
  CC       /tmp/build/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.o
  MKDIR    /tmp/build/perf/ui/tui/
  CC       /tmp/build/perf/ui/tui/util.o
  GEN      /tmp/build/perf/util/intel-pt-decoder/inat-tables.c
  MKDIR    /tmp/build/perf/util/scripting-engines/
  CC       /tmp/build/perf/util/scripting-engines/trace-event-perl.o
  CC       /tmp/build/perf/util/intel-pt-decoder/intel-pt-insn-decoder.o
  CC       /tmp/build/perf/ui/tui/helpline.o
  CC       /tmp/build/perf/ui/browsers/map.o
  CC       /tmp/build/perf/ui/browsers/scripts.o
  CC       /tmp/build/perf/ui/tui/progress.o
  MKDIR    /tmp/build/perf/util/scripting-engines/
  CC       /tmp/build/perf/util/scripting-engines/trace-event-python.o
util/intel-pt-decoder/intel-pt-insn-decoder.c:26:18: fatal error: insn.c: No such file or directory
 #include <insn.c>
                  ^
compilation terminated.
<SNIP>
make[4]: *** [/tmp/build/perf/util/intel-pt-decoder/intel-pt-insn-decoder.o] Error 1
make[3]: *** [intel-pt-decoder] Error 2
make[3]: *** Waiting for unfinished jobs....
  MKDIR    /tmp/build/perf/scripts/python/Perf-Trace-Util/
  CC       /tmp/build/perf/scripts/python/Perf-Trace-Util/Context.o
make[2]: *** [util] Error 2
make[2]: *** Waiting for unfinished jobs....
  LD       /tmp/build/perf/scripts/python/Perf-Trace-Util/libperf-in.o
  LD       /tmp/build/perf/scripts/perl/Perf-Trace-Util/libperf-in.o
  LD       /tmp/build/perf/scripts/libperf-in.o
make[1]: *** [/tmp/build/perf/libperf-in.o] Error 2
make: *** [install-bin] Error 2
make: Leaving directory `/home/acme/git/linux/tools/perf'
[acme@felicio linux]$ 
 
It works if I just do:

   cd tools/perf
   make

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1206544

FromAdrian Hunter <adrian.hunter@intel.com>
Date2015-08-13 09:00 +0200
Message-ID<pWUEy-45f-7@gated-at.bofh.it>
In reply to#1206372
On 12/08/15 23:55, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jul 17, 2015 at 07:33:38PM +0300, Adrian Hunter escreveu:
>> Add support for decoding instructions for Intel Processor Trace.  The
>> kernel x86 instruction decoder is copied for this.
>>
>> This essentially provides intel_pt_get_insn() which takes a binary
>> buffer, uses the kernel's x86 instruction decoder to get details of the
>> instruction and then categorizes it for consumption by an Intel PT
>> decoder.
> 
> 
> [acme@felicio linux]$ rm -rf /tmp/build/perf ; mkdir -p /tmp/build/perf ; make -C tools/perf O=/tmp/build/perf install-bin
> make: Entering directory `/home/acme/git/linux/tools/perf'
>   BUILD:   Doing 'make -j4' parallel build
> 
> Auto-detecting system features:
> ...                         dwarf: [ on  ]
> ...                         glibc: [ on  ]
> ...                          gtk2: [ on  ]
> ...                      libaudit: [ on  ]
> ...                        libbfd: [ on  ]
> ...                        libelf: [ on  ]
> ...                       libnuma: [ on  ]
> ...                       libperl: [ on  ]
> ...                     libpython: [ on  ]
> ...                      libslang: [ on  ]
> ...                     libunwind: [ on  ]
> ...            libdw-dwarf-unwind: [ on  ]
> ...                          zlib: [ on  ]
> ...                          lzma: [ on  ]
> 
> <SNIP>
> 
>   CC       /tmp/build/perf/util/thread-stack.o
>   MKDIR    /tmp/build/perf/ui/tui/
>   CC       /tmp/build/perf/ui/tui/setup.o
>   CC       /tmp/build/perf/util/auxtrace.o
>   MKDIR    /tmp/build/perf/ui/browsers/
>   MKDIR    /tmp/build/perf/util/intel-pt-decoder/
>   CC       /tmp/build/perf/ui/browsers/hists.o
>   CC       /tmp/build/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.o
>   MKDIR    /tmp/build/perf/ui/tui/
>   CC       /tmp/build/perf/ui/tui/util.o
>   GEN      /tmp/build/perf/util/intel-pt-decoder/inat-tables.c
>   MKDIR    /tmp/build/perf/util/scripting-engines/
>   CC       /tmp/build/perf/util/scripting-engines/trace-event-perl.o
>   CC       /tmp/build/perf/util/intel-pt-decoder/intel-pt-insn-decoder.o
>   CC       /tmp/build/perf/ui/tui/helpline.o
>   CC       /tmp/build/perf/ui/browsers/map.o
>   CC       /tmp/build/perf/ui/browsers/scripts.o
>   CC       /tmp/build/perf/ui/tui/progress.o
>   MKDIR    /tmp/build/perf/util/scripting-engines/
>   CC       /tmp/build/perf/util/scripting-engines/trace-event-python.o
> util/intel-pt-decoder/intel-pt-insn-decoder.c:26:18: fatal error: insn.c: No such file or directory
>  #include <insn.c>
>                   ^
> compilation terminated.

I had a fix for this already but for some reason it fell in with the "for
later" patches.

I will roll the fix in and send V9 of this patch.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1206782 — Re: [PATCH V9 03/25] perf tools: Add Intel PT instruction decoder

FromArnaldo Carvalho de Melo <acme@kernel.org>
Date2015-08-13 14:40 +0200
SubjectRe: [PATCH V9 03/25] perf tools: Add Intel PT instruction decoder
Message-ID<pWZXB-3o7-15@gated-at.bofh.it>
In reply to#1206544
Em Thu, Aug 13, 2015 at 10:14:55AM +0300, Adrian Hunter escreveu:
> Add support for decoding instructions for Intel Processor Trace.  The
> kernel x86 instruction decoder is copied for this.
> 
> This essentially provides intel_pt_get_insn() which takes a binary
> buffer, uses the kernel's x86 instruction decoder to get details of the
> instruction and then categorizes it for consumption by an Intel PT
> decoder.
> 
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> 
> 
> Changes in V9:
> 
> 	insn.c is in the tools/perf sources and so should
> 	be included as "insn.c" not <insn.c>.
> 
> 	inat_types.h is in the kernel headers so is not needed
> 	in the tools/perf sources.

Thanks, now it builds with O=

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web