Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1206541 > unrolled thread

RE: [PATCH 1/2] KVM: x86: set TMR when the interrupt is accepted

Started by"Zhang, Yang Z" <yang.z.zhang@intel.com>
First post2015-08-13 08:40 +0200
Last post2015-08-13 09:40 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  RE: [PATCH 1/2] KVM: x86: set TMR when the interrupt is accepted "Zhang, Yang Z" <yang.z.zhang@intel.com> - 2015-08-13 08:40 +0200
    Re: [PATCH 1/2] KVM: x86: set TMR when the interrupt is accepted Paolo Bonzini <pbonzini@redhat.com> - 2015-08-13 09:40 +0200

#1206541 — RE: [PATCH 1/2] KVM: x86: set TMR when the interrupt is accepted

From"Zhang, Yang Z" <yang.z.zhang@intel.com>
Date2015-08-13 08:40 +0200
SubjectRE: [PATCH 1/2] KVM: x86: set TMR when the interrupt is accepted
Message-ID<pWUlc-3IA-29@gated-at.bofh.it>
Zhang, Yang Z wrote on 2015-08-04:
> Paolo Bonzini wrote on 2015-08-04:
>> 
>> 
>> On 04/08/2015 02:46, Zhang, Yang Z wrote:
>>>> It is a problem for split irqchip, where the EOI exit bitmap can
>>>> be inferred from the IOAPIC routes but the TMR cannot.  The
>>>> hardware behavior on the other hand can be implemented purely within the LAPIC.
>>> 
>>> So updating the TMR within LAPIC is the only solution to handle it?
>> 
>> It's the simplest and the one that makes most sense.  Considering
>> that TMR is a pretty obscure feature, it's unlikely that it will be
>> accelerated in the future.
> 
> You may be right. It is safe if no future hardware plans to use it.
> Let me check with our hardware team to see whether it will be used or not in future.

After checking with Jun, there is no guarantee that the guest running on another CPU will operate properly if hypervisor modify the vTMR from another CPU. So the hypervisor should not to do it.

> 
>> 
>> Paolo
> 
> 
> Best regards,
> Yang
>


Best regards,
Yang


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1206568

FromPaolo Bonzini <pbonzini@redhat.com>
Date2015-08-13 09:40 +0200
Message-ID<pWVhg-53B-29@gated-at.bofh.it>
In reply to#1206541

On 13/08/2015 08:35, Zhang, Yang Z wrote:
>> You may be right. It is safe if no future hardware plans to use
>> it. Let me check with our hardware team to see whether it will be
>> used or not in future.
> 
> After checking with Jun, there is no guarantee that the guest running
> on another CPU will operate properly if hypervisor modify the vTMR
> from another CPU. So the hypervisor should not to do it.

I guess I can cause a vmexit on level-triggered interrupts, it's not a
big deal, but no weasel words, please.

What's going to break, and where is it documented?

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web