Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1206106 > unrolled thread

Re: [tip:perf/core] perf: Fix PERF_EVENT_IOC_PERIOD migration race

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [tip:perf/core] perf: Fix PERF_EVENT_IOC_PERIOD migration race Vince Weaver <vincent.weaver@maine.edu> - 2015-08-12 15:50 +0200
    Re: [tip:perf/core] perf: Fix PERF_EVENT_IOC_PERIOD migration race Peter Zijlstra <peterz@infradead.org> - 2015-08-12 19:10 +0200

#1206106 — Re: [tip:perf/core] perf: Fix PERF_EVENT_IOC_PERIOD migration race

On Wed, 12 Aug 2015, tip-bot for Peter Zijlstra wrote:

> Commit-ID:  c7999c6f3fed9e383d3131474588f282ae6d56b9
> Gitweb:     http://git.kernel.org/tip/c7999c6f3fed9e383d3131474588f282ae6d56b9
> Author:     Peter Zijlstra <peterz@infradead.org>
> AuthorDate: Tue, 4 Aug 2015 19:22:49 +0200
> Committer:  Ingo Molnar <mingo@kernel.org>
> CommitDate: Wed, 12 Aug 2015 11:37:22 +0200
> 
> perf: Fix PERF_EVENT_IOC_PERIOD migration race
> 
> I ran the perf fuzzer, which triggered some WARN()s which are due to
> trying to stop/restart an event on the wrong CPU.

Do you have a list of which WARNs this should fix?  Just so I can 
update my bug tracker.

Thanks,

Vince
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1206279

On Wed, Aug 12, 2015 at 09:49:40AM -0400, Vince Weaver wrote:
> On Wed, 12 Aug 2015, tip-bot for Peter Zijlstra wrote:
> 
> > Commit-ID:  c7999c6f3fed9e383d3131474588f282ae6d56b9
> > Gitweb:     http://git.kernel.org/tip/c7999c6f3fed9e383d3131474588f282ae6d56b9
> > Author:     Peter Zijlstra <peterz@infradead.org>
> > AuthorDate: Tue, 4 Aug 2015 19:22:49 +0200
> > Committer:  Ingo Molnar <mingo@kernel.org>
> > CommitDate: Wed, 12 Aug 2015 11:37:22 +0200
> > 
> > perf: Fix PERF_EVENT_IOC_PERIOD migration race
> > 
> > I ran the perf fuzzer, which triggered some WARN()s which are due to
> > trying to stop/restart an event on the wrong CPU.
> 
> Do you have a list of which WARNs this should fix?  Just so I can 
> update my bug tracker.

I think this triggered:

arch/x86/kernel/cpu/perf_event.c:x86_pmu_del()

	if (WARN_ON_ONCE(i == cpuc->n_events)) /* called ->del() without ->add() ? */


Through perf_ioctl()->perf_event_period().

I didn't safe a copy of the exact backtrace.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web