Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1206070 > unrolled thread

Re: [PATCH] HID: hid-input: fix double-free in cleanup_battery

Started byJiri Kosina <jikos@kernel.org>
First post2015-08-12 15:20 +0200
Last post2015-08-12 15:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] HID: hid-input: fix double-free in cleanup_battery Jiri Kosina <jikos@kernel.org> - 2015-08-12 15:20 +0200
    Re: [PATCH] HID: hid-input: fix double-free in cleanup_battery Matthew Leach <matthew@mattleach.net> - 2015-08-12 15:20 +0200

#1206070 — Re: [PATCH] HID: hid-input: fix double-free in cleanup_battery

FromJiri Kosina <jikos@kernel.org>
Date2015-08-12 15:20 +0200
SubjectRe: [PATCH] HID: hid-input: fix double-free in cleanup_battery
Message-ID<pWE6J-5sr-9@gated-at.bofh.it>
On Wed, 12 Aug 2015, Matthew Leach wrote:

> The power supply layer has taken control of the power supply objects
> from the drivers to core, see [1].  As such, calling
> power_supply_unregister is enough to free the power_supply device.
> 
> Remove the extra kfree's as the power_supply core will handle freeing
> the power_supply object for us.

Please see commit 0621809e37 ("HID: hid-input: Fix accessing freed memory 
during device disconnect") in Linus' tree.

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1206073

FromMatthew Leach <matthew@mattleach.net>
Date2015-08-12 15:20 +0200
Message-ID<pWE6J-5sr-13@gated-at.bofh.it>
In reply to#1206070
On Wed, 2015-08-12 at 15:16 +0200, Jiri Kosina wrote:
> On Wed, 12 Aug 2015, Matthew Leach wrote:
> 
> > The power supply layer has taken control of the power supply 
> objects
> > from the drivers to core, see [1].  As such, calling
> > power_supply_unregister is enough to free the power_supply device.
> > 
> > Remove the extra kfree's as the power_supply core will handle 
> freeing
> > the power_supply object for us.
> 
> Please see commit 0621809e37 ("HID: hid-input: Fix accessing freed 
> memory 
> during device disconnect") in Linus' tree.

Ah.  I missed that.  Sorry for the noise.
-- 
Matt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web