Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1200797 > unrolled thread

[PATCH 1/2] sched/deadline: fix comment in push_dl_tasks

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/2] sched/deadline: fix comment in push_dl_tasks Andrea Parri <parri.andrea@gmail.com> - 2015-08-05 16:00 +0200
    Re: [PATCH 1/2] sched/deadline: fix comment in push_dl_tasks Juri Lelli <juri.lelli@arm.com> - 2015-08-11 12:00 +0200
    [tip:sched/core] sched/deadline: Fix comment in push_dl_tasks() tip-bot for Andrea Parri <tipbot@zytor.com> - 2015-08-12 14:40 +0200

#1200797 — [PATCH 1/2] sched/deadline: fix comment in push_dl_tasks

The comment is "misleading"; fix it by adapting a comment from
push_rt_tasks.

Signed-off-by: Andrea Parri <parri.andrea@gmail.com>
---
 kernel/sched/deadline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 0a17af35..7c17001 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -1563,7 +1563,7 @@ out:
 
 static void push_dl_tasks(struct rq *rq)
 {
-	/* Terminates as it moves a -deadline task */
+	/* push_dl_task will return true if it moved a -deadline task */
 	while (push_dl_task(rq))
 		;
 }
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1204981

Hi Andrea,

On 05/08/15 14:56, Andrea Parri wrote:
> The comment is "misleading"; fix it by adapting a comment from
> push_rt_tasks.
> 
> Signed-off-by: Andrea Parri <parri.andrea@gmail.com>
> ---
>  kernel/sched/deadline.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 0a17af35..7c17001 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -1563,7 +1563,7 @@ out:
>  
>  static void push_dl_tasks(struct rq *rq)
>  {
> -	/* Terminates as it moves a -deadline task */
> +	/* push_dl_task will return true if it moved a -deadline task */
>  	while (push_dl_task(rq))
>  		;
>  }
> 

Looks good, thanks!

Best,

- Juri

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1206045 — [tip:sched/core] sched/deadline: Fix comment in push_dl_tasks()

Commit-ID:  4ffa08ed4cc4c5d47d197d749aae6f79af91eb73
Gitweb:     http://git.kernel.org/tip/4ffa08ed4cc4c5d47d197d749aae6f79af91eb73
Author:     Andrea Parri <parri.andrea@gmail.com>
AuthorDate: Wed, 5 Aug 2015 15:56:18 +0200
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 12 Aug 2015 12:06:10 +0200

sched/deadline: Fix comment in push_dl_tasks()

The comment is "misleading"; fix it by adapting a comment from
push_rt_tasks().

Signed-off-by: Andrea Parri <parri.andrea@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1438782979-9057-1-git-send-email-parri.andrea@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/deadline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index b473056..82c0dd0 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -1563,7 +1563,7 @@ out:
 
 static void push_dl_tasks(struct rq *rq)
 {
-	/* Terminates as it moves a -deadline task */
+	/* push_dl_task() will return true if it moved a -deadline task */
 	while (push_dl_task(rq))
 		;
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web