Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1206056 > unrolled thread

Re: [PATCH] kvm:x86:Fix error handling in the function ioapic_write_indirect

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] kvm:x86:Fix error handling in the function  ioapic_write_indirect Paolo Bonzini <pbonzini@redhat.com> - 2015-08-12 14:50 +0200

#1206056 — Re: [PATCH] kvm:x86:Fix error handling in the function ioapic_write_indirect

On 11/08/2015 19:39, Nicholas Krause wrote:
> This fixes error handling in the function ioapic_write_indirect to
> properly check if the call to the function ioapoc_service service
> has failed by not returning the value zero to indicate success to
> check if this occurs when calling this particular function and if
> so return immediately to the caller of ioapic_write_indirect due
> to us no longer being able to continue the function
> ioapic_write_indirect after this call fails.

This is not true.

You are back to the older problem that you are not trying to understand
the functions you are modifying.


Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web