Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1204454 > unrolled thread

Re: [PATCH v2] openvswitch: Fix L4 checksum handling when dealing with IP fragments

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2] openvswitch: Fix L4 checksum handling when dealing  with IP fragments Glenn Griffin <ggriffin.kernel@gmail.com> - 2015-08-10 19:50 +0200
    Re: [PATCH v2] openvswitch: Fix L4 checksum handling when dealing  with IP fragments David Miller <davem@davemloft.net> - 2015-08-10 20:30 +0200

#1204454 — Re: [PATCH v2] openvswitch: Fix L4 checksum handling when dealing with IP fragments

On Mon, Aug 03, 2015 at 02:03:28PM -0700, David Miller wrote:
> From: Glenn Griffin <ggriffin.kernel@gmail.com>
> Date: Mon, 3 Aug 2015 09:56:54 -0700
> 
> > openvswitch modifies the L4 checksum of a packet when modifying
> > the ip address. When an IP packet is fragmented only the first
> > fragment contains an L4 header and checksum. Prior to this change
> > openvswitch would modify all fragments, modifying application data
> > in non-first fragments, causing checksum failures in the
> > reassembled packet.
> > 
> > Signed-off-by: Glenn Griffin <ggriffin.kernel@gmail.com>
> > ---
> > Changes in v2:
> >   - Compare frag_off in network byte order rather than host byte order
> 
> Applied and queued up for -stable.

I noticed this change didn't seem to make it into 4.2-rc6. I'm not too
familiar with the release schedule so wasn't sure if that was expected
or an oversight. Will this remain queued up until the 4.3 merge window
opens?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1204468

From: Glenn Griffin <ggriffin.kernel@gmail.com>
Date: Mon, 10 Aug 2015 10:43:16 -0700

> On Mon, Aug 03, 2015 at 02:03:28PM -0700, David Miller wrote:
>> From: Glenn Griffin <ggriffin.kernel@gmail.com>
>> Date: Mon, 3 Aug 2015 09:56:54 -0700
>> 
>> > openvswitch modifies the L4 checksum of a packet when modifying
>> > the ip address. When an IP packet is fragmented only the first
>> > fragment contains an L4 header and checksum. Prior to this change
>> > openvswitch would modify all fragments, modifying application data
>> > in non-first fragments, causing checksum failures in the
>> > reassembled packet.
>> > 
>> > Signed-off-by: Glenn Griffin <ggriffin.kernel@gmail.com>
>> > ---
>> > Changes in v2:
>> >   - Compare frag_off in network byte order rather than host byte order
>> 
>> Applied and queued up for -stable.
> 
> I noticed this change didn't seem to make it into 4.2-rc6. I'm not too
> familiar with the release schedule so wasn't sure if that was expected
> or an oversight. Will this remain queued up until the 4.3 merge window
> opens?

It's in my 'net' tree and will be pushed to Linus's tree at a time that I
deem appropriate.  Usually I try to push to Linus one every week or so,
in order for changes to soak and get tested in my tree before they get
pushed to his.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web