Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1204273 > unrolled thread

Ozwpan Driver: Removal Recommended

Started by"Jason A. Donenfeld" <Jason@zx2c4.com>
First post2015-08-10 15:40 +0200
Last post2015-08-10 17:50 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel


Contents

  Ozwpan Driver: Removal Recommended "Jason A. Donenfeld" <Jason@zx2c4.com> - 2015-08-10 15:40 +0200
    Re: Ozwpan Driver: Removal Recommended "Jason A. Donenfeld" <Jason@zx2c4.com> - 2015-08-10 15:40 +0200
    [PATCH 1/2] ozwpan: The maintainers are MIA, so orphan "Jason A. Donenfeld" <Jason@zx2c4.com> - 2015-08-10 15:50 +0200
      Re: [PATCH 1/2] ozwpan: The maintainers are MIA, so orphan Greg KH <gregkh@linuxfoundation.org> - 2015-08-10 17:50 +0200

#1204273 — Ozwpan Driver: Removal Recommended

From"Jason A. Donenfeld" <Jason@zx2c4.com>
Date2015-08-10 15:40 +0200
SubjectOzwpan Driver: Removal Recommended
Message-ID<pVVt0-7LE-13@gated-at.bofh.it>
Hi Greg,

We spoke about this several months ago. Since then, there has been no
life from any of the maintainers or anybody at Atmel. Meanwhile Dan
Carpenter has posted a patch for a security vulnerability in ozwpan
that hasn't been reviewed or merged. There is nobody willing to
maintain it. And nobody who has relevant hardware has even said
"hello". All of my connections to ozwpan have yielded zero success in
trying to find a maintainer or anybody with even remote expertise.
Clearly this is dead in the water.

I would thus recommend you remove this buggy, insecure, and
unmaintained driver from the tree. It simply didn't pass the "staging
test".

Regards,
Jason

On Tue, Jun 2, 2015 at 1:35 PM, Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> On Tue, Jun 2, 2015 at 3:35 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
>> I don't know, but I'm a bit loath to delete the driver from the tree as
>> then people will just continue to use the version with all of the bugs.
>
> Yea, I understand that. Though, I'm pretty sure that most users of
> ozwpan use old forks tied to old kernels, and do not use upstream
> anyway.
>
>> If Atmel doesn't want to maintain the code anymore, do you want to do
>> it?  You can always send patches for this issue, as you seem to have the
>> hardware and can do testing, which I can't.
>
> Thank you for the offer, and I would actually love to maintain a part
> of the kernel. But I am likely the wrong man for ozwpan (inspite of
> the Internet's claims of my wizardry [1]). The debugging I've done
> thus far is on a readily available consumer embedded device, which I
> was required to root and unsandbox and partake in other "security dark
> magic" in order to get a decent debugging interface. My rig is rather
> brittle and is likely to fall to pieces like aging solder at any
> moment. I'd recommend this be maintained by someone with proper test
> hardware and a suit of unit tests. This means: Atmel, or one of the
> many clients to whom Atmel has sold high volumes of ozwpan chips. I'll
> reach out where I can to see if I can find someone in a good position
> to maintain it.
>
> [1] https://twitter.com/drgfragkos/status/598776229282578432
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1204282

From"Jason A. Donenfeld" <Jason@zx2c4.com>
Date2015-08-10 15:40 +0200
Message-ID<pVVt1-7LE-35@gated-at.bofh.it>
In reply to#1204273
On Mon, Aug 10, 2015 at 3:31 PM, Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> Meanwhile Dan
> Carpenter has posted a patch for a security vulnerability in ozwpan
> that hasn't been reviewed or merged.

Sorry, I see that you did in fact pick up this patch, so I retract
that statement.

Nonetheless, the remainder of the points in that email remain
relevant. The maintainers are nowhere to be found. And it doesn't seem
like anybody cares about it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1204291 — [PATCH 1/2] ozwpan: The maintainers are MIA, so orphan

From"Jason A. Donenfeld" <Jason@zx2c4.com>
Date2015-08-10 15:50 +0200
Subject[PATCH 1/2] ozwpan: The maintainers are MIA, so orphan
Message-ID<pVVCG-7X5-21@gated-at.bofh.it>
In reply to#1204273
Ozwpan is completely unmaintained and potentially a security problem. As
this is a staging driver, it should be removed, since it has been
abandoned. Marking it as orphaned is the first step here.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 2d3d55c..0e14772 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9717,7 +9717,7 @@ F:	drivers/staging/olpc_dcon/
 
 STAGING - OZMO DEVICES USB OVER WIFI DRIVER
 M:	Shigekatsu Tateno <shigekatsu.tateno@atmel.com>
-S:	Maintained
+S:	Orphan
 F:	drivers/staging/ozwpan/
 
 STAGING - PARALLEL LCD/KEYPAD PANEL DRIVER
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1204386 — Re: [PATCH 1/2] ozwpan: The maintainers are MIA, so orphan

FromGreg KH <gregkh@linuxfoundation.org>
Date2015-08-10 17:50 +0200
SubjectRe: [PATCH 1/2] ozwpan: The maintainers are MIA, so orphan
Message-ID<pVXuO-2cJ-25@gated-at.bofh.it>
In reply to#1204291
On Mon, Aug 10, 2015 at 03:47:19PM +0200, Jason A. Donenfeld wrote:
> Ozwpan is completely unmaintained and potentially a security problem. As
> this is a staging driver, it should be removed, since it has been
> abandoned. Marking it as orphaned is the first step here.
> 
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---
>  MAINTAINERS | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2d3d55c..0e14772 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -9717,7 +9717,7 @@ F:	drivers/staging/olpc_dcon/
>  
>  STAGING - OZMO DEVICES USB OVER WIFI DRIVER
>  M:	Shigekatsu Tateno <shigekatsu.tateno@atmel.com>
> -S:	Maintained
> +S:	Orphan
>  F:	drivers/staging/ozwpan/

As you are deleting the whole driver, this whole entry should be
removed as well, marking it "Orphan" doesn't mean anything after your
second patch.

Just do it all in one patch, that makes more sense.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web