Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1204042 > unrolled thread
| Started by | Ben Hutchings <ben@decadent.org.uk> |
|---|---|
| First post | 2015-08-10 12:20 +0200 |
| Last post | 2015-08-11 22:20 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 3.2 090/110] NET: AX.25: Stop heartbeat timer on disconnect. Ben Hutchings <ben@decadent.org.uk> - 2015-08-10 12:20 +0200
Re: [PATCH 3.2 090/110] NET: AX.25: Stop heartbeat timer on disconnect. Richard Stearn <richard@rns-stearn.demon.co.uk> - 2015-08-10 14:10 +0200
Re: [PATCH 3.2 090/110] NET: AX.25: Stop heartbeat timer on disconnect. Ben Hutchings <ben@decadent.org.uk> - 2015-08-11 22:20 +0200
| From | Ben Hutchings <ben@decadent.org.uk> |
|---|---|
| Date | 2015-08-10 12:20 +0200 |
| Subject | [PATCH 3.2 090/110] NET: AX.25: Stop heartbeat timer on disconnect. |
| Message-ID | <pVSls-3cZ-45@gated-at.bofh.it> |
3.2.71-rc1 review patch. If anyone has any objections, please let me know.
------------------
From: Richard Stearn <richard@rns-stearn.demon.co.uk>
commit da278622bf04f8ddb14519a2b8214e108ef26101 upstream.
This may result in a kernel panic. The bug has always existed but
somehow we've run out of luck now and it bites.
Signed-off-by: Richard Stearn <richard@rns-stearn.demon.co.uk>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
net/ax25/ax25_subr.c | 1 +
1 file changed, 1 insertion(+)
--- a/net/ax25/ax25_subr.c
+++ b/net/ax25/ax25_subr.c
@@ -265,6 +265,7 @@ void ax25_disconnect(ax25_cb *ax25, int
{
ax25_clear_queues(ax25);
+ ax25_stop_heartbeat(ax25);
ax25_stop_t1timer(ax25);
ax25_stop_t2timer(ax25);
ax25_stop_t3timer(ax25);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Richard Stearn <richard@rns-stearn.demon.co.uk> |
|---|---|
| Date | 2015-08-10 14:10 +0200 |
| Message-ID | <pVU3U-5R8-5@gated-at.bofh.it> |
| In reply to | #1204042 |
Ben Hutchings wrote:
> 3.2.71-rc1 review patch. If anyone has any objections, please let me know.
>
> ------------------
>
> From: Richard Stearn <richard@rns-stearn.demon.co.uk>
>
> commit da278622bf04f8ddb14519a2b8214e108ef26101 upstream.
>
> This may result in a kernel panic. The bug has always existed but
> somehow we've run out of luck now and it bites.
>
> Signed-off-by: Richard Stearn <richard@rns-stearn.demon.co.uk>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> net/ax25/ax25_subr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/net/ax25/ax25_subr.c
> +++ b/net/ax25/ax25_subr.c
> @@ -265,6 +265,7 @@ void ax25_disconnect(ax25_cb *ax25, int
> {
> ax25_clear_queues(ax25);
>
> + ax25_stop_heartbeat(ax25);
> ax25_stop_t1timer(ax25);
> ax25_stop_t2timer(ax25);
> ax25_stop_t3timer(ax25);
This patch should _not_ be applied.
Breaks other parts of the driver.
Investigations on-going.
--
Regards
Richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Ben Hutchings <ben@decadent.org.uk> |
|---|---|
| Date | 2015-08-11 22:20 +0200 |
| Subject | Re: [PATCH 3.2 090/110] NET: AX.25: Stop heartbeat timer on disconnect. |
| Message-ID | <pWobF-7lR-13@gated-at.bofh.it> |
| In reply to | #1204202 |
[Multipart message — attachments visible in raw view] — view raw
On Mon, 2015-08-10 at 12:52 +0100, Richard Stearn wrote:
> Ben Hutchings wrote:
> > 3.2.71-rc1 review patch. If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Richard Stearn <richard@rns-stearn.demon.co.uk>
> >
> > commit da278622bf04f8ddb14519a2b8214e108ef26101 upstream.
> >
> > This may result in a kernel panic. The bug has always existed but
> > somehow we've run out of luck now and it bites.
> >
> > Signed-off-by: Richard Stearn <richard@rns-stearn.demon.co.uk>
> > Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
> > Signed-off-by: David S. Miller <davem@davemloft.net>
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > ---
> > net/ax25/ax25_subr.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > --- a/net/ax25/ax25_subr.c
> > +++ b/net/ax25/ax25_subr.c
> > @@ -265,6 +265,7 @@ void ax25_disconnect(ax25_cb *ax25, int
> > {
> > > > > > ax25_clear_queues(ax25);
> >
> > +> > > > ax25_stop_heartbeat(ax25);
> > > > > > ax25_stop_t1timer(ax25);
> > > > > > ax25_stop_t2timer(ax25);
> > > > > > ax25_stop_t3timer(ax25);
>
> This patch should _not_ be applied.
> Breaks other parts of the driver.
> Investigations on-going.
OK, I'll drop it for now.
Ben.
--
Ben Hutchings
Theory and practice are closer in theory than in practice.
- John Levine, moderator of comp.compilers
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web