Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1203636 > unrolled thread
| Started by | Bhaktipriya Shridhar <bhaktipriya96@gmail.com> |
|---|---|
| First post | 2015-08-09 14:50 +0200 |
| Last post | 2015-08-10 11:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] Staging: dgnc: Fixed line over 80 characters in dgnc_mgmt.c Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2015-08-09 14:50 +0200
Re: [PATCH] Staging: dgnc: Fixed line over 80 characters in dgnc_mgmt.c Dan Carpenter <dan.carpenter@oracle.com> - 2015-08-10 11:50 +0200
| From | Bhaktipriya Shridhar <bhaktipriya96@gmail.com> |
|---|---|
| Date | 2015-08-09 14:50 +0200 |
| Subject | [PATCH] Staging: dgnc: Fixed line over 80 characters in dgnc_mgmt.c |
| Message-ID | <pVyd3-6lz-1@gated-at.bofh.it> |
Fixed coding style issue "warning line over 80 characters" detected by checkpatch.pl in dgnc_mgmt.c --- drivers/staging/dgnc/dgnc_mgmt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dgnc_mgmt.c index b13318a..e8fd3da 100644 --- a/drivers/staging/dgnc/dgnc_mgmt.c +++ b/drivers/staging/dgnc/dgnc_mgmt.c @@ -148,7 +148,8 @@ long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg) di.info_bdstate = dgnc_Board[brd]->dpastatus; di.info_ioport = 0; di.info_physaddr = (ulong) dgnc_Board[brd]->membase; - di.info_physsize = (ulong) dgnc_Board[brd]->membase - dgnc_Board[brd]->membase_end; + di.info_physsize = (ulong) dgnc_Board[brd]->membase - + dgnc_Board[brd]->membase_end; if (dgnc_Board[brd]->state != BOARD_FAILED) di.info_nports = dgnc_Board[brd]->nasync; else -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2015-08-10 11:50 +0200 |
| Subject | Re: [PATCH] Staging: dgnc: Fixed line over 80 characters in dgnc_mgmt.c |
| Message-ID | <pVRSr-2iN-27@gated-at.bofh.it> |
| In reply to | #1203636 |
On Sun, Aug 09, 2015 at 06:15:36PM +0530, Bhaktipriya Shridhar wrote: > Fixed coding style issue "warning line over 80 characters" > detected by checkpatch.pl in dgnc_mgmt.c No signed off by. > --- > drivers/staging/dgnc/dgnc_mgmt.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dgnc_mgmt.c > index b13318a..e8fd3da 100644 > --- a/drivers/staging/dgnc/dgnc_mgmt.c > +++ b/drivers/staging/dgnc/dgnc_mgmt.c > @@ -148,7 +148,8 @@ long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg) > di.info_bdstate = dgnc_Board[brd]->dpastatus; > di.info_ioport = 0; > di.info_physaddr = (ulong) dgnc_Board[brd]->membase; > - di.info_physsize = (ulong) dgnc_Board[brd]->membase - dgnc_Board[brd]->membase_end; > + di.info_physsize = (ulong) dgnc_Board[brd]->membase - > + dgnc_Board[brd]->membase_end; Better to align it like: di.info_physsize = (ulong)dgnc_Board[brd]->membase - dgnc_Board[brd]->membase_end; But even better would be to rename brd to brd_idx and introduce a new "struct dgnc_board *brd" variable and set: brd = dgnc_Board[brd_idx]; Then replace ever reference to "dgnc_Board[brd]" with just "brd". regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web