Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1201505 > unrolled thread

[PATCH 2/2] tty: serial: men_z135_uart.c: Don't initialize port->lock

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 2/2] tty: serial: men_z135_uart.c: Don't initialize port->lock Johannes Thumshirn <jthumshirn@suse.de> - 2015-08-06 09:20 +0200
    Re: [PATCH 2/2] tty: serial: men_z135_uart.c: Don't initialize port->lock Peter Hurley <peter@hurleysoftware.com> - 2015-08-06 13:40 +0200

#1201505 — [PATCH 2/2] tty: serial: men_z135_uart.c: Don't initialize port->lock

port->lock get's initialized in uart_add_one_port(), no need to do it
in men_z135_probe().

Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Peter Hurley <peter@hurleysoftware.com>
---
 drivers/tty/serial/men_z135_uart.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/tty/serial/men_z135_uart.c b/drivers/tty/serial/men_z135_uart.c
index 5a41b8fb..b90e7b3 100644
--- a/drivers/tty/serial/men_z135_uart.c
+++ b/drivers/tty/serial/men_z135_uart.c
@@ -839,7 +839,6 @@ static int men_z135_probe(struct mcb_device *mdev,
 	uart->port.membase = NULL;
 	uart->mdev = mdev;
 
-	spin_lock_init(&uart->port.lock);
 	spin_lock_init(&uart->lock);
 
 	err = uart_add_one_port(&men_z135_driver, &uart->port);
-- 
2.4.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1201667

On 08/06/2015 03:16 AM, Johannes Thumshirn wrote:
> port->lock get's initialized in uart_add_one_port(), no need to do it
> in men_z135_probe().

Reviewed-by: Peter Hurley <peter@hurleysoftware.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web