Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1201366 > unrolled thread

[PATCH v4 REPOST 0/8] clean up wlan_bssdef.h

Back to article view | Back to linux.kernel

Contents

  [PATCH v4 REPOST 0/8] clean up wlan_bssdef.h Joshua Clayton <stillcompiling@gmail.com> - 2015-08-06 02:20 +0200
    Re: [PATCH v4 REPOST 0/8] clean up wlan_bssdef.h Dan Carpenter <dan.carpenter@oracle.com> - 2015-08-06 10:10 +0200

#1201366 — [PATCH v4 REPOST 0/8] clean up wlan_bssdef.h

I posted v4 of this patch set a week ago and there have been no 
comments. I hope this is a good sign that the patches are good.
However, I have noticed that I managed to use the same message id
for the coverletter of v4 as for v3, which might have caused people 
to hold off reviewing, perhaps thinking that earlier comments
had not been addressed.

Better safe than sorry, so I am reposting v4
My apologies for the noise on the mailing list.

The main goal of this series is to get rid of a needless typedef
in the rtl8712 wlan driver.

In the course of fixing that, I found a bug that can (at least in theory)
lead to a overrun during a memcpy, as well as an identical struct with
a different name, which use the typedef.
Finally after cleaning up the typedef, change the name of the primary
variable that used the typedef from "SupportedRates" to "rates", to
conform to kernel coding style.

Changes since V1:
Do not make other logic changes while Changing the name of SupportedRates
New patch 3/6 fixes a buggy comment that referred to the typedef

Changes since V2:
broke former patch 4 into 3 parts, as it was too big for git-send-email

Changes since V3:
In patch 8/8 Change the line wrapping of lines that fit within 80
characters, removing superfluous "== true" expressions that would 
otherwise keep the lines overlong.


Joshua Clayton (8):
  staging: rtl8712: fix buggy size calculation
  staging: rtl8712: simplify size calculation
  staging: rtl8712: fix comment
  staging: rtl8712: removed unused wrapper structs
  staging: rtl8712: remove duplicate struct
  staging: rtl8712: rename function
  staging: rtl8712: remove typedefs
  staging: rtl8712: change SupportedRates to rates

 drivers/staging/rtl8712/ieee80211.c           | 25 +++++++-------
 drivers/staging/rtl8712/rtl871x_cmd.c         | 28 +++++-----------
 drivers/staging/rtl8712/rtl871x_cmd.h         | 18 ----------
 drivers/staging/rtl8712/rtl871x_event.h       |  2 +-
 drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 34 +++++++++----------
 drivers/staging/rtl8712/rtl871x_mlme.c        | 47 ++++++++++-----------------
 drivers/staging/rtl8712/rtl871x_mlme.h        |  2 +-
 drivers/staging/rtl8712/rtl871x_mp_ioctl.c    |  6 ++--
 drivers/staging/rtl8712/wlan_bssdef.h         | 42 +++---------------------
 9 files changed, 62 insertions(+), 142 deletions(-)

-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1201541

On Wed, Aug 05, 2015 at 05:17:13PM -0700, Joshua Clayton wrote:
> I posted v4 of this patch set a week ago and there have been no 
> comments. I hope this is a good sign that the patches are good.
> However, I have noticed that I managed to use the same message id
> for the coverletter of v4 as for v3, which might have caused people 
> to hold off reviewing, perhaps thinking that earlier comments
> had not been addressed.
> 

No.  No one reads cover letters.  If there are no comments it means the
peanut gallery is fine with it, and Greg hasn't gotten around to it yet.

Please don't repost patches unless asked.

You would think we would scramble around like panicked rabbits to fix
the potential buffer overrun but actually we just treat it like a normal
patch so it will take a bit to get merged.

Greg will email you when he gets to the patches, if they are merged or
if there is a problem.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web