Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1201042 > unrolled thread
| Started by | Allen Hubbe <Allen.Hubbe@emc.com> |
|---|---|
| First post | 2015-08-05 20:30 +0200 |
| Last post | 2015-08-05 20:30 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
[PATCH] ioatdma: fix overflow of u16 in ring_reshape Allen Hubbe <Allen.Hubbe@emc.com> - 2015-08-05 20:30 +0200
| From | Allen Hubbe <Allen.Hubbe@emc.com> |
|---|---|
| Date | 2015-08-05 20:30 +0200 |
| Subject | [PATCH] ioatdma: fix overflow of u16 in ring_reshape |
| Message-ID | <pUbBU-Uj-9@gated-at.bofh.it> |
If the allocation order is 16, then the u16 index will overflow and wrap to zero instead of being equal or greater than 1 << 16. The loop condition will always be true, and the loop will run until all the memory resources are depleted. Change the type of index 'i' to u32, so that it is large enough to store a value equal or greater than 1 << 16. Signed-off-by: Allen Hubbe <Allen.Hubbe@emc.com> --- drivers/dma/ioat/dma_v2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/ioat/dma_v2.c b/drivers/dma/ioat/dma_v2.c index 69c7dfcad023..13fbd9d5b5b9 100644 --- a/drivers/dma/ioat/dma_v2.c +++ b/drivers/dma/ioat/dma_v2.c @@ -588,7 +588,7 @@ bool reshape_ring(struct ioat2_dma_chan *ioat, int order) const u16 active = ioat2_ring_active(ioat); const u32 new_size = 1 << order; struct ioat_ring_ent **ring; - u16 i; + u32 i; if (order > ioat_get_max_alloc_order()) return false; -- 2.5.0.rc1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to top | Article view | linux.kernel
csiph-web