Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1202952 > unrolled thread

[PATCH] regmap: Remove useless check

Back to article view | Back to linux.kernel

Contents

  [PATCH] regmap: Remove useless check Salah Triki <salah.triki@acm.org> - 2015-08-07 19:40 +0200
    Re: [PATCH] regmap: Remove useless check Mark Brown <broonie@kernel.org> - 2015-08-07 20:30 +0200

#1202952 — [PATCH] regmap: Remove useless check

lzo1x_1_do_compress always returns LZO_E_OK. Thus, the check of the
return value is useless.

Signed-off-by: Salah Triki <salah.triki@acm.org>
---
 drivers/base/regmap/regcache-lzo.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/base/regmap/regcache-lzo.c b/drivers/base/regmap/regcache-lzo.c
index 2d53f6f..67245d0 100644
--- a/drivers/base/regmap/regcache-lzo.c
+++ b/drivers/base/regmap/regcache-lzo.c
@@ -46,11 +46,10 @@ static int regcache_lzo_prepare(struct regcache_lzo_ctx *lzo_ctx)
 static int regcache_lzo_compress(struct regcache_lzo_ctx *lzo_ctx)
 {
 	size_t compress_size;
-	int ret;
 
-	ret = lzo1x_1_compress(lzo_ctx->src, lzo_ctx->src_len,
+	lzo1x_1_compress(lzo_ctx->src, lzo_ctx->src_len,
 			       lzo_ctx->dst, &compress_size, lzo_ctx->wmem);
-	if (ret != LZO_E_OK || compress_size > lzo_ctx->dst_len)
+	if (compress_size > lzo_ctx->dst_len)
 		return -EINVAL;
 	lzo_ctx->dst_len = compress_size;
 	return 0;
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1202986

[Multipart message — attachments visible in raw view] — view raw

On Fri, Aug 07, 2015 at 06:33:36PM +0100, Salah Triki wrote:
> lzo1x_1_do_compress always returns LZO_E_OK. Thus, the check of the
> return value is useless.

No, if you want to do this then you should be fixing the LZO API to
remove the returned value - if a value is being returned it's always
good practice to pay attention to that, not doing that because the
current implementation happens to have some behaviour just makes the
code more fragile if someone comes along and changes the implementation.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web