Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1202833 > unrolled thread

Re: [Xen-devel] [PATCH v5 0/6] xen/PMU: PMU support for Xen PV(H) guests

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [Xen-devel] [PATCH v5 0/6] xen/PMU: PMU support for Xen PV(H)  guests David Vrabel <david.vrabel@citrix.com> - 2015-08-07 17:40 +0200
    Re: [Xen-devel] [PATCH v5 0/6] xen/PMU: PMU support for Xen PV(H)  guests Julien Grall <julien.grall@citrix.com> - 2015-08-07 18:00 +0200
      Re: [Xen-devel] [PATCH v5 0/6] xen/PMU: PMU support for Xen PV(H)  guests Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2015-08-07 18:10 +0200

#1202833 — Re: [Xen-devel] [PATCH v5 0/6] xen/PMU: PMU support for Xen PV(H) guests

On 02/07/15 15:53, Boris Ostrovsky wrote:
> I haven't posted Linux part of PV(H) VPMU support in a while but now
> that (hopefully) the hypervisor part is getting close to be done I
> think it's time to post it again.
> 
> There are very few differences compared to the last version, mostly due
> to updates in shared structures layouts. Patches 1 and 4 have no changes
> at all and patch 5 has minor changes due to rebasing so I kept David's
> Reviewed-by tag.

This breaks the arm and arm64 builds.

In file included from
/local/davidvr/work/k.org/tip/drivers/xen/sys-hypervisor.c:23:0:
/local/davidvr/work/k.org/tip/include/xen/interface/xenpmu.h:91:22:
error: field ‘pmu’ has incomplete type
  struct xen_pmu_arch pmu;
                      ^
/local/davidvr/work/k.org/tip/drivers/xen/sys-hypervisor.c: In function
‘pmu_mode_store’:
/local/davidvr/work/k.org/tip/drivers/xen/sys-hypervisor.c:403:2: error:
implicit declaration of function ‘HYPERVISOR_xenpmu_op’
[-Werror=implicit-function-declaration]
  ret = HYPERVISOR_xenpmu_op(XENPMU_mode_set, &xp);
  ^
cc1: some warnings being treated as errors
/local/davidvr/work/k.org/tip/scripts/Makefile.build:258: recipe for
target 'drivers/xen/sys-hypervisor.o' failed
make[3]: *** [drivers/xen/sys-hypervisor.o] Error 1
make[3]: *** Waiting for unfinished jobs....
/local/davidvr/work/k.org/tip/drivers/xen/xenfs/xensyms.c: In function
‘xensyms_next_sym’:
/local/davidvr/work/k.org/tip/drivers/xen/xenfs/xensyms.c:34:2: error:
implicit declaration of function ‘HYPERVISOR_dom0_op’
[-Werror=implicit-function-declaration]
  ret = HYPERVISOR_dom0_op(&xs->op);
  ^
cc1: some warnings being treated as errors
/local/davidvr/work/k.org/tip/scripts/Makefile.build:258: recipe for
target 'drivers/xen/xenfs/xensyms.o' failed
make[4]: *** [drivers/xen/xenfs/xensyms.o] Error 1
/local/davidvr/work/k.org/tip/scripts/Makefile.build:403: recipe for
target 'drivers/xen/xenfs' failed
make[3]: *** [drivers/xen/xenfs] Error 2
/local/davidvr/work/k.org/tip/scripts/Makefile.build:403: recipe for
target 'drivers/xen' failed
make[2]: *** [drivers/xen] Error 2
/local/davidvr/work/k.org/tip/Makefile:944: recipe for target 'drivers'
failed
make[1]: *** [drivers] Error 2
make[1]: Leaving directory '/local/davidvr/work/k.org/o-arm64'
Makefile:146: recipe for target 'sub-make' failed
make: *** [sub-make] Error 2

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1202844

Hi,

On 07/08/15 16:35, David Vrabel wrote:
> On 02/07/15 15:53, Boris Ostrovsky wrote:
>> I haven't posted Linux part of PV(H) VPMU support in a while but now
>> that (hopefully) the hypervisor part is getting close to be done I
>> think it's time to post it again.
>>
>> There are very few differences compared to the last version, mostly due
>> to updates in shared structures layouts. Patches 1 and 4 have no changes
>> at all and patch 5 has minor changes due to rebasing so I kept David's
>> Reviewed-by tag.
> 
> This breaks the arm and arm64 builds.
> 
> In file included from
> /local/davidvr/work/k.org/tip/drivers/xen/sys-hypervisor.c:23:0:
> /local/davidvr/work/k.org/tip/include/xen/interface/xenpmu.h:91:22:
> error: field ‘pmu’ has incomplete type
>   struct xen_pmu_arch pmu;
>                       ^
> /local/davidvr/work/k.org/tip/drivers/xen/sys-hypervisor.c: In function
> ‘pmu_mode_store’:
> /local/davidvr/work/k.org/tip/drivers/xen/sys-hypervisor.c:403:2: error:
> implicit declaration of function ‘HYPERVISOR_xenpmu_op’
> [-Werror=implicit-function-declaration]
>   ret = HYPERVISOR_xenpmu_op(XENPMU_mode_set, &xp);
>   ^

There is no PMU support for the moment on ARM and this hypercall is only
used for x86. I would introduce a new CONFIG (CONFIG_XEN_PMMU) which is
enabled for x86 and disabled for ARM.

> cc1: some warnings being treated as errors
> /local/davidvr/work/k.org/tip/scripts/Makefile.build:258: recipe for
> target 'drivers/xen/sys-hypervisor.o' failed
> make[3]: *** [drivers/xen/sys-hypervisor.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
> /local/davidvr/work/k.org/tip/drivers/xen/xenfs/xensyms.c: In function
> ‘xensyms_next_sym’:
> /local/davidvr/work/k.org/tip/drivers/xen/xenfs/xensyms.c:34:2: error:
> implicit declaration of function ‘HYPERVISOR_dom0_op’
> [-Werror=implicit-function-declaration]
>   ret = HYPERVISOR_dom0_op(&xs->op);
>   ^

DOM0 op doesn't exists for ARM and xensyms is not even plumbed. I would
make sure that XEN_SYMS is not enabled for ARM maybe adding the line
below in the kconfig?

depends on X86 && XEN_DOM0 && XENFS

Regards,

-- 
Julien Grall
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1202847

On 08/07/2015 11:50 AM, Julien Grall wrote:
> Hi,
>
> On 07/08/15 16:35, David Vrabel wrote:
>> On 02/07/15 15:53, Boris Ostrovsky wrote:
>>> I haven't posted Linux part of PV(H) VPMU support in a while but now
>>> that (hopefully) the hypervisor part is getting close to be done I
>>> think it's time to post it again.
>>>
>>> There are very few differences compared to the last version, mostly due
>>> to updates in shared structures layouts. Patches 1 and 4 have no changes
>>> at all and patch 5 has minor changes due to rebasing so I kept David's
>>> Reviewed-by tag.
>> This breaks the arm and arm64 builds.
>>
>> In file included from
>> /local/davidvr/work/k.org/tip/drivers/xen/sys-hypervisor.c:23:0:
>> /local/davidvr/work/k.org/tip/include/xen/interface/xenpmu.h:91:22:
>> error: field ‘pmu’ has incomplete type
>>    struct xen_pmu_arch pmu;
>>                        ^
>> /local/davidvr/work/k.org/tip/drivers/xen/sys-hypervisor.c: In function
>> ‘pmu_mode_store’:
>> /local/davidvr/work/k.org/tip/drivers/xen/sys-hypervisor.c:403:2: error:
>> implicit declaration of function ‘HYPERVISOR_xenpmu_op’
>> [-Werror=implicit-function-declaration]
>>    ret = HYPERVISOR_xenpmu_op(XENPMU_mode_set, &xp);
>>    ^
> There is no PMU support for the moment on ARM and this hypercall is only
> used for x86. I would introduce a new CONFIG (CONFIG_XEN_PMMU) which is
> enabled for x86 and disabled for ARM.

CONFIG_XEN_VPMU, but yes.


>
>> cc1: some warnings being treated as errors
>> /local/davidvr/work/k.org/tip/scripts/Makefile.build:258: recipe for
>> target 'drivers/xen/sys-hypervisor.o' failed
>> make[3]: *** [drivers/xen/sys-hypervisor.o] Error 1
>> make[3]: *** Waiting for unfinished jobs....
>> /local/davidvr/work/k.org/tip/drivers/xen/xenfs/xensyms.c: In function
>> ‘xensyms_next_sym’:
>> /local/davidvr/work/k.org/tip/drivers/xen/xenfs/xensyms.c:34:2: error:
>> implicit declaration of function ‘HYPERVISOR_dom0_op’
>> [-Werror=implicit-function-declaration]
>>    ret = HYPERVISOR_dom0_op(&xs->op);
>>    ^
> DOM0 op doesn't exists for ARM and xensyms is not even plumbed. I would
> make sure that XEN_SYMS is not enabled for ARM maybe adding the line
> below in the kconfig?
>
> depends on X86 && XEN_DOM0 && XENFS

Yes. Sorry for breakage. I usually build the hypervisor for ARM but 
clearly didn't do this for Linux.

-boris


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web