Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1202257 > unrolled thread

[PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.

Started byJunsu Shin <jjunes0@gmail.com>
First post2015-08-07 05:00 +0200
Last post2015-08-08 19:10 +0200
Articles 6 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue. Junsu Shin <jjunes0@gmail.com> - 2015-08-07 05:00 +0200
    Re: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters  coding style issue. Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-07 06:50 +0200
      Re: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters  coding style issue. Junsu Shin <jjunes0@gmail.com> - 2015-08-08 09:00 +0200
        Re: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters  coding style issue. Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-08 12:20 +0200
          Re: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters  coding style issue. Greg KH <gregkh@linuxfoundation.org> - 2015-08-08 17:50 +0200
            Re: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80  characters coding style issue. Joe Perches <joe@perches.com> - 2015-08-08 19:10 +0200

#1202257 — [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.

FromJunsu Shin <jjunes0@gmail.com>
Date2015-08-07 05:00 +0200
Subject[PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.
Message-ID<pUG30-36H-1@gated-at.bofh.it>
 This is a patch to the dm365_ipipe.c that fixes over 80 characters warning detected by checkpatch.pl.
 Signed-off-by: Junsu Shin <jjunes0@gmail.com>

---
 drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
index 1bbb90c..57cd274 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
+++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
@@ -1536,8 +1536,9 @@ ipipe_get_format(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg,
  * @fse: pointer to v4l2_subdev_frame_size_enum structure.
  */
 static int
-ipipe_enum_frame_size(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg,
-			  struct v4l2_subdev_frame_size_enum *fse)
+ipipe_enum_frame_size(struct v4l2_subdev *sd,
+			struct v4l2_subdev_pad_config *cfg,
+			struct v4l2_subdev_frame_size_enum *fse)
 {
 	struct vpfe_ipipe_device *ipipe = v4l2_get_subdevdata(sd);
 	struct v4l2_mbus_framefmt format;
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1202285 — Re: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.

FromSudip Mukherjee <sudipm.mukherjee@gmail.com>
Date2015-08-07 06:50 +0200
SubjectRe: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.
Message-ID<pUHLr-5D8-1@gated-at.bofh.it>
In reply to#1202257
On Thu, Aug 06, 2015 at 09:55:54PM -0500, Junsu Shin wrote:
>  This is a patch to the dm365_ipipe.c that fixes over 80 characters warning detected by checkpatch.pl.
>  Signed-off-by: Junsu Shin <jjunes0@gmail.com>
please do not use whitespace before Signed-off-by: line.
> 
> ---
>  drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> index 1bbb90c..57cd274 100644
> --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> @@ -1536,8 +1536,9 @@ ipipe_get_format(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg,
>   * @fse: pointer to v4l2_subdev_frame_size_enum structure.
>   */
>  static int
> -ipipe_enum_frame_size(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg,
> -			  struct v4l2_subdev_frame_size_enum *fse)
> +ipipe_enum_frame_size(struct v4l2_subdev *sd,
> +			struct v4l2_subdev_pad_config *cfg,
> +			struct v4l2_subdev_frame_size_enum *fse)
since you are modifying this line, please fix up the indention also.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1203185 — Re: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.

FromJunsu Shin <jjunes0@gmail.com>
Date2015-08-08 09:00 +0200
SubjectRe: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.
Message-ID<pV6gN-7Yr-1@gated-at.bofh.it>
In reply to#1202285
On 08/06/2015 11:45 PM, Sudip Mukherjee wrote:
> On Thu, Aug 06, 2015 at 09:55:54PM -0500, Junsu Shin wrote:
>>  This is a patch to the dm365_ipipe.c that fixes over 80 characters warning detected by checkpatch.pl.
>>  Signed-off-by: Junsu Shin <jjunes0@gmail.com>
> please do not use whitespace before Signed-off-by: line.
>>
>> ---
>>  drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
>> index 1bbb90c..57cd274 100644
>> --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
>> +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
>> @@ -1536,8 +1536,9 @@ ipipe_get_format(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg,
>>   * @fse: pointer to v4l2_subdev_frame_size_enum structure.
>>   */
>>  static int
>> -ipipe_enum_frame_size(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg,
>> -			  struct v4l2_subdev_frame_size_enum *fse)
>> +ipipe_enum_frame_size(struct v4l2_subdev *sd,
>> +			struct v4l2_subdev_pad_config *cfg,
>> +			struct v4l2_subdev_frame_size_enum *fse)
> since you are modifying this line, please fix up the indention also.
> 
> regards
> sudip
> 

Thanks for pointing it out.
Again, this is a patch to the dm365_ipipe.c that fixes over 80 characters warning detected by the script.
This time I fixed up the indentation issue claimed in the previous one.
Signed-off-by: Junsu Shin <jjunes0@gmail.com>
---
 drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
index 1bbb90c..a474adf 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
+++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
@@ -1536,8 +1536,9 @@ ipipe_get_format(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg,
  * @fse: pointer to v4l2_subdev_frame_size_enum structure.
  */
 static int
-ipipe_enum_frame_size(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg,
-			  struct v4l2_subdev_frame_size_enum *fse)
+ipipe_enum_frame_size(struct v4l2_subdev *sd,
+		       struct v4l2_subdev_pad_config *cfg,
+		       struct v4l2_subdev_frame_size_enum *fse)
 {
 	struct vpfe_ipipe_device *ipipe = v4l2_get_subdevdata(sd);
 	struct v4l2_mbus_framefmt format;
-- 
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1203241 — Re: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.

FromSudip Mukherjee <sudipm.mukherjee@gmail.com>
Date2015-08-08 12:20 +0200
SubjectRe: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.
Message-ID<pV9ol-4cc-5@gated-at.bofh.it>
In reply to#1203185
On Sat, Aug 08, 2015 at 01:55:02AM -0500, Junsu Shin wrote:
> 
> On 08/06/2015 11:45 PM, Sudip Mukherjee wrote:
> > On Thu, Aug 06, 2015 at 09:55:54PM -0500, Junsu Shin wrote:
> > 
<snip>
> 
> Thanks for pointing it out.
> Again, this is a patch to the dm365_ipipe.c that fixes over 80 characters warning detected by the script.
> This time I fixed up the indentation issue claimed in the previous one.
> Signed-off-by: Junsu Shin <jjunes0@gmail.com>
> ---
Greg will not accept patches like this way. please send it as v2.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1203287 — Re: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.

FromGreg KH <gregkh@linuxfoundation.org>
Date2015-08-08 17:50 +0200
SubjectRe: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.
Message-ID<pVexI-32k-9@gated-at.bofh.it>
In reply to#1203241
On Sat, Aug 08, 2015 at 03:42:18PM +0530, Sudip Mukherjee wrote:
> On Sat, Aug 08, 2015 at 01:55:02AM -0500, Junsu Shin wrote:
> > 
> > On 08/06/2015 11:45 PM, Sudip Mukherjee wrote:
> > > On Thu, Aug 06, 2015 at 09:55:54PM -0500, Junsu Shin wrote:
> > > 
> <snip>
> > 
> > Thanks for pointing it out.
> > Again, this is a patch to the dm365_ipipe.c that fixes over 80 characters warning detected by the script.
> > This time I fixed up the indentation issue claimed in the previous one.
> > Signed-off-by: Junsu Shin <jjunes0@gmail.com>
> > ---
> Greg will not accept patches like this way. please send it as v2.

Greg does not accept drivers/staging/media/* patches, but anyway, no one
will accept a patch in this format, as you say.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1203326 — Re: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.

FromJoe Perches <joe@perches.com>
Date2015-08-08 19:10 +0200
SubjectRe: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.
Message-ID<pVfN8-50E-5@gated-at.bofh.it>
In reply to#1203287
On Sat, 2015-08-08 at 08:42 -0700, Greg KH wrote:
> Greg does not accept drivers/staging/media/* patches,

You could change
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 111a6b2..089c458 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9742,6 +9742,7 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
 L:	devel@driverdev.osuosl.org
 S:	Supported
 F:	drivers/staging/
+X:	drivers/staging/media/
 
 STAGING - COMEDI
 M:	Ian Abbott <abbotti@mev.co.uk>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web