Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1200446 > unrolled thread

[PATCH -next] s390: lib: Export __delay

Back to article view | Back to linux.kernel

Contents

  [PATCH -next] s390: lib: Export __delay Guenter Roeck <linux@roeck-us.net> - 2015-08-05 08:40 +0200
    Re: [PATCH -next] s390: lib: Export __delay Heiko Carstens <heiko.carstens@de.ibm.com> - 2015-08-05 09:20 +0200

#1200446 — [PATCH -next] s390: lib: Export __delay

__delay is exported by most architectures, and may be used in modules.
Since it is not exported for s390, s390:allmodconfig currently fails
to build with

ERROR: "__delay" [drivers/net/phy/mdio-octeon.ko] undefined!

Fixes: a6d678645210 ("net: mdio-octeon: Modify driver to work on both
	ThunderX and Octeon")
Cc: Radha Mohan Chintakuntla <rchintakuntla@cavium.com>
Cc: David Daney <david.daney@cavium.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 arch/s390/lib/delay.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/s390/lib/delay.c b/arch/s390/lib/delay.c
index 16dc42d83f93..246a7eb4b680 100644
--- a/arch/s390/lib/delay.c
+++ b/arch/s390/lib/delay.c
@@ -26,6 +26,7 @@ void __delay(unsigned long loops)
          */
 	asm volatile("0: brct %0,0b" : : "d" ((loops/2) + 1));
 }
+EXPORT_SYMBOL(__delay);
 
 static void __udelay_disabled(unsigned long long usecs)
 {
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1200467

On Tue, Aug 04, 2015 at 11:38:23PM -0700, Guenter Roeck wrote:
> __delay is exported by most architectures, and may be used in modules.
> Since it is not exported for s390, s390:allmodconfig currently fails
> to build with
> 
> ERROR: "__delay" [drivers/net/phy/mdio-octeon.ko] undefined!
> 
> Fixes: a6d678645210 ("net: mdio-octeon: Modify driver to work on both
> 	ThunderX and Octeon")
> Cc: Radha Mohan Chintakuntla <rchintakuntla@cavium.com>
> Cc: David Daney <david.daney@cavium.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  arch/s390/lib/delay.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web