Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1198372 > unrolled thread
| Started by | Pavel Machek <pavel@ucw.cz> |
|---|---|
| First post | 2015-08-02 09:20 +0200 |
| Last post | 2015-08-03 19:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] HID: use generic driver for ThingM blink(1) if !CONFIG_HID_THINGM Pavel Machek <pavel@ucw.cz> - 2015-08-02 09:20 +0200
Re: [PATCH] HID: use generic driver for ThingM blink(1) if !CONFIG_HID_THINGM Jiri Kosina <jkosina@suse.com> - 2015-08-03 11:30 +0200
Re: [PATCH] HID: use generic driver for ThingM blink(1) if !CONFIG_HID_THINGM Reilly Grant <reillyg@chromium.org> - 2015-08-03 19:00 +0200
| From | Pavel Machek <pavel@ucw.cz> |
|---|---|
| Date | 2015-08-02 09:20 +0200 |
| Subject | Re: [PATCH] HID: use generic driver for ThingM blink(1) if !CONFIG_HID_THINGM |
| Message-ID | <pSVIR-5g5-3@gated-at.bofh.it> |
On Mon 2015-07-27 12:17:06, Reilly Grant wrote:
> In commit 30ba2fbde1840db44 an LED class driver for this device was
> added and at the same time it was blacklisted by the hid-generic
> driver. This patch removes the device from the hid-generic driver's
> blacklist if the LED class driver is not enabled.
>
> Signed-off-by: Reilly Grant <reillyg@chromium.org>
I'd not do it.
Either special driver for this is not needed, and should be
removed. Or we should ask users to always use the special driver. We
should not have two drivers for same hardware.
Pavel
> drivers/hid/hid-core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index d9c7cd9..afa744f 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -1978,7 +1978,9 @@ static const struct hid_device_id hid_have_special_driver[] = {
> { HID_USB_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_VAIO_VGP_MOUSE) },
> { HID_USB_DEVICE(USB_VENDOR_ID_STEELSERIES, USB_DEVICE_ID_STEELSERIES_SRWS1) },
> { HID_USB_DEVICE(USB_VENDOR_ID_SUNPLUS, USB_DEVICE_ID_SUNPLUS_WDESKTOP) },
> +#if IS_ENABLED(CONFIG_HID_THINGM)
> { HID_USB_DEVICE(USB_VENDOR_ID_THINGM, USB_DEVICE_ID_BLINK1) },
> +#endif
> { HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb300) },
> { HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb304) },
> { HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb323) },
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Jiri Kosina <jkosina@suse.com> |
|---|---|
| Date | 2015-08-03 11:30 +0200 |
| Message-ID | <pTkee-7lf-35@gated-at.bofh.it> |
| In reply to | #1198372 |
On Sun, 2 Aug 2015, Reilly Grant wrote: > There is existing user space software (not just mine, also from the > manufacturer) that does not use the special driver and instead uses hidraw > or usbdevice_fs to control the device. LED class driver support for this > device is useful but should be optional. Is there any problem for the userspace software to unbind the kernel driver first? -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Reilly Grant <reillyg@chromium.org> |
|---|---|
| Date | 2015-08-03 19:00 +0200 |
| Subject | Re: [PATCH] HID: use generic driver for ThingM blink(1) if !CONFIG_HID_THINGM |
| Message-ID | <pTrfJ-uN-27@gated-at.bofh.it> |
| In reply to | #1198666 |
If the software is using usbdevice_fs, no, it can simply detach the kernel driver. If the software is using hidraw then this blacklist becomes the issue because even if you unload the special driver the generic HID driver won't load. Is there a mechanism in the HID subsystem for drivers to build on top of the generic one instead of replacing it? On Mon, Aug 3, 2015, 2:25 AM Jiri Kosina <jkosina@suse.com> wrote: > > On Sun, 2 Aug 2015, Reilly Grant wrote: > > > There is existing user space software (not just mine, also from the > > manufacturer) that does not use the special driver and instead uses hidraw > > or usbdevice_fs to control the device. LED class driver support for this > > device is useful but should be optional. > > Is there any problem for the userspace software to unbind the kernel > driver first? > > -- > Jiri Kosina > SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web