Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1198552 > unrolled thread
| Started by | MyungJoo Ham <myungjoo.ham@samsung.com> |
|---|---|
| First post | 2015-08-03 07:20 +0200 |
| Last post | 2015-08-03 07:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
Re: [PATCH 03/15] drivers: devfreq: Drop unlikely before IS_ERR(_OR_NULL) MyungJoo Ham <myungjoo.ham@samsung.com> - 2015-08-03 07:20 +0200
Re: [PATCH 03/15] drivers: devfreq: Drop unlikely before IS_ERR(_OR_NULL) Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-03 07:50 +0200
| From | MyungJoo Ham <myungjoo.ham@samsung.com> |
|---|---|
| Date | 2015-08-03 07:20 +0200 |
| Subject | Re: [PATCH 03/15] drivers: devfreq: Drop unlikely before IS_ERR(_OR_NULL) |
| Message-ID | <pTgki-1sd-11@gated-at.bofh.it> |
PiBJU19FUlIoX09SX05VTEwpIGFscmVhZHkgY29udGFpbiBhbiAndW5saWtlbHknIGNvbXBpbGVy IGZsYWcgYW5kIHRoZXJlDQo+IGlzIG5vIG5lZWQgdG8gZG8gdGhhdCBhZ2FpbiBmcm9tIGl0cyBj YWxsZXJzLiBEcm9wIGl0Lg0KPiANCj4gU2lnbmVkLW9mZi1ieTogVmlyZXNoIEt1bWFyIDx2aXJl c2gua3VtYXJAbGluYXJvLm9yZz4NCg0KQCBmcm9tIGluY2x1ZGUvbGludXgvZXJyLmgNCiNkZWZp bmUgSVNfRVJSX1ZBTFVFKHgpIHVubGlrZWx5KCh4KSA+PSAodW5zaWduZWQgbG9uZyktTUFYX0VS Uk5PKQ0KLi4uDQpzdGF0aWMgaW5saW5lIGJvb2wgX19tdXN0X2NoZWNrIElTX0VSUl9PUl9OVUxM KF9fZm9yY2UgY29uc3Qgdm9pZCAqcHRyKQ0Kew0KCXJldHVybiAhcHRyIHx8IElTX0VSUl9WQUxV RSgodW5zaWduZWQgbG9uZylwdHIpOw0KfQ0KDQoiIXB0ciIgYXBwZWFycyBub3QgY292ZXJlZCB3 aXRoIElTX0VSUl9PUl9OVUxMLg0KKG9ubHkgdGhlIElTX0VSUiBwYXJ0IHNlZW1zIGNvdmVyZWQp DQoNCg0KQ2hlZXJzLA0KTXl1bmdKb28NCg0K -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Viresh Kumar <viresh.kumar@linaro.org> |
|---|---|
| Date | 2015-08-03 07:50 +0200 |
| Message-ID | <pTgNk-203-7@gated-at.bofh.it> |
| In reply to | #1198552 |
On 03-08-15, 05:10, MyungJoo Ham wrote:
> > IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there
> > is no need to do that again from its callers. Drop it.
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> @ from include/linux/err.h
> #define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO)
> ...
> static inline bool __must_check IS_ERR_OR_NULL(__force const void *ptr)
> {
> return !ptr || IS_ERR_VALUE((unsigned long)ptr);
> }
>
> "!ptr" appears not covered with IS_ERR_OR_NULL.
> (only the IS_ERR part seems covered)
Right, the first patch of the series has fixed that.
http://permalink.gmane.org/gmane.linux.kernel/2009151
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web