Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1195203 > unrolled thread

Re: [PATCH V3 3/5] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY% in report -D

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH V3 3/5] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY%  in report -D Jiri Olsa <jolsa@redhat.com> - 2015-07-29 16:00 +0200
    RE: [PATCH V3 3/5] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY%  in report -D "Liang, Kan" <kan.liang@intel.com> - 2015-08-04 19:10 +0200
      Re: [PATCH V3 3/5] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY%  in report -D Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-04 20:00 +0200

#1195203 — Re: [PATCH V3 3/5] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY% in report -D

On Tue, Jul 28, 2015 at 07:29:33AM -0400, kan.liang@intel.com wrote:

SNIP

>  
> -static int machines__deliver_event(struct machines *machines,
> +static int machines__deliver_event(struct perf_session *session,
>  				   struct perf_evlist *evlist,
>  				   union perf_event *event,
>  				   struct perf_sample *sample,
>  				   struct perf_tool *tool, u64 file_offset)
>  {
> +	struct machines *machines = &session->machines;
>  	struct perf_evsel *evsel;
>  	struct machine *machine;
>  
> @@ -1053,11 +1079,12 @@ static int machines__deliver_event(struct machines *machines,
>  
>  	switch (event->header.type) {
>  	case PERF_RECORD_SAMPLE:
> -		dump_sample(evsel, event, sample);
>  		if (evsel == NULL) {
>  			++evlist->stats.nr_unknown_id;
>  			return 0;
>  		}
> +		dump_sample(session, evlist, evsel, event, sample);

same here, you could pass only session all the way through

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1200168

> Em Wed, Jul 29, 2015 at 12:43:22PM -0300, Arnaldo Carvalho de Melo
> escreveu:
> > Em Wed, Jul 29, 2015 at 02:53:29PM +0200, Jiri Olsa escreveu:
> > > >  	switch (event->header.type) {
> > > >  	case PERF_RECORD_SAMPLE:
> > > > -		dump_sample(evsel, event, sample);
> > > >  		if (evsel == NULL) {
> > > >  			++evlist->stats.nr_unknown_id;
> > > >  			return 0;
> > > >  		}
> > > > +		dump_sample(session, evlist, evsel, event, sample);
> > >
> > > same here, you could pass only session all the way through
> >
> > I'll take a look at how interesting it would be to have a
> > evsel->evlist, that if NULL means the evsel is freestanding, but when
> > it is linked to an evlist, then it will be there. This way we wouldn't
> > have to pass (evlist, evsel) when the main purpose of a function is
> > about an evsel but we need information that is logically associated to
> > all evsels in a list, i.e. that is in evsel->evlist.
> 
> There are no cases where a function receives (evsel, evlist) with that evlist
> containing that evsel :-\
> 
> Perhaps this will be the first, i.e. rename perf_session_env to perf_env,
> then store it in evlist->env, then when processing something where we
> have a evsel or evlist we can access that env from:
> 
>     evsel->evlist->env;
> 
> Will continue after lunch, trying to prototype what I just described.
>
Hi Arnaldo,

Have you got a chance to implement the prototype for evlist->env?

Thanks,
Kan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1200189

Em Tue, Aug 04, 2015 at 05:07:40PM +0000, Liang, Kan escreveu:
> > Em Wed, Jul 29, 2015 at 12:43:22PM -0300, Arnaldo Carvalho de Melo
> > > I'll take a look at how interesting it would be to have a
> > > evsel->evlist, that if NULL means the evsel is freestanding, but when
> > > it is linked to an evlist, then it will be there. This way we wouldn't
> > > have to pass (evlist, evsel) when the main purpose of a function is
> > > about an evsel but we need information that is logically associated to
> > > all evsels in a list, i.e. that is in evsel->evlist.

> > There are no cases where a function receives (evsel, evlist) with that evlist
> > containing that evsel :-\

> > Perhaps this will be the first, i.e. rename perf_session_env to perf_env,
> > then store it in evlist->env, then when processing something where we
> > have a evsel or evlist we can access that env from:

> >     evsel->evlist->env;

> > Will continue after lunch, trying to prototype what I just described.

> Hi Arnaldo,

> Have you got a chance to implement the prototype for evlist->env?

Not really, got sidetracked :-\

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web