Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1199374 > unrolled thread

[PATCH V3 request from stable 3.10 to 3.14] efi: fix 32bit kernel boot failed problem using efi

Started by<fupan.li@windriver.com>
First post2015-08-04 04:00 +0200
Last post2015-08-09 00:10 +0200
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH V3 request from stable 3.10 to 3.14] efi: fix 32bit kernel boot failed problem using efi <fupan.li@windriver.com> - 2015-08-04 04:00 +0200
    Re: [PATCH V3 request from stable 3.10 to 3.14] efi: fix 32bit  kernel boot failed problem using efi Matt Fleming <matt@codeblueprint.co.uk> - 2015-08-04 19:20 +0200
    Patch "efi: fix 32bit kernel boot failed problem using efi" has been added to the 3.14-stable tree <gregkh@linuxfoundation.org> - 2015-08-09 00:10 +0200
    Patch "efi: fix 32bit kernel boot failed problem using efi" has been added to the 3.10-stable tree <gregkh@linuxfoundation.org> - 2015-08-09 00:10 +0200

#1199374 — [PATCH V3 request from stable 3.10 to 3.14] efi: fix 32bit kernel boot failed problem using efi

From<fupan.li@windriver.com>
Date2015-08-04 04:00 +0200
Subject[PATCH V3 request from stable 3.10 to 3.14] efi: fix 32bit kernel boot failed problem using efi
Message-ID<pTzGi-4pM-11@gated-at.bofh.it>
From: Fupan Li <fupan.li@windriver.com>

Commit 35d5134b7d5a
("x86/efi: Correct EFI boot stub use of code32_start")
imported a bug, which will cause 32bit kernel boot failed
using efi method. It should use the label's address instead
of the value stored in the label to caculate the address of
code32_start.

Signed-off-by: Fupan Li <fupan.li@windriver.com>
---
 arch/x86/boot/compressed/head_32.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/boot/compressed/head_32.S b/arch/x86/boot/compressed/head_32.S
index abb988a..3b28eff 100644
--- a/arch/x86/boot/compressed/head_32.S
+++ b/arch/x86/boot/compressed/head_32.S
@@ -54,7 +54,7 @@ ENTRY(efi_pe_entry)
 	call	reloc
 reloc:
 	popl	%ecx
-	subl	reloc, %ecx
+	subl	$reloc, %ecx
 	movl	%ecx, BP_code32_start(%eax)
 
 	sub	$0x4, %esp
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1200170 — Re: [PATCH V3 request from stable 3.10 to 3.14] efi: fix 32bit kernel boot failed problem using efi

FromMatt Fleming <matt@codeblueprint.co.uk>
Date2015-08-04 19:20 +0200
SubjectRe: [PATCH V3 request from stable 3.10 to 3.14] efi: fix 32bit kernel boot failed problem using efi
Message-ID<pTO2D-9e-9@gated-at.bofh.it>
In reply to#1199374
On Tue, 04 Aug, at 09:51:21AM, fupan.li@windriver.com wrote:
> From: Fupan Li <fupan.li@windriver.com>
> 
> Commit 35d5134b7d5a
> ("x86/efi: Correct EFI boot stub use of code32_start")
> imported a bug, which will cause 32bit kernel boot failed
> using efi method. It should use the label's address instead
> of the value stored in the label to caculate the address of
> code32_start.
> 
> Signed-off-by: Fupan Li <fupan.li@windriver.com>
> ---
>  arch/x86/boot/compressed/head_32.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Matt Fleming <matt.fleming@intel.com>

-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1203378 — Patch "efi: fix 32bit kernel boot failed problem using efi" has been added to the 3.14-stable tree

From<gregkh@linuxfoundation.org>
Date2015-08-09 00:10 +0200
SubjectPatch "efi: fix 32bit kernel boot failed problem using efi" has been added to the 3.14-stable tree
Message-ID<pVktr-3jX-3@gated-at.bofh.it>
In reply to#1199374
This is a note to let you know that I've just added the patch titled

    efi: fix 32bit kernel boot failed problem using efi

to the 3.14-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     efi-fix-32bit-kernel-boot-failed-problem-using-efi.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


From fupan.li@windriver.com  Sat Aug  8 15:03:02 2015
From: <fupan.li@windriver.com>
Date: Tue, 4 Aug 2015 09:51:21 +0800
Subject: efi: fix 32bit kernel boot failed problem using efi
To: <gregkh@linuxfoundation.org>, <matt@codeblueprint.co.uk>
Cc: <jslaby@suse.cz>, <linux-efi@vger.kernel.org>, <stable@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <fupanli@gmail.com>, <ben@decadent.org.uk>
Message-ID: <1438653081-25746-1-git-send-email-fupan.li@windriver.com>

From: Fupan Li <fupan.li@windriver.com>

Commit 35d5134b7d5a
("x86/efi: Correct EFI boot stub use of code32_start")
imported a bug, which will cause 32bit kernel boot failed
using efi method. It should use the label's address instead
of the value stored in the label to caculate the address of
code32_start.

Signed-off-by: Fupan Li <fupan.li@windriver.com>
Reviewed-by: Matt Fleming <matt.fleming@intel.com>
---
 arch/x86/boot/compressed/head_32.S |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/x86/boot/compressed/head_32.S
+++ b/arch/x86/boot/compressed/head_32.S
@@ -54,7 +54,7 @@ ENTRY(efi_pe_entry)
 	call	reloc
 reloc:
 	popl	%ecx
-	subl	reloc, %ecx
+	subl	$reloc, %ecx
 	movl	%ecx, BP_code32_start(%eax)
 
 	sub	$0x4, %esp


Patches currently in stable-queue which might be from fupan.li@windriver.com are

queue-3.14/efi-fix-32bit-kernel-boot-failed-problem-using-efi.patch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1203384 — Patch "efi: fix 32bit kernel boot failed problem using efi" has been added to the 3.10-stable tree

From<gregkh@linuxfoundation.org>
Date2015-08-09 00:10 +0200
SubjectPatch "efi: fix 32bit kernel boot failed problem using efi" has been added to the 3.10-stable tree
Message-ID<pVkts-3jX-27@gated-at.bofh.it>
In reply to#1199374
This is a note to let you know that I've just added the patch titled

    efi: fix 32bit kernel boot failed problem using efi

to the 3.10-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     efi-fix-32bit-kernel-boot-failed-problem-using-efi.patch
and it can be found in the queue-3.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


From fupan.li@windriver.com  Sat Aug  8 15:03:02 2015
From: <fupan.li@windriver.com>
Date: Tue, 4 Aug 2015 09:51:21 +0800
Subject: efi: fix 32bit kernel boot failed problem using efi
To: <gregkh@linuxfoundation.org>, <matt@codeblueprint.co.uk>
Cc: <jslaby@suse.cz>, <linux-efi@vger.kernel.org>, <stable@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <fupanli@gmail.com>, <ben@decadent.org.uk>
Message-ID: <1438653081-25746-1-git-send-email-fupan.li@windriver.com>

From: Fupan Li <fupan.li@windriver.com>

Commit 35d5134b7d5a
("x86/efi: Correct EFI boot stub use of code32_start")
imported a bug, which will cause 32bit kernel boot failed
using efi method. It should use the label's address instead
of the value stored in the label to caculate the address of
code32_start.

Signed-off-by: Fupan Li <fupan.li@windriver.com>
Reviewed-by: Matt Fleming <matt.fleming@intel.com>
---
 arch/x86/boot/compressed/head_32.S |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/x86/boot/compressed/head_32.S
+++ b/arch/x86/boot/compressed/head_32.S
@@ -54,7 +54,7 @@ ENTRY(efi_pe_entry)
 	call	reloc
 reloc:
 	popl	%ecx
-	subl	reloc, %ecx
+	subl	$reloc, %ecx
 	movl	%ecx, BP_code32_start(%eax)
 
 	sub	$0x4, %esp


Patches currently in stable-queue which might be from fupan.li@windriver.com are

queue-3.10/efi-fix-32bit-kernel-boot-failed-problem-using-efi.patch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web