Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1198804 > unrolled thread
| Started by | GIRISH K S <ks.giri@samsung.com> |
|---|---|
| First post | 2015-08-03 14:30 +0200 |
| Last post | 2015-08-04 16:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
Re: Re: [PATCH 05/15] HMM: introduce heterogeneous memory management v4. GIRISH K S <ks.giri@samsung.com> - 2015-08-03 14:30 +0200
Re: Re: [PATCH 05/15] HMM: introduce heterogeneous memory management v4. Jerome Glisse <j.glisse@gmail.com> - 2015-08-04 16:20 +0200
| From | GIRISH K S <ks.giri@samsung.com> |
|---|---|
| Date | 2015-08-03 14:30 +0200 |
| Subject | Re: Re: [PATCH 05/15] HMM: introduce heterogeneous memory management v4. |
| Message-ID | <pTn2r-2Xz-31@gated-at.bofh.it> |
DQoNCi0tLS0tLS0gT3JpZ2luYWwgTWVzc2FnZSAtLS0tLS0tDQpTZW5kZXIgOiBKZXJvbWUgR2xp c3NlPGouZ2xpc3NlQGdtYWlsLmNvbT4NCkRhdGUgOiBBdWcgMDMsIDIwMTUgMTc6MjYgKEdNVCsw NTozMCkNClRpdGxlIDogUmU6IFtQQVRDSCAwNS8xNV0gSE1NOiBpbnRyb2R1Y2UgaGV0ZXJvZ2Vu ZW91cyBtZW1vcnkgbWFuYWdlbWVudCB2NC4NCg0KT24gTW9uLCBBdWcgMDMsIDIwMTUgYXQgMDE6 MjA6MTNQTSArMDUzMCwgR2lyaXNoIEtTIHdyb3RlOg0KPiBPbiAxOC1KdWwtMjAxNSAxMjo0NyBh bSwgIkrDg8Kvw4LCv8OCwr3Dg8Kvw4LCv8OCwr1lIEdsaXNzZSIgd3JvdGU6DQo+ID4NCg0KWy4u Ll0NCg0KPiA+ICtpbnQgaG1tX21pcnJvcl9yZWdpc3RlcihzdHJ1Y3QgaG1tX21pcnJvciAqbWly cm9yKQ0KPiA+ICt7DQo+ID4gKyAgICAgICBzdHJ1Y3QgbW1fc3RydWN0ICptbSA9IGN1cnJlbnQt Pm1tOw0KPiA+ICsgICAgICAgc3RydWN0IGhtbSAqaG1tID0gTlVMTDsNCj4gPiArICAgICAgIGlu dCByZXQgPSAwOw0KPiA+ICsNCj4gPiArICAgICAgIC8qIFNhbml0eSBjaGVja3MuICovDQo+ID4g KyAgICAgICBCVUdfT04oIW1pcnJvcik7DQo+ID4gKyAgICAgICBCVUdfT04oIW1pcnJvci0+ZGV2 aWNlKTsNCj4gPiArICAgICAgIEJVR19PTighbW0pOw0KPiA+ICsNCj4gPiArICAgICAgIC8qDQo+ ID4gKyAgICAgICAgKiBJbml0aWFsaXplIHRoZSBtaXJyb3Igc3RydWN0IGZpZWxkcywgdGhlIG1s aXN0IGluaXQgYW5kIGRlbA0KPiBkYW5jZSBpcw0KPiA+ICsgICAgICAgICogbmVjZXNzYXJ5IHRv IG1ha2UgdGhlIGVycm9yIHBhdGggZWFzaWVyIGZvciBkcml2ZXIgYW5kIGZvciBobW0uDQo+ID4g KyAgICAgICAgKi8NCj4gPiArICAgICAgIGtyZWZfaW5pdCgmbWlycm9yLT5rcmVmKTsNCj4gPiAr ICAgICAgIElOSVRfSExJU1RfTk9ERSgmbWlycm9yLT5tbGlzdCk7DQo+ID4gKyAgICAgICBJTklU X0xJU1RfSEVBRCgmbWlycm9yLT5kbGlzdCk7DQo+ID4gKyAgICAgICBzcGluX2xvY2soJm1pcnJv ci0+ZGV2aWNlLT5sb2NrKTsNCj4gPiArICAgICAgIGxpc3RfYWRkKCZtaXJyb3ItPmRsaXN0LCAm bWlycm9yLT5kZXZpY2UtPm1pcnJvcnMpOw0KPiA+ICsgICAgICAgc3Bpbl91bmxvY2soJm1pcnJv ci0+ZGV2aWNlLT5sb2NrKTsNCj4gPiArDQo+ID4gKyAgICAgICBkb3duX3dyaXRlKCZtbS0+bW1h cF9zZW0pOw0KPiA+ICsNCj4gPiArICAgICAgIGhtbSA9IG1tLT5obW0gPyBobW1fcmVmKGhtbSkg OiBOVUxMOw0KPiANCj4gSW5zdGVhZCBvZiBobW0gbW0tPmhtbSB3b3VsZCBiZSB0aGUgcmlnaHQg cGFyYW0gdG8gYmUgcGFzc2VkLiAgSGVyZSBldmVuDQo+IHRob3VnaCBtbS0+aG1tIGlzIHRydWUg aG1tX3JlZiByZXR1cm5zIE5VTEwuIEJlY2F1c2UgaG1tIGlzIG5vdCB1cGRhdGVkDQo+IGFmdGVy IGluaXRpYWxpemF0aW9uIGluIHRoZSBiZWdpbm5pbmcuDQoNCkVOT1BBUlNFID8gV2hpbGUgdGhp cyBjYW4gYmUgc2ltcGxpZmllZCB0byBobW0gPSBobW1fcmVmKG1tLT5obW0pOyBJIGRvIG5vdA0K c2VlIHdoYXQgeW91IG1lYW4uIFRoZSBtbSBzdHJ1Y3QgbWlnaHQgYWxyZWFkeSBoYXZlIGEgdmFs aWQgaG1tIGZpZWxkIHNldCwNCmFuZCB0aGF0IHZhbGlkIGhtbSBzdHJ1Y3QgbWlnaHQgYWxzbyBh bHJlYWR5IGJlIGluIHRoZSBwcm9jZXNzIG9mIGJlaW5nDQpkZXN0cm95LiBTbyBobW1fcmVmKCkg bWlnaHQgZWl0aGVyIHJldHVybiB0aGUgc2FtZSBobW0gcG9pbnRlciBpZiB0aGUgaG1tDQpvYmpl Y3QgaXMgbm90IGFib3V0IHRvIGJlIHJlbGVhc2Ugb3IgTlVMTC4gQnV0IGF0IHRoaXMgcG9pbnQg dGhlcmUgaXMgbm8NCmNlcnRhaW50eSBvbiB0aGUgcmV0dXJuIHZhbHVlIG9mIGhtbV9yZWYoKS4N Cg0KSSBkaWRuJ3QgbWVhbiBobW0gPSBobW1fcmVmKG1tLT5obW0pOy4gSSBsbCB0cnkgdG8gcHV0 IGl0IGluIGEgYmV0dGVyIHdheS4gVGhlIGhtbSBsb2NhbCB2YXJpYWJsZSBpcyBpbml0aWFsaXpl ZCB0byBOVUxMIGluIHRoZSBzdGFydCBvZiB0aGUgZnVuY3Rpb24gKHN0cnVjdCBobW0gKmhtbSA9 IE5VTEw7KSwgYW5kIHRoaXMgaXMgbm90IG1vZGlmaWVkIHRpbGwgaXQgaXMgcGFzc2VkIHRvICBo bW1fcmVmLiAgU28gaG1tX3JlZiB3b3VsZCBhbHdheXMgcmV0dXJuIGEgTlVMTCBpcnJlc3BlY3Rp dmUgb2YgbW0tPmhtbSBpcyBOVUxMIG9yIHZhbGlkIGFkZHJlc3MuICANClNvICB0aGUgc3RhdGVt ZW50IGhtbSA9IG1tLT5obW0gPyBobW1fcmVmKGhtbSkgOiBOVUxMOyBzaG91bGQgYmUgcmVwbGFj ZWQgYXMgaG1tID0gbW0tPmhtbSA/IGhtbV9yZWYobW0tPmhtbSkgOiBOVUxMOy4gDQpBbHNvIEFz c3VtZSBtbS0+aG1tIGhhZCBhIGhtbSBvYmplY3QgYXNzaWduZWQgdG8gaXQgYmVmb3JlIGVudGVy aW5nIHRoaXMgZnVuY3Rpb24uIFNpbmNlIHRoZSBobW1fcmVmKGhtbSkgcmV0dXJucyBOVUxMIGFs d2F5cywgcHJldmlvdXNseSBhc3NpZ25lZCBtbS0+aG1tIGFkZHJlc3Mgd291bGQgYmUgb3Zlcndy aXR0ZW4gYnkgdGhlICBhbGxvY2F0aW9uIGFuZCBhc3NpZ25tZW50IHRoYXQgaGFwcGVuIGJlbG93 IGluIHRoaXMgZnVuY3Rpb24uDQoNCk5vdGUgdGhhdCBiZWNhdXNlIHdlIGhhdmUgdGhlIG1tYXAg c2VtIGluIHdyaXRlIG1vZGUgd2Uga25vdyBpdCBpcyBzYWZlDQp0byBkZXJlZmVyZW5jZSBtbS0+ aG1tIGFuZCBldmVuIHRvIG92ZXJ3cml0ZSB0aGF0IGZpZWxkIGl0IGlmIGl0IGlzIGJlaW5nDQpk ZXN0cm95IGNvbmN1cmVudGx5Lg0KDQpDaGVlcnMsDQpKw4PCr8OCwr/DgsK9w4PCr8OCwr/DgsK9 ZQ== -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Jerome Glisse <j.glisse@gmail.com> |
|---|---|
| Date | 2015-08-04 16:20 +0200 |
| Message-ID | <pTLep-4wJ-15@gated-at.bofh.it> |
| In reply to | #1198804 |
On Mon, Aug 03, 2015 at 12:21:14PM +0000, GIRISH K S wrote:
> On Mon, Aug 03, 2015 at 01:20:13PM +0530, Girish KS wrote:
> > On 18-Jul-2015 12:47 am, "J��e Glisse" wrote:
> > >
>
> [...]
>
> > > +int hmm_mirror_register(struct hmm_mirror *mirror)
> > > +{
> > > + struct mm_struct *mm = current->mm;
> > > + struct hmm *hmm = NULL;
> > > + int ret = 0;
> > > +
> > > + /* Sanity checks. */
> > > + BUG_ON(!mirror);
> > > + BUG_ON(!mirror->device);
> > > + BUG_ON(!mm);
> > > +
> > > + /*
> > > + * Initialize the mirror struct fields, the mlist init and del
> > dance is
> > > + * necessary to make the error path easier for driver and for hmm.
> > > + */
> > > + kref_init(&mirror->kref);
> > > + INIT_HLIST_NODE(&mirror->mlist);
> > > + INIT_LIST_HEAD(&mirror->dlist);
> > > + spin_lock(&mirror->device->lock);
> > > + list_add(&mirror->dlist, &mirror->device->mirrors);
> > > + spin_unlock(&mirror->device->lock);
> > > +
> > > + down_write(&mm->mmap_sem);
> > > +
> > > + hmm = mm->hmm ? hmm_ref(hmm) : NULL;
> >
> > Instead of hmm mm->hmm would be the right param to be passed. Here even
> > though mm->hmm is true hmm_ref returns NULL. Because hmm is not updated
> > after initialization in the beginning.
>
> ENOPARSE ? While this can be simplified to hmm = hmm_ref(mm->hmm); I do not
> see what you mean. The mm struct might already have a valid hmm field set,
> and that valid hmm struct might also already be in the process of being
> destroy. So hmm_ref() might either return the same hmm pointer if the hmm
> object is not about to be release or NULL. But at this point there is no
> certainty on the return value of hmm_ref().
>
> I didn't mean hmm = hmm_ref(mm->hmm);. I ll try to put it in a better way.
> The hmm local variable is initialized to NULL in the start of the function
> (struct hmm *hmm = NULL;), and this is not modified till it is passed to
> hmm_ref. So hmm_ref would always return a NULL irrespective of mm->hmm is
> NULL or valid address.
> So the statement hmm = mm->hmm ? hmm_ref(hmm) : NULL; should be replaced
> as hmm = mm->hmm ? hmm_ref(mm->hmm) : NULL;.
Oh yeah typo probably outcome of many patch reorg i did.
Cheers,
Jérôme
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web