Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1199808 > unrolled thread
| Started by | Shraddha Barke <shraddha.6596@gmail.com> |
|---|---|
| First post | 2015-08-04 15:10 +0200 |
| Last post | 2015-08-04 15:50 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2 2/3] Staging: lustre: Replace comma between expression statements by a semicolon. Shraddha Barke <shraddha.6596@gmail.com> - 2015-08-04 15:10 +0200
Re: [PATCH v2 2/3] Staging: lustre: Replace comma between expression statements by a semicolon. Julia Lawall <julia.lawall@lip6.fr> - 2015-08-04 15:40 +0200
Re: [PATCH v2 2/3] Staging: lustre: Replace comma between expression statements by a semicolon. Julia Lawall <julia.lawall@lip6.fr> - 2015-08-04 15:50 +0200
| From | Shraddha Barke <shraddha.6596@gmail.com> |
|---|---|
| Date | 2015-08-04 15:10 +0200 |
| Subject | [PATCH v2 2/3] Staging: lustre: Replace comma between expression statements by a semicolon. |
| Message-ID | <pTK8F-2Zr-9@gated-at.bofh.it> |
Replace comma between expression statements by a semicolon. The semantic patch used is as follows: @@ expression e1,e2; @@ e1 - , + ; e2; --- Changes in v2: -Make subject more clearer. drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c b/drivers/staging/lustre/lustre/mgc/mgc_request.c index 562bd95..019ee2f 100644 --- a/drivers/staging/lustre/lustre/mgc/mgc_request.c +++ b/drivers/staging/lustre/lustre/mgc/mgc_request.c @@ -1232,7 +1232,7 @@ static int mgc_apply_recover_logs(struct obd_device *mgc, pos += sprintf(obdname + pos, "-%s%04x", is_ost ? "OST" : "MDT", entry->mne_index); - cname = is_ost ? "osc" : "mdc", + cname = is_ost ? "osc" : "mdc"; pos += sprintf(obdname + pos, "-%s-%s", cname, inst); lustre_cfg_bufs_reset(&bufs, obdname); -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Julia Lawall <julia.lawall@lip6.fr> |
|---|---|
| Date | 2015-08-04 15:40 +0200 |
| Subject | Re: [PATCH v2 2/3] Staging: lustre: Replace comma between expression statements by a semicolon. |
| Message-ID | <pTKBH-3xf-5@gated-at.bofh.it> |
| In reply to | #1199808 |
Sorry not to have been more clear. The original subject text was OK. Tehway to differentiate between the patches would be to put Staging: lustre: mgc: in thi case, and Staging: lustre: libcfs: in the other one. julia On Tue, 4 Aug 2015, Shraddha Barke wrote: > Replace comma between expression statements by a semicolon. > The semantic patch used is as follows: > > @@ > expression e1,e2; > @@ > e1 > - , > + ; > e2; > --- > Changes in v2: > -Make subject more clearer. > > drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c b/drivers/staging/lustre/lustre/mgc/mgc_request.c > index 562bd95..019ee2f 100644 > --- a/drivers/staging/lustre/lustre/mgc/mgc_request.c > +++ b/drivers/staging/lustre/lustre/mgc/mgc_request.c > @@ -1232,7 +1232,7 @@ static int mgc_apply_recover_logs(struct obd_device *mgc, > pos += sprintf(obdname + pos, "-%s%04x", > is_ost ? "OST" : "MDT", entry->mne_index); > > - cname = is_ost ? "osc" : "mdc", > + cname = is_ost ? "osc" : "mdc"; > pos += sprintf(obdname + pos, "-%s-%s", cname, inst); > lustre_cfg_bufs_reset(&bufs, obdname); > > -- > 2.1.0 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Julia Lawall <julia.lawall@lip6.fr> |
|---|---|
| Date | 2015-08-04 15:50 +0200 |
| Subject | Re: [PATCH v2 2/3] Staging: lustre: Replace comma between expression statements by a semicolon. |
| Message-ID | <pTKLo-3IO-3@gated-at.bofh.it> |
| In reply to | #1199838 |
[Multipart message — attachments visible in raw view] — view raw
On Tue, 4 Aug 2015, Shraddha Barke wrote: > Alright . > So now I should send a version 3 right ? Yes. > Was there any other issue in the way I sent this version ? I think it's ok. julia
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web