Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1195852 > unrolled thread
| Started by | Matias Bjørling <m@bjorling.me> |
|---|---|
| First post | 2015-07-30 11:30 +0200 |
| Last post | 2015-08-18 18:20 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] NVMe: removed unused nn var from nvme_dev_add Matias Bjørling <m@bjorling.me> - 2015-07-30 11:30 +0200
Re: [PATCH] NVMe: removed unused nn var from nvme_dev_add Christoph Hellwig <hch@infradead.org> - 2015-08-04 13:30 +0200
Re: [PATCH] NVMe: removed unused nn var from nvme_dev_add Matias Bjørling <m@bjorling.me> - 2015-08-18 01:20 +0200
Re: [PATCH] NVMe: removed unused nn var from nvme_dev_add Jens Axboe <axboe@fb.com> - 2015-08-18 18:20 +0200
| From | Matias Bjørling <m@bjorling.me> |
|---|---|
| Date | 2015-07-30 11:30 +0200 |
| Subject | [PATCH] NVMe: removed unused nn var from nvme_dev_add |
| Message-ID | <pRSk2-2Bd-27@gated-at.bofh.it> |
The logic in nvme_dev_add to enumerate namespaces was moved to
nvme_dev_scan. When moved, the nn variable is no longer used. This patch
removes it.
Fixes: a5768aai ("NVMe: Automatic namespace rescan")
Signed-off-by: Matias Bjørling <m@bjorling.me>
---
drivers/block/nvme-core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c
index d844ec4..82a3241 100644
--- a/drivers/block/nvme-core.c
+++ b/drivers/block/nvme-core.c
@@ -2344,7 +2344,6 @@ static int nvme_dev_add(struct nvme_dev *dev)
{
struct pci_dev *pdev = to_pci_dev(dev->dev);
int res;
- unsigned nn;
struct nvme_id_ctrl *ctrl;
int shift = NVME_CAP_MPSMIN(readq(&dev->bar->cap)) + 12;
@@ -2354,7 +2353,6 @@ static int nvme_dev_add(struct nvme_dev *dev)
return -EIO;
}
- nn = le32_to_cpup(&ctrl->nn);
dev->oncs = le16_to_cpup(&ctrl->oncs);
dev->abort_limit = ctrl->acl + 1;
dev->vwc = ctrl->vwc;
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Christoph Hellwig <hch@infradead.org> |
|---|---|
| Date | 2015-08-04 13:30 +0200 |
| Message-ID | <pTIzT-DZ-9@gated-at.bofh.it> |
| In reply to | #1195852 |
Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Matias Bjørling <m@bjorling.me> |
|---|---|
| Date | 2015-08-18 01:20 +0200 |
| Message-ID | <pYBR8-4YO-3@gated-at.bofh.it> |
| In reply to | #1199686 |
Can this be picked up? Thanks On Tue, Aug 4, 2015 at 1:28 PM, Christoph Hellwig <hch@infradead.org> wrote: > Looks good, > > Reviewed-by: Christoph Hellwig <hch@lst.de> > > _______________________________________________ > Linux-nvme mailing list > Linux-nvme@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-nvme -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Jens Axboe <axboe@fb.com> |
|---|---|
| Date | 2015-08-18 18:20 +0200 |
| Message-ID | <pYRMf-2Xf-35@gated-at.bofh.it> |
| In reply to | #1208940 |
On 08/17/2015 05:19 PM, Matias Bjørling wrote: > Can this be picked up? Applied. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web