Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1199595 > unrolled thread

[PATCH 9/9] usb: misc: ftdi-elan: Simplify return statement

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 9/9] usb: misc: ftdi-elan: Simplify return statement "Karajgaonkar, Saurabh (S.)" <skarajga@visteon.com> - 2015-08-04 11:20 +0200
    Re: [PATCH 9/9] usb: misc: ftdi-elan: Simplify return statement Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-08-04 12:10 +0200

#1199595 — [PATCH 9/9] usb: misc: ftdi-elan: Simplify return statement

From: Saurabh Karajgaonkar <skarajga@visteon.com>

Replace redundant variable use in return statement.

Signed-off-by: Saurabh Karajgaonkar <skarajga@visteon.com>
---
 drivers/usb/misc/ftdi-elan.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/usb/misc/ftdi-elan.c b/drivers/usb/misc/ftdi-elan.c
index 8ab1f8f..1545f12 100644
--- a/drivers/usb/misc/ftdi-elan.c
+++ b/drivers/usb/misc/ftdi-elan.c
@@ -2568,11 +2568,8 @@ static int ftdi_elan_close_controller(struct usb_ftdi *ftdi, int fn)
 					    0x00);
 	if (UxxxStatus)
 		return UxxxStatus;
-	UxxxStatus = ftdi_elan_read_config(ftdi, activePCIfn | reg, 0,
+	return ftdi_elan_read_config(ftdi, activePCIfn | reg, 0,
 					   &pcidata);
-	if (UxxxStatus)
-		return UxxxStatus;
-	return 0;
 }
 
 static int ftdi_elan_found_controller(struct usb_ftdi *ftdi, int fn, int quirk)
@@ -2695,11 +2692,8 @@ static int ftdi_elan_setupOHCI(struct usb_ftdi *ftdi)
 		}
 	}
 	if (ftdi->function > 0) {
-		UxxxStatus = ftdi_elan_setup_controller(ftdi,
+		return ftdi_elan_setup_controller(ftdi,
 							ftdi->function - 1);
-		if (UxxxStatus)
-			return UxxxStatus;
-		return 0;
 	} else if (controllers > 0) {
 		return -ENXIO;
 	} else if (unrecognized > 0) {
-- 
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1199637

Hello.

On 8/4/2015 12:12 PM, Karajgaonkar, Saurabh (S.) wrote:

> From: Saurabh Karajgaonkar <skarajga@visteon.com>

> Replace redundant variable use in return statement.

> Signed-off-by: Saurabh Karajgaonkar <skarajga@visteon.com>
> ---
>   drivers/usb/misc/ftdi-elan.c | 10 ++--------
>   1 file changed, 2 insertions(+), 8 deletions(-)

> diff --git a/drivers/usb/misc/ftdi-elan.c b/drivers/usb/misc/ftdi-elan.c
> index 8ab1f8f..1545f12 100644
> --- a/drivers/usb/misc/ftdi-elan.c
> +++ b/drivers/usb/misc/ftdi-elan.c
> @@ -2568,11 +2568,8 @@ static int ftdi_elan_close_controller(struct usb_ftdi *ftdi, int fn)
>   					    0x00);
>   	if (UxxxStatus)
>   		return UxxxStatus;
> -	UxxxStatus = ftdi_elan_read_config(ftdi, activePCIfn | reg, 0,
> +	return ftdi_elan_read_config(ftdi, activePCIfn | reg, 0,
>   					   &pcidata);

    Please keep the continuation line aligned by starting it under 'ftdi'.

[...]
> @@ -2695,11 +2692,8 @@ static int ftdi_elan_setupOHCI(struct usb_ftdi *ftdi)
>   		}
>   	}
>   	if (ftdi->function > 0) {
> -		UxxxStatus = ftdi_elan_setup_controller(ftdi,
> +		return ftdi_elan_setup_controller(ftdi,
>   							ftdi->function - 1);

    Likewise.

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web