Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1199642 > unrolled thread

Re: [PATCH 19/20] clocksource: atmel-st: get and use slow clock

Started byDaniel Lezcano <daniel.lezcano@linaro.org>
First post2015-08-04 12:40 +0200
Last post2015-08-04 13:10 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 19/20] clocksource: atmel-st: get and use slow clock Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-08-04 12:40 +0200
    Re: [PATCH 19/20] clocksource: atmel-st: get and use slow clock Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-08-04 13:10 +0200

#1199642 — Re: [PATCH 19/20] clocksource: atmel-st: get and use slow clock

FromDaniel Lezcano <daniel.lezcano@linaro.org>
Date2015-08-04 12:40 +0200
SubjectRe: [PATCH 19/20] clocksource: atmel-st: get and use slow clock
Message-ID<pTHNv-7Vc-1@gated-at.bofh.it>
On 07/30/2015 02:22 AM, Alexandre Belloni wrote:
> The current slow clock rate is hardcoded. Properly get the slow clock
> and use its rate.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---

[ ... ]

> +struct clk *sclk;

Do you need this variable global ? AFAICS, its scope is in the init 
function, no ?

> +int timer_latch;

static.


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1199663

FromAlexandre Belloni <alexandre.belloni@free-electrons.com>
Date2015-08-04 13:10 +0200
Message-ID<pTIgy-h7-43@gated-at.bofh.it>
In reply to#1199642
On 04/08/2015 at 12:31:19 +0200, Daniel Lezcano wrote :
> On 07/30/2015 02:22 AM, Alexandre Belloni wrote:
> >The current slow clock rate is hardcoded. Properly get the slow clock
> >and use its rate.
> >
> >Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> >---
> 
> [ ... ]
> 
> >+struct clk *sclk;
> 
> Do you need this variable global ? AFAICS, its scope is in the init
> function, no ?
> 

Indeed.

> >+int timer_latch;
> 
> static.
> 

Yeah, this was changed in v2 (that I forgot to label as v2).

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web