Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1191150 > unrolled thread

[PATCH 0/2] bmc150 magnetometer cleanup

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/2] bmc150 magnetometer cleanup Irina Tirdea <irina.tirdea@intel.com> - 2015-07-23 19:20 +0200
    [PATCH 1/2] iio: magn: bmc150_magn: add locking comment for runtime resume Irina Tirdea <irina.tirdea@intel.com> - 2015-07-23 19:20 +0200
      Re: [PATCH 1/2] iio: magn: bmc150_magn: add locking comment for  runtime resume Jonathan Cameron <jic23@kernel.org> - 2015-08-02 19:20 +0200

#1191150 — [PATCH 0/2] bmc150 magnetometer cleanup

A couple of small cleanup patches starting from Hartmut's series.
There are no conflicts with the rest of Hartmut's patches, so they
can be applied in any order.

Irina Tirdea (2):
  iio: magn: bmc150_magn: add locking comment for runtime resume
  iio: magn: bmc150_magn: do not set power state twice when setting
    trigger state

 drivers/iio/magnetometer/bmc150_magn.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1191155 — [PATCH 1/2] iio: magn: bmc150_magn: add locking comment for runtime resume

Runtime resume function is called with the data->mutex lock held.
Add a comment to indicate this.

Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
---
 drivers/iio/magnetometer/bmc150_magn.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/iio/magnetometer/bmc150_magn.c b/drivers/iio/magnetometer/bmc150_magn.c
index 074a99d..d66f8cf 100644
--- a/drivers/iio/magnetometer/bmc150_magn.c
+++ b/drivers/iio/magnetometer/bmc150_magn.c
@@ -1043,6 +1043,9 @@ static int bmc150_magn_runtime_suspend(struct device *dev)
 	return 0;
 }
 
+/*
+ * Should be called with data->mutex held.
+ */
 static int bmc150_magn_runtime_resume(struct device *dev)
 {
 	struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev));
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1198406 — Re: [PATCH 1/2] iio: magn: bmc150_magn: add locking comment for runtime resume

On 23/07/15 18:15, Irina Tirdea wrote:
> Runtime resume function is called with the data->mutex lock held.
> Add a comment to indicate this.
> 
> Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
Sensible follow up to Hartmut's patches.  

Applied to the togreg branch of iio.git

Thanks,

Jonathan
> ---
>  drivers/iio/magnetometer/bmc150_magn.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/iio/magnetometer/bmc150_magn.c b/drivers/iio/magnetometer/bmc150_magn.c
> index 074a99d..d66f8cf 100644
> --- a/drivers/iio/magnetometer/bmc150_magn.c
> +++ b/drivers/iio/magnetometer/bmc150_magn.c
> @@ -1043,6 +1043,9 @@ static int bmc150_magn_runtime_suspend(struct device *dev)
>  	return 0;
>  }
>  
> +/*
> + * Should be called with data->mutex held.
> + */
>  static int bmc150_magn_runtime_resume(struct device *dev)
>  {
>  	struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev));
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web