Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1197173 > unrolled thread

Re: [PATCH v5 1/4] bpf: Make the bpf_prog_array_map more generic

Started byAlexei Starovoitov <ast@plumgrid.com>
First post2015-07-31 18:40 +0200
Last post2015-07-31 18:40 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v5 1/4] bpf: Make the bpf_prog_array_map more generic Alexei Starovoitov <ast@plumgrid.com> - 2015-07-31 18:40 +0200

#1197173 — Re: [PATCH v5 1/4] bpf: Make the bpf_prog_array_map more generic

FromAlexei Starovoitov <ast@plumgrid.com>
Date2015-07-31 18:40 +0200
SubjectRe: [PATCH v5 1/4] bpf: Make the bpf_prog_array_map more generic
Message-ID<pSlvJ-2Sa-11@gated-at.bofh.it>
On 7/31/15 4:59 AM, Kaixu Xia wrote:
> According to the comments from Daniel, rewrite part of
> the bpf_prog_array map code and make it more generic.
> So the new perf_event_array map type can reuse most of
> code with bpf_prog_array map and add fewer lines of
> special code.
>
> Tested the samples/bpf/tracex5 after this patch:
> 	$ sudo ./tracex5
> 	...
> 	dd-1051  [000] d...    26.682903: : mmap
> 	dd-1051  [000] d...    26.698348: : syscall=102 (one of get/set uid/pid/gid)
> 	dd-1051  [000] d...    26.703892: : read(fd=0, buf=000000000078c010, size=512)
> 	dd-1051  [000] d...    26.705847: : write(fd=1, buf=000000000078c010, size=512)
> 	dd-1051  [000] d...    26.707914: : read(fd=0, buf=000000000078c010, size=512)
> 	dd-1051  [000] d...    26.710988: : write(fd=1, buf=000000000078c010, size=512)
> 	dd-1051  [000] d...    26.711865: : read(fd=0, buf=000000000078c010, size=512)
> 	dd-1051  [000] d...    26.712704: : write(fd=1, buf=000000000078c010, size=512)
> 	...

the commit log doesn't really need these test results.
Also first paragraph is meaningless without prior history.
Please reword it, so it clearly says what this patch is doing and why.
Anyone reading it years later should be able to understand.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web