Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1195838 > unrolled thread

[PATCH] iio: declare struct to fix warning

Back to article view | Back to linux.kernel

Contents

  [PATCH] iio: declare struct to fix warning Pengyu Ma <pengyu.ma@windriver.com> - 2015-07-30 11:20 +0200
    Re: [PATCH] iio: declare struct to fix warning Pengyu Ma <pengyu.ma@windriver.com> - 2015-07-30 11:30 +0200
    Re: [PATCH] iio: declare struct to fix warning Lars-Peter Clausen <lars@metafoo.de> - 2015-08-02 11:50 +0200

#1195838 — [PATCH] iio: declare struct to fix warning

When compile iio related driver the following warning shown:

include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
declared inside parameter list
  int (*set_trigger_state)(struct iio_trigger *trig, bool state);

include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
declared inside parameter list
           struct iio_dev *indio_dev);

1st warning: 'struct iio_trigger' was used before declaration;
2nd warning: 'struct iio_dev' was used without including head file.

Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
---
 include/linux/iio/trigger.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
index 68f46cd..cbe4286 100644
--- a/include/linux/iio/trigger.h
+++ b/include/linux/iio/trigger.h
@@ -9,6 +9,7 @@
 #include <linux/irq.h>
 #include <linux/module.h>
 #include <linux/atomic.h>
+#include <linux/iio/iio.h>
 
 #ifndef _IIO_TRIGGER_H_
 #define _IIO_TRIGGER_H_
@@ -18,6 +19,8 @@ struct iio_subirq {
 	bool enabled;
 };
 
+struct iio_trigger; /* forward declaration */
+
 /**
  * struct iio_trigger_ops - operations structure for an iio_trigger.
  * @owner:		used to monitor usage count of the trigger.
-- 
2.0.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1195853

Since my email doesn't subscribe lkml, I will send again with my gmail

Pengyu

On 07/30/2015 05:18 PM, Pengyu Ma wrote:
> When compile iio related driver the following warning shown:
>
> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
> declared inside parameter list
>    int (*set_trigger_state)(struct iio_trigger *trig, bool state);
>
> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
> declared inside parameter list
>             struct iio_dev *indio_dev);
>
> 1st warning: 'struct iio_trigger' was used before declaration;
> 2nd warning: 'struct iio_dev' was used without including head file.
>
> Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
> ---
>   include/linux/iio/trigger.h | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
> index 68f46cd..cbe4286 100644
> --- a/include/linux/iio/trigger.h
> +++ b/include/linux/iio/trigger.h
> @@ -9,6 +9,7 @@
>   #include <linux/irq.h>
>   #include <linux/module.h>
>   #include <linux/atomic.h>
> +#include <linux/iio/iio.h>
>   
>   #ifndef _IIO_TRIGGER_H_
>   #define _IIO_TRIGGER_H_
> @@ -18,6 +19,8 @@ struct iio_subirq {
>   	bool enabled;
>   };
>   
> +struct iio_trigger; /* forward declaration */
> +
>   /**
>    * struct iio_trigger_ops - operations structure for an iio_trigger.
>    * @owner:		used to monitor usage count of the trigger.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1198318

On 07/30/2015 11:18 AM, Pengyu Ma wrote:
> When compile iio related driver the following warning shown:
> 
> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
> declared inside parameter list
>   int (*set_trigger_state)(struct iio_trigger *trig, bool state);
> 
> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
> declared inside parameter list
>            struct iio_dev *indio_dev);
> 
> 1st warning: 'struct iio_trigger' was used before declaration;
> 2nd warning: 'struct iio_dev' was used without including head file.
> 
> Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
> ---
>  include/linux/iio/trigger.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
> index 68f46cd..cbe4286 100644
> --- a/include/linux/iio/trigger.h
> +++ b/include/linux/iio/trigger.h
> @@ -9,6 +9,7 @@
>  #include <linux/irq.h>
>  #include <linux/module.h>
>  #include <linux/atomic.h>
> +#include <linux/iio/iio.h>
>  

Instead of including iio.h just add a forward declaration for struct
iio_dev. We dont need to dereference the struct so that will be fine.

>  #ifndef _IIO_TRIGGER_H_
>  #define _IIO_TRIGGER_H_
> @@ -18,6 +19,8 @@ struct iio_subirq {
>  	bool enabled;
>  };
>  
> +struct iio_trigger; /* forward declaration */
> +
>  /**
>   * struct iio_trigger_ops - operations structure for an iio_trigger.
>   * @owner:		used to monitor usage count of the trigger.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web