Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1196367 > unrolled thread

Re: [PATCH v5 01/10] clk: mediatek: Removed unused dpi_ck clock from MT8173

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v5 01/10] clk: mediatek: Removed unused dpi_ck clock from MT8173 Heiko Stübner <heiko@sntech.de> - 2015-07-30 20:40 +0200
    Re: [PATCH v5 01/10] clk: mediatek: Removed unused dpi_ck clock from  MT8173 Stephen Boyd <sboyd@codeaurora.org> - 2015-07-30 21:50 +0200
      Re: [PATCH v5 01/10] clk: mediatek: Removed unused dpi_ck clock from MT8173 Heiko Stübner <heiko@sntech.de> - 2015-07-30 22:10 +0200

#1196367 — Re: [PATCH v5 01/10] clk: mediatek: Removed unused dpi_ck clock from MT8173

Am Donnerstag, 30. Juli 2015, 10:36:43 schrieb Stephen Boyd:
> On 07/29, James Liao wrote:
> > Hi Stephen,
> > 
> > Could you help to apply this patch into 4.2?
> > 
> > 
> > Best regards,
> > 
> > James
> > 
> > On Wed, 2015-07-29 at 09:05 +0200, Heiko Stübner wrote:
> > > Am Mittwoch, 29. Juli 2015, 14:52:25 schrieb James Liao:
> > > > The dpi_ck clock can be removed because it not actually used
> > > > in topckgen and subsystems.
> > > > 
> > > > Signed-off-by: James Liao <jamesjj.liao@mediatek.com>
> > > 
> > > From our past discussions this change looks about right, and should
> > > still
> > > become _part of 4.2_, to not have the CLK_TOP_DPI become part of the
> > > devicetree CLK_TOP_DPI.
> 
> Did you mean ABI?

yep, sorry

> 
> > > Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> 
> Is it being used in DT right now and causing regressions on
> v4.2-rcX? Sorry, I'm trying to understand why this patch matters
> for the 4.2 release.

it's not been used in an actual devicetree file, but as far as I understand it, 
the dt-binding headers themself are also part of the ABI.

And it is new in 4.2, so has not been part of an official release yet.

The reason for the removal from what I understand is that the removed clock is 
not documented at all (it's source, what it does), which got it the "clk_null" 
parent in the first place.


Heiko

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1196400 — Re: [PATCH v5 01/10] clk: mediatek: Removed unused dpi_ck clock from MT8173

On 07/30/2015 11:04 AM, Heiko Stübner wrote:
> Am Donnerstag, 30. Juli 2015, 10:36:43 schrieb Stephen Boyd:
>
>> Is it being used in DT right now and causing regressions on
>> v4.2-rcX? Sorry, I'm trying to understand why this patch matters
>> for the 4.2 release.
> it's not been used in an actual devicetree file, but as far as I understand it,
> the dt-binding headers themself are also part of the ABI.
>
> And it is new in 4.2, so has not been part of an official release yet.
>
> The reason for the removal from what I understand is that the removed clock is
> not documented at all (it's source, what it does), which got it the "clk_null"
> parent in the first place.
>
>

Right, so my understanding of the DT ABI thing is that newer kernels 
should keep working with older DTs. If there isn't any DT using the 
binding, then we don't have a problem because the only thing that could 
happen would be a newer DT working with an older kernel, which doesn't 
make any sense from a backwards incompatible standpoint.

If you feel strongly that some sort of DT ABI rule would be broken and 
you want to make sure that doesn't happen I guess we can queue this up 
to be sent off to Linus, but if you aren't worried (and I'm obviously 
not worried) then I'd prefer we just queue it up for 4.3.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1196405

Am Donnerstag, 30. Juli 2015, 12:42:44 schrieb Stephen Boyd:
> On 07/30/2015 11:04 AM, Heiko Stübner wrote:
> > Am Donnerstag, 30. Juli 2015, 10:36:43 schrieb Stephen Boyd:
> >> Is it being used in DT right now and causing regressions on
> >> v4.2-rcX? Sorry, I'm trying to understand why this patch matters
> >> for the 4.2 release.
> > 
> > it's not been used in an actual devicetree file, but as far as I
> > understand it, the dt-binding headers themself are also part of the ABI.
> > 
> > And it is new in 4.2, so has not been part of an official release yet.
> > 
> > The reason for the removal from what I understand is that the removed
> > clock is not documented at all (it's source, what it does), which got it
> > the "clk_null" parent in the first place.
> 
> Right, so my understanding of the DT ABI thing is that newer kernels
> should keep working with older DTs. If there isn't any DT using the
> binding, then we don't have a problem because the only thing that could
> happen would be a newer DT working with an older kernel, which doesn't
> make any sense from a backwards incompatible standpoint.
> 
> If you feel strongly that some sort of DT ABI rule would be broken and
> you want to make sure that doesn't happen I guess we can queue this up
> to be sent off to Linus, but if you aren't worried (and I'm obviously
> not worried) then I'd prefer we just queue it up for 4.3.

I don't feel strongly, it was only based on what I remember about all the dt-
ABI talk :-) . Aka if you're ok with it simply going into 4.3 that should be 
ok too from my pov.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web