Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1194981 > unrolled thread

[PATCH v3 3/3] x86/pci/intel_mid_pci: fix a sparse warning

Started byAndy Shevchenko <andriy.shevchenko@linux.intel.com>
First post2015-07-29 11:20 +0200
Last post2015-07-29 21:40 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH v3 3/3] x86/pci/intel_mid_pci: fix a sparse warning Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-07-29 11:20 +0200
    [tip:x86/platform] x86/pci/intel_mid_pci:   Make intel_mid_pci_ops static tip-bot for Andy Shevchenko <tipbot@zytor.com> - 2015-07-29 21:40 +0200

#1194981 — [PATCH v3 3/3] x86/pci/intel_mid_pci: fix a sparse warning

FromAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Date2015-07-29 11:20 +0200
Subject[PATCH v3 3/3] x86/pci/intel_mid_pci: fix a sparse warning
Message-ID<pRvGO-3OC-9@gated-at.bofh.it>
This fixes the following sparse warning.
arch/x86/pci/intel_mid_pci.c:265:16: warning: symbol 'intel_mid_pci_ops' was not declared. Should it be static?

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 arch/x86/pci/intel_mid_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/pci/intel_mid_pci.c b/arch/x86/pci/intel_mid_pci.c
index 3361f0a..b096da5 100644
--- a/arch/x86/pci/intel_mid_pci.c
+++ b/arch/x86/pci/intel_mid_pci.c
@@ -263,7 +263,7 @@ static void intel_mid_pci_irq_disable(struct pci_dev *dev)
 	}
 }
 
-struct pci_ops intel_mid_pci_ops = {
+static struct pci_ops intel_mid_pci_ops = {
 	.read = pci_read,
 	.write = pci_write,
 };
-- 
2.4.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1195453 — [tip:x86/platform] x86/pci/intel_mid_pci: Make intel_mid_pci_ops static

Fromtip-bot for Andy Shevchenko <tipbot@zytor.com>
Date2015-07-29 21:40 +0200
Subject[tip:x86/platform] x86/pci/intel_mid_pci: Make intel_mid_pci_ops static
Message-ID<pRFmN-LX-9@gated-at.bofh.it>
In reply to#1194981
Commit-ID:  0abbdea1e9592fba120521ce22c6c26301e72761
Gitweb:     http://git.kernel.org/tip/0abbdea1e9592fba120521ce22c6c26301e72761
Author:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
AuthorDate: Wed, 29 Jul 2015 12:16:49 +0300
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 29 Jul 2015 21:23:50 +0200

x86/pci/intel_mid_pci: Make intel_mid_pci_ops static

This fixes the following sparse warning.
arch/x86/pci/intel_mid_pci.c:265:16: warning: symbol 'intel_mid_pci_ops' was not declared. Should it be static?

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Link: http://lkml.kernel.org/r/1438161409-4671-4-git-send-email-andriy.shevchenko@linux.intel.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/x86/pci/intel_mid_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/pci/intel_mid_pci.c b/arch/x86/pci/intel_mid_pci.c
index 3361f0a..b096da5 100644
--- a/arch/x86/pci/intel_mid_pci.c
+++ b/arch/x86/pci/intel_mid_pci.c
@@ -263,7 +263,7 @@ static void intel_mid_pci_irq_disable(struct pci_dev *dev)
 	}
 }
 
-struct pci_ops intel_mid_pci_ops = {
+static struct pci_ops intel_mid_pci_ops = {
 	.read = pci_read,
 	.write = pci_write,
 };
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web