Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1195710 > unrolled thread

Re: [Question]Why a skb with frag_list causes BUG_ON in function skb_segment

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [Question]Why a skb with frag_list causes BUG_ON in function  skb_segment Jason Wang <jasowang@redhat.com> - 2015-07-30 06:30 +0200
    Re: [Question]Why a skb with frag_list causes BUG_ON in function  skb_segment Eric Dumazet <eric.dumazet@gmail.com> - 2015-07-30 07:10 +0200
      RE: [Question]Why a skb with frag_list causes BUG_ON in function  skb_segment "Zhangjie (HZ)" <zhangjie14@huawei.com> - 2015-07-30 08:00 +0200

#1195710 — Re: [Question]Why a skb with frag_list causes BUG_ON in function skb_segment

cc netdev for more experts

On 07/28/2015 04:53 PM, Zhangjie (HZ) wrote:
>
> Hi,
>
> I generate a skb as follows:
>
> It has a linear data region, 17 frags and the last fragment is in
> skb_shinfo(skb)->frag_list.
>
> Before this skb is sent to driver, dev_hard_start_xmit() will segment
> it first(skb has frag_list,
>
> so we get true from netif_needs_gso()), then the skb is passed to
> function skb_segment().
>
> Then, BUG_ON() happened.
>
> while (pos < offset + len) {
>
>         if (i >= nfrags) {
>
>                 BUG_ON(skb_headlen(list_skb));    (skbuff.c:3120)
>
>                 …
>
>         }
>
>         …
>
> }
>
> A skb that has no frags but frag_list also causes BUG_ON().
>
> I wonder if skb like follows is legal? Could skb in frag_list have
> linear data region?
>
>  
>
>  
>
> Thanks
>
> Zhangjie
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1195713

On Thu, 2015-07-30 at 12:26 +0800, Jason Wang wrote:
> cc netdev for more experts
> 
> On 07/28/2015 04:53 PM, Zhangjie (HZ) wrote:
> >
> > Hi,
> >
> > I generate a skb as follows:
> >
> > It has a linear data region, 17 frags and the last fragment is in
> > skb_shinfo(skb)->frag_list.
> >
> > Before this skb is sent to driver, dev_hard_start_xmit() will segment
> > it first(skb has frag_list,
> >
> > so we get true from netif_needs_gso()), then the skb is passed to
> > function skb_segment().
> >
> > Then, BUG_ON() happened.
> >
> > while (pos < offset + len) {
> >
> >         if (i >= nfrags) {
> >
> >                 BUG_ON(skb_headlen(list_skb));    (skbuff.c:3120)
> >
> >                 …
> >
> >         }
> >
> >         …
> >
> > }
> >
> > A skb that has no frags but frag_list also causes BUG_ON().
> >
> > I wonder if skb like follows is legal? Could skb in frag_list have
> > linear data region?

The answer is : skb_segment() is very complex but does not handle all
possible cases.

skb found in skb_shinfo(skb)->frag_list must not have anything in their
skb->head. This would require very expensive logic and memory
allocations and copies.

Make sure you follow this rule in your driver, or even better leave this
work to GRO engine.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1195723

R2V0IGl0Lg0KRXJpYywgdGhhbmtzIGZvciB5b3VyIGV4cGxhaW5hdGlvbi4gOi0pDQoNCkphc29u
LCB0aGFuayB5b3UhIEkgd2lsbCByZW1lbWJlciBjYyBuZXRkZXZAdmdlci5rZXJuZWwub3JnIG5l
eHQgdGltZS4NCg0KLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IEVyaWMgRHVtYXpl
dCBbbWFpbHRvOmVyaWMuZHVtYXpldEBnbWFpbC5jb21dIA0KU2VudDogVGh1cnNkYXksIEp1bHkg
MzAsIDIwMTUgMTowMSBQTQ0KVG86IEphc29uIFdhbmcNCkNjOiBaaGFuZ2ppZSAoSFopOyBsaW51
eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnOyBtc3RAcmVkaGF0LmNvbTsgUWluY2h1YW55dTsgWWV3
dWRpOyBsaXV5b25nYW4gMDAxNzU4NjY7IG5ldGRldkB2Z2VyLmtlcm5lbC5vcmcNClN1YmplY3Q6
IFJlOiBbUXVlc3Rpb25dV2h5IGEgc2tiIHdpdGggZnJhZ19saXN0IGNhdXNlcyBCVUdfT04gaW4g
ZnVuY3Rpb24gc2tiX3NlZ21lbnQNCg0KT24gVGh1LCAyMDE1LTA3LTMwIGF0IDEyOjI2ICswODAw
LCBKYXNvbiBXYW5nIHdyb3RlOg0KPiBjYyBuZXRkZXYgZm9yIG1vcmUgZXhwZXJ0cw0KPiANCj4g
T24gMDcvMjgvMjAxNSAwNDo1MyBQTSwgWmhhbmdqaWUgKEhaKSB3cm90ZToNCj4gPg0KPiA+IEhp
LA0KPiA+DQo+ID4gSSBnZW5lcmF0ZSBhIHNrYiBhcyBmb2xsb3dzOg0KPiA+DQo+ID4gSXQgaGFz
IGEgbGluZWFyIGRhdGEgcmVnaW9uLCAxNyBmcmFncyBhbmQgdGhlIGxhc3QgZnJhZ21lbnQgaXMg
aW4gDQo+ID4gc2tiX3NoaW5mbyhza2IpLT5mcmFnX2xpc3QuDQo+ID4NCj4gPiBCZWZvcmUgdGhp
cyBza2IgaXMgc2VudCB0byBkcml2ZXIsIGRldl9oYXJkX3N0YXJ0X3htaXQoKSB3aWxsIA0KPiA+
IHNlZ21lbnQgaXQgZmlyc3Qoc2tiIGhhcyBmcmFnX2xpc3QsDQo+ID4NCj4gPiBzbyB3ZSBnZXQg
dHJ1ZSBmcm9tIG5ldGlmX25lZWRzX2dzbygpKSwgdGhlbiB0aGUgc2tiIGlzIHBhc3NlZCB0byAN
Cj4gPiBmdW5jdGlvbiBza2Jfc2VnbWVudCgpLg0KPiA+DQo+ID4gVGhlbiwgQlVHX09OKCkgaGFw
cGVuZWQuDQo+ID4NCj4gPiB3aGlsZSAocG9zIDwgb2Zmc2V0ICsgbGVuKSB7DQo+ID4NCj4gPiAg
ICAgICAgIGlmIChpID49IG5mcmFncykgew0KPiA+DQo+ID4gICAgICAgICAgICAgICAgIEJVR19P
Tihza2JfaGVhZGxlbihsaXN0X3NrYikpOyAgICAoc2tidWZmLmM6MzEyMCkNCj4gPg0KPiA+ICAg
ICAgICAgICAgICAgICDigKYNCj4gPg0KPiA+ICAgICAgICAgfQ0KPiA+DQo+ID4gICAgICAgICDi
gKYNCj4gPg0KPiA+IH0NCj4gPg0KPiA+IEEgc2tiIHRoYXQgaGFzIG5vIGZyYWdzIGJ1dCBmcmFn
X2xpc3QgYWxzbyBjYXVzZXMgQlVHX09OKCkuDQo+ID4NCj4gPiBJIHdvbmRlciBpZiBza2IgbGlr
ZSBmb2xsb3dzIGlzIGxlZ2FsPyBDb3VsZCBza2IgaW4gZnJhZ19saXN0IGhhdmUgDQo+ID4gbGlu
ZWFyIGRhdGEgcmVnaW9uPw0KDQpUaGUgYW5zd2VyIGlzIDogc2tiX3NlZ21lbnQoKSBpcyB2ZXJ5
IGNvbXBsZXggYnV0IGRvZXMgbm90IGhhbmRsZSBhbGwgcG9zc2libGUgY2FzZXMuDQoNCnNrYiBm
b3VuZCBpbiBza2Jfc2hpbmZvKHNrYiktPmZyYWdfbGlzdCBtdXN0IG5vdCBoYXZlIGFueXRoaW5n
IGluIHRoZWlyDQpza2ItPmhlYWQuIFRoaXMgd291bGQgcmVxdWlyZSB2ZXJ5IGV4cGVuc2l2ZSBs
b2dpYyBhbmQgbWVtb3J5DQphbGxvY2F0aW9ucyBhbmQgY29waWVzLg0KDQpNYWtlIHN1cmUgeW91
IGZvbGxvdyB0aGlzIHJ1bGUgaW4geW91ciBkcml2ZXIsIG9yIGV2ZW4gYmV0dGVyIGxlYXZlIHRo
aXMgd29yayB0byBHUk8gZW5naW5lLg0KDQoNCg0K
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web