Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1195437 > unrolled thread

Re: [PATCH v3] usb: chipidea: Use extcon framework for VBUS and ID detect

Started byTim Bird <tbird20d@gmail.com>
First post2015-07-29 21:20 +0200
Last post2015-07-30 09:00 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v3] usb: chipidea: Use extcon framework for VBUS and ID detect Tim Bird <tbird20d@gmail.com> - 2015-07-29 21:20 +0200
    Re: [PATCH v3] usb: chipidea: Use extcon framework for VBUS and ID  detect "Ivan T. Ivanov" <ivan.ivanov@linaro.org> - 2015-07-30 09:00 +0200

#1195437 — Re: [PATCH v3] usb: chipidea: Use extcon framework for VBUS and ID detect

FromTim Bird <tbird20d@gmail.com>
Date2015-07-29 21:20 +0200
SubjectRe: [PATCH v3] usb: chipidea: Use extcon framework for VBUS and ID detect
Message-ID<pRF3s-pr-7@gated-at.bofh.it>
On Tue, Jun 2, 2015 at 6:14 AM, Ivan T. Ivanov <ivan.ivanov@linaro.org> wrote:
> On recent Qualcomm platforms VBUS and ID lines are not routed to
> USB PHY LINK controller. Use extcon framework to receive connect
> and disconnect ID and VBUS notification.
>
> Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org>
> ---
> Changes sice v2 [1].
>
> * Simulate IRQ on extcon event - used to trigger OTG state machine.
>
> I have to admit that I couldn't test complete Chipidea OTG state machine,
> because my setup is little weird. I am using "qcom,usb-otg-ci" as PHY/OTG
> provider, "qcom,ehci-host" as host controller driver and "qcom,ci-hdrc" for
> device role.

Ivan,

Do you have patches for the code (presumably pmic code) where the vbus and id
lines are signaled?  Presumably you've added some extcon_set_cable_state() calls
somewhere in your source tree, for this to work.  I'm wondering if you
can share your
work in progress, or let me know when you plan to push that upstream?

I'm interested in testing the msm usb code (specifically host mode support)
on my dragonboard here.

Thanks,
 -- Tim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1195744 — Re: [PATCH v3] usb: chipidea: Use extcon framework for VBUS and ID detect

From"Ivan T. Ivanov" <ivan.ivanov@linaro.org>
Date2015-07-30 09:00 +0200
SubjectRe: [PATCH v3] usb: chipidea: Use extcon framework for VBUS and ID detect
Message-ID<pRPYT-7zo-27@gated-at.bofh.it>
In reply to#1195437
On Wed, 2015-07-29 at 12:10 -0700, Tim Bird wrote:
> On Tue, Jun 2, 2015 at 6:14 AM, Ivan T. Ivanov ivanov@linaro.org> wrote:
> > On recent Qualcomm platforms VBUS and ID lines are not routed to
> > USB PHY LINK controller. Use extcon framework to receive connect
> > and disconnect ID and VBUS notification.
> > 
> > Signed-off-by: Ivan T. Ivanov ivanov@linaro.org>
> > ---
> > Changes sice v2 [1].
> > 
> > * Simulate IRQ on extcon event - used to trigger OTG state machine.
> > 
> > I have to admit that I couldn't test complete Chipidea OTG state machine,
> > because my setup is little weird. I am using "qcom,usb-otg-ci" as PHY/OTG
> > provider, "qcom,ehci-host" as host controller driver and "qcom,ci-hdrc" for
> > device role.
> 
> Ivan,
> 
> Do you have patches for the code (presumably pmic code) where the vbus and id
> lines are signaled?  Presumably you've added some extcon_set_cable_state() calls
> somewhere in your source tree, for this to work.  I'm wondering if you
> can share your
> work in progress, or let me know when you plan to push that upstream?
> 

Well, not exactly. Maybe change description is badly worded. 
I have DB410c where VBUS and ID lines are not routed to USB controller, 
but to GPIO. So from the chipidea core driver point of view ID and VBUS
changes/IRQs are triggered from extcon driver "linux,extcon-usb-gpio"

> I'm interested in testing the msm usb code (specifically host mode support)
> on my dragonboard here.
> 

Since yesterday, Felipe kindly merged simple usb-phy driver for 8x16[1].
Which allow just using "qcom,ci-hdrc" and "qcom,usb-8x16-phy" to have
DRD support on 8x16 chipsets. I have tried to use "chipidea,usb2", but 
unfortunately quirks in "qcom,ci-hdrc" are required.

Once we have similar usb-phy drivers for 8x60, 8064, 8074 and 8084,
I believe the we can remove "qcom,usb-otg-xxx" monster. 

usb-phy driver for 8074 should be very similar to 8x16 one.

Regards,
Ivan

[1] http://bit.ly/1U6IjK4


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web