Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1193892 > unrolled thread

Re: [PATCH] Drivers: isdn: Drop unnecessary continue

Started byJulia Lawall <julia.lawall@lip6.fr>
First post2015-07-28 10:50 +0200
Last post2015-07-28 10:50 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] Drivers: isdn: Drop unnecessary continue Julia Lawall <julia.lawall@lip6.fr> - 2015-07-28 10:50 +0200

#1193892 — Re: [PATCH] Drivers: isdn: Drop unnecessary continue

FromJulia Lawall <julia.lawall@lip6.fr>
Date2015-07-28 10:50 +0200
SubjectRe: [PATCH] Drivers: isdn: Drop unnecessary continue
Message-ID<pR8Ke-43p-29@gated-at.bofh.it>
The patch should have v2 in the subject line, and should have a
description of the change since the previous version under the ---

On Tue, 28 Jul 2015, Shraddha Barke wrote:

> The semantic patch used to make this change is :
>
> @@
> @@
> for (...;...;...) {
>   ...
>   if (...) {
>     ...
> -   continue;
>   }
> }
>
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
>  drivers/isdn/hardware/mISDN/hfcsusb.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/isdn/hardware/mISDN/hfcsusb.c b/drivers/isdn/hardware/mISDN/hfcsusb.c
> index 114f3bc..91beb83 100644
> --- a/drivers/isdn/hardware/mISDN/hfcsusb.c
> +++ b/drivers/isdn/hardware/mISDN/hfcsusb.c
> @@ -1921,10 +1921,9 @@ hfcsusb_probe(struct usb_interface *intf, const struct usb_device_id *id)
>  		if ((le16_to_cpu(dev->descriptor.idVendor)
>  		     == hfcsusb_idtab[i].idVendor) &&
>  		    (le16_to_cpu(dev->descriptor.idProduct)
> -		     == hfcsusb_idtab[i].idProduct)) {
> +		     == hfcsusb_idtab[i].idProduct))
>  			vend_idx = i;
> -			continue;
> -		}
> +

There is no need to add a blank line here.

julia

>  	}
>
>  	printk(KERN_DEBUG
> --
> 2.1.0
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web