Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1192467 > unrolled thread

Re: [PATCH v2 1/3] x86/entry/64: Refactor IRQ stacks and make them NMI-safe

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 1/3] x86/entry/64: Refactor IRQ stacks and make them  NMI-safe Borislav Petkov <bp@alien8.de> - 2015-07-26 08:10 +0200
    Re: [PATCH v2 1/3] x86/entry/64: Refactor IRQ stacks and make them NMI-safe Andy Lutomirski <luto@amacapital.net> - 2015-07-26 21:00 +0200

#1192467 — Re: [PATCH v2 1/3] x86/entry/64: Refactor IRQ stacks and make them NMI-safe

On Fri, Jul 24, 2015 at 10:57:04PM -0700, Andy Lutomirski wrote:
> This will allow IRQ stacks to nest inside NMIs or similar entries
> that can happen during IRQ stack setup or teardown.
> 
> The Xen code here has a confusing comment.
> 
> The new macros won't work correctly if they're invoked with IRQs on.
> Add a check under CONFIG_DEBUG_ENTRY to detect that.
> 
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
>  arch/x86/Kconfig.debug       |  2 -
>  arch/x86/entry/entry_64.S    | 89 +++++++++++++++++++++++++++++---------------
>  arch/x86/kernel/process_64.c |  4 ++
>  3 files changed, 63 insertions(+), 32 deletions(-)

What does that apply against?

I get conflicts against current Linus master:

$ patch -p1 --dry-run -i /tmp/0001-x86-entry-64-refactor_irq_stacks_and_make_them_nmi-safe.patch 
checking file arch/x86/Kconfig.debug
checking file arch/x86/entry/entry_64.S
Hunk #1 succeeded at 544 (offset 54 lines).
Hunk #2 FAILED at 568.
Hunk #3 FAILED at 598.
Hunk #4 succeeded at 1012 (offset 99 lines).
Hunk #5 succeeded at 1033 (offset 99 lines).
2 out of 5 hunks FAILED
checking file arch/x86/kernel/process_64.c

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1192541 — Re: [PATCH v2 1/3] x86/entry/64: Refactor IRQ stacks and make them NMI-safe

On Sat, Jul 25, 2015 at 11:05 PM, Borislav Petkov <bp@alien8.de> wrote:
> On Fri, Jul 24, 2015 at 10:57:04PM -0700, Andy Lutomirski wrote:
>> This will allow IRQ stacks to nest inside NMIs or similar entries
>> that can happen during IRQ stack setup or teardown.
>>
>> The Xen code here has a confusing comment.
>>
>> The new macros won't work correctly if they're invoked with IRQs on.
>> Add a check under CONFIG_DEBUG_ENTRY to detect that.
>>
>> Signed-off-by: Andy Lutomirski <luto@kernel.org>
>> ---
>>  arch/x86/Kconfig.debug       |  2 -
>>  arch/x86/entry/entry_64.S    | 89 +++++++++++++++++++++++++++++---------------
>>  arch/x86/kernel/process_64.c |  4 ++
>>  3 files changed, 63 insertions(+), 32 deletions(-)
>
> What does that apply against?
>
> I get conflicts against current Linus master:

It applies to the result of merging Linus' master with tip/x86/asm.  I
think it also applies to tip/x86/asm directly, but I haven't tried it.
It's an NMI-related thing (sort of), so it seemed sensible to develop
against something that has the other NMI fixes.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web