Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1193081 > unrolled thread
| Started by | yangoliver <yang_oliver@hotmail.com> |
|---|---|
| First post | 2015-07-27 15:20 +0200 |
| Last post | 2015-08-04 09:10 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 1/2] sched: Some sched trace points should depend on SCHEDSTATS yangoliver <yang_oliver@hotmail.com> - 2015-07-27 15:20 +0200
Re: [PATCH 1/2] sched: Some sched trace points should depend on SCHEDSTATS Steven Rostedt <rostedt@goodmis.org> - 2015-08-03 19:40 +0200
Re: [PATCH 1/2] sched: Some sched trace points should depend on SCHEDSTATS Oliver Yang <yang_oliver@hotmail.com> - 2015-08-04 09:10 +0200
| From | yangoliver <yang_oliver@hotmail.com> |
|---|---|
| Date | 2015-07-27 15:20 +0200 |
| Subject | [PATCH 1/2] sched: Some sched trace points should depend on SCHEDSTATS |
| Message-ID | <pQQtY-2W3-29@gated-at.bofh.it> |
When SCHEDSTATS is not enabled, follow trace points shouldn't be accessed by default, sched:sched_stat_wait sched:sched_stat_sleep sched:sched_stat_iowait sched:sched_stat_blocked These trace points should only be available when SCHEDSTATS is enabled. Signed-off-by: Yong Yang <yangoliver@gmail.com> --- include/trace/events/sched.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h index d57a575..5b34309 100644 --- a/include/trace/events/sched.h +++ b/include/trace/events/sched.h @@ -334,6 +334,7 @@ DECLARE_EVENT_CLASS(sched_stat_template, ); +#ifdef CONFIG_SCHEDSTATS /* * Tracepoint for accounting wait time (time the task is runnable * but not actually running due to scheduler contention). @@ -364,6 +365,7 @@ DEFINE_EVENT(sched_stat_template, sched_stat_iowait, DEFINE_EVENT(sched_stat_template, sched_stat_blocked, TP_PROTO(struct task_struct *tsk, u64 delay), TP_ARGS(tsk, delay)); +#endif /* * Tracepoint for accounting runtime (time the task is executing -- 2.4.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| Date | 2015-08-03 19:40 +0200 |
| Subject | Re: [PATCH 1/2] sched: Some sched trace points should depend on SCHEDSTATS |
| Message-ID | <pTrSq-1uf-3@gated-at.bofh.it> |
| In reply to | #1193081 |
On Mon, 27 Jul 2015 09:11:51 -0400 yangoliver <yang_oliver@hotmail.com> wrote: > When SCHEDSTATS is not enabled, follow trace points shouldn't be > accessed by default, > > sched:sched_stat_wait > sched:sched_stat_sleep > sched:sched_stat_iowait > sched:sched_stat_blocked > > These trace points should only be available when SCHEDSTATS is > enabled. > > Signed-off-by: Yong Yang <yangoliver@gmail.com> > --- > include/trace/events/sched.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h > index d57a575..5b34309 100644 > --- a/include/trace/events/sched.h > +++ b/include/trace/events/sched.h > @@ -334,6 +334,7 @@ DECLARE_EVENT_CLASS(sched_stat_template, > ); > > > +#ifdef CONFIG_SCHEDSTATS Why not also surround the sched_stat_template too? That also creates code even if no event uses it. -- Steve > /* > * Tracepoint for accounting wait time (time the task is runnable > * but not actually running due to scheduler contention). > @@ -364,6 +365,7 @@ DEFINE_EVENT(sched_stat_template, sched_stat_iowait, > DEFINE_EVENT(sched_stat_template, sched_stat_blocked, > TP_PROTO(struct task_struct *tsk, u64 delay), > TP_ARGS(tsk, delay)); > +#endif > > /* > * Tracepoint for accounting runtime (time the task is executing -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Oliver Yang <yang_oliver@hotmail.com> |
|---|---|
| Date | 2015-08-04 09:10 +0200 |
| Subject | Re: [PATCH 1/2] sched: Some sched trace points should depend on SCHEDSTATS |
| Message-ID | <pTEwh-3hI-11@gated-at.bofh.it> |
| In reply to | #1199113 |
On 2015/8/4 1:34, Steven Rostedt wrote: > On Mon, 27 Jul 2015 09:11:51 -0400 > yangoliver <yang_oliver@hotmail.com> wrote: > >> When SCHEDSTATS is not enabled, follow trace points shouldn't be >> accessed by default, >> >> sched:sched_stat_wait >> sched:sched_stat_sleep >> sched:sched_stat_iowait >> sched:sched_stat_blocked >> >> These trace points should only be available when SCHEDSTATS is >> enabled. >> >> Signed-off-by: Yong Yang <yangoliver@gmail.com> >> --- >> include/trace/events/sched.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h >> index d57a575..5b34309 100644 >> --- a/include/trace/events/sched.h >> +++ b/include/trace/events/sched.h >> @@ -334,6 +334,7 @@ DECLARE_EVENT_CLASS(sched_stat_template, >> ); >> >> >> +#ifdef CONFIG_SCHEDSTATS > Why not also surround the sched_stat_template too? That also creates > code even if no event uses it. Steve, Because the sched_stat_template is used by sched_stat_runtime. The sched_stat_runtime is used event without SCHEDSTATS option enabled. And the se.sum_exec_runtime counter is also similar. I don't think this counter is defined for SCHEDSTATS. Yes. I just try to make our trace points design be similar with SCHEDSTATS counters design. > -- Steve > >> /* >> * Tracepoint for accounting wait time (time the task is runnable >> * but not actually running due to scheduler contention). >> @@ -364,6 +365,7 @@ DEFINE_EVENT(sched_stat_template, sched_stat_iowait, >> DEFINE_EVENT(sched_stat_template, sched_stat_blocked, >> TP_PROTO(struct task_struct *tsk, u64 delay), >> TP_ARGS(tsk, delay)); >> +#endif >> >> /* >> * Tracepoint for accounting runtime (time the task is executing -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web