Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1191227 > unrolled thread
| Started by | Andy Lutomirski <luto@kernel.org> |
|---|---|
| First post | 2015-07-23 21:00 +0200 |
| Last post | 2015-07-23 21:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] x86/entry/32: Initialize ss1 (SYSENTER_CS shadow) even on non-SEP CPUs Andy Lutomirski <luto@kernel.org> - 2015-07-23 21:00 +0200
Re: [PATCH] x86/entry/32: Initialize ss1 (SYSENTER_CS shadow) even on non-SEP CPUs Brian Gerst <brgerst@gmail.com> - 2015-07-23 21:10 +0200
| From | Andy Lutomirski <luto@kernel.org> |
|---|---|
| Date | 2015-07-23 21:00 +0200 |
| Subject | [PATCH] x86/entry/32: Initialize ss1 (SYSENTER_CS shadow) even on non-SEP CPUs |
| Message-ID | <pPtSO-6Pc-25@gated-at.bofh.it> |
native_load_sp0 relies on this. I'm not sure why we haven't seen reports of crashes. Maybe no one tests new kernels on non-SEP CPUs. Signed-off-by: Andy Lutomirski <luto@kernel.org> --- Of course, I haven't tested on a non-SEP CPU either. Where would I find one? arch/x86/kernel/cpu/common.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index d27ab6e5e671..2181692c1eb3 100644 --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -993,6 +993,17 @@ void enable_sep_cpu(void) cpu = get_cpu(); tss = &per_cpu(cpu_tss, cpu); +#ifdef CONFIG_X86_32 + /* + * We cache MSR_IA32_SYSENTER_CS's value in the TSS's ss1 + * field -- see the big comment in struct x86_hw_tss's + * definition. We need to initialize this even on non-SEP + * CPUs so that comparing ss1 to thread->sysenter_cs is + * always valid. + */ + tss->x86_tss.ss1 = __KERNEL_CS; +#endif + /* * On 64-bit CPUs, enable SEP unconditionally. On Intel CPUs, * it works and we use it. On AMD CPUs, the MSRs exist but EIP @@ -1005,14 +1016,6 @@ void enable_sep_cpu(void) if (IS_ENABLED(CONFIG_X86_32) && !boot_cpu_has(X86_FEATURE_SEP)) goto out; -#ifdef CONFIG_X86_32 - /* - * We cache MSR_IA32_SYSENTER_CS's value in the TSS's ss1 field -- - * see the big comment in struct x86_hw_tss's definition. - */ - tss->x86_tss.ss1 = __KERNEL_CS; -#endif - wrmsrl_safe(MSR_IA32_SYSENTER_CS, __KERNEL_CS); wrmsrl_safe(MSR_IA32_SYSENTER_ESP, (unsigned long)tss + -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Brian Gerst <brgerst@gmail.com> |
|---|---|
| Date | 2015-07-23 21:10 +0200 |
| Subject | Re: [PATCH] x86/entry/32: Initialize ss1 (SYSENTER_CS shadow) even on non-SEP CPUs |
| Message-ID | <pPu2u-7g6-23@gated-at.bofh.it> |
| In reply to | #1191227 |
On Thu, Jul 23, 2015 at 2:56 PM, Andy Lutomirski <luto@kernel.org> wrote: > native_load_sp0 relies on this. I'm not sure why we haven't seen > reports of crashes. Maybe no one tests new kernels on non-SEP CPUs. It's already statically initialized in cpu_tss. -- Brian Gerst -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web