Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1191206 > unrolled thread

Re: [PATCH] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants

Started byJakub Sitnicki <jsitnicki@gmail.com>
First post2015-07-23 20:20 +0200
Last post2015-07-25 23:30 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants Jakub Sitnicki <jsitnicki@gmail.com> - 2015-07-23 20:20 +0200
    Re: [PATCH] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_*  constants Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-07-23 20:40 +0200
      Re: [PATCH RESEND] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants Jakub Sitnicki <jsitnicki@gmail.com> - 2015-07-25 23:30 +0200

#1191206 — Re: [PATCH] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants

FromJakub Sitnicki <jsitnicki@gmail.com>
Date2015-07-23 20:20 +0200
SubjectRe: [PATCH] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants
Message-ID<pPtg6-65U-43@gated-at.bofh.it>
On Wed, Jun 24, 2015 at 07:23 AM CEST, Jakub Sitnicki <jsitnicki@gmail.com> wrote:
> linux/ieee80211.h already defines constants for information element IDs.
> Include it where needed, resolve discrepancies in naming, and remove the
> duplicated definitions.
>
> While at it, wrap a line that was too long and remove extra parentheses
> in an expression that mixes only equality and logical operators.
>
> Signed-off-by: Jakub Sitnicki <jsitnicki@gmail.com>
> ---

Looks like this patch got lost in the noise.  It still applies & builds.

Cheers,
Jakub
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1191214 — Re: [PATCH] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants

FromGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Date2015-07-23 20:40 +0200
SubjectRe: [PATCH] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants
Message-ID<pPtzr-6sr-15@gated-at.bofh.it>
In reply to#1191206
On Thu, Jul 23, 2015 at 08:11:03PM +0200, Jakub Sitnicki wrote:
> On Wed, Jun 24, 2015 at 07:23 AM CEST, Jakub Sitnicki <jsitnicki@gmail.com> wrote:
> > linux/ieee80211.h already defines constants for information element IDs.
> > Include it where needed, resolve discrepancies in naming, and remove the
> > duplicated definitions.
> >
> > While at it, wrap a line that was too long and remove extra parentheses
> > in an expression that mixes only equality and logical operators.
> >
> > Signed-off-by: Jakub Sitnicki <jsitnicki@gmail.com>
> > ---
> 
> Looks like this patch got lost in the noise.  It still applies & builds.

Again, please resend, I don't have it in my queue anywhere.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1192428 — Re: [PATCH RESEND] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants

FromJakub Sitnicki <jsitnicki@gmail.com>
Date2015-07-25 23:30 +0200
SubjectRe: [PATCH RESEND] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants
Message-ID<pQfb4-83S-13@gated-at.bofh.it>
In reply to#1191214
On Sat, Jul 25, 2015 at 04:30 PM CEST, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Sat, Jul 25, 2015 at 04:05:52PM +0200, Jakub Sitnicki wrote:
>> On Fri, Jul 24, 2015 at 10:39 PM CEST, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>> > On Fri, Jul 24, 2015 at 05:12:38PM +0200, Jakub Sitnicki wrote:
>> >> linux/ieee80211.h already defines constants for information element IDs.
>> >> Include it where needed, resolve discrepancies in naming, and remove the
>> >> duplicated definitions.
>> >> 
>> >> While at it, wrap a line that was too long and remove extra parentheses
>> >> in an expression that mixes only equality and logical operators.
>> >
>> > This patch doesn't apply at all.
>> 
>> My mistake, sorry.  I've generated it against v4.2-rc3.
>> 
>
> Do it against
>
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next

Will do. Thanks,

Jakub
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web