Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1190693 > unrolled thread
| Started by | Kukjin Kim <kgene@kernel.org> |
|---|---|
| First post | 2015-07-23 10:00 +0200 |
| Last post | 2015-07-23 10:20 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
RE: [GIT PULL] ARM: EXYNOS: mach: Improvements for 4.3 Kukjin Kim <kgene@kernel.org> - 2015-07-23 10:00 +0200
RE: [GIT PULL] ARM: EXYNOS: mach: Improvements for 4.3 Kukjin Kim <kgene@kernel.org> - 2015-07-23 10:20 +0200
Re: [GIT PULL] ARM: EXYNOS: mach: Improvements for 4.3 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-23 10:20 +0200
| From | Kukjin Kim <kgene@kernel.org> |
|---|---|
| Date | 2015-07-23 10:00 +0200 |
| Subject | RE: [GIT PULL] ARM: EXYNOS: mach: Improvements for 4.3 |
| Message-ID | <pPjA6-q3-7@gated-at.bofh.it> |
Krzysztof Kozlowski wrote: > > On 21.07.2015 14:21, Krzysztof Kozlowski wrote: > > 2015-07-21 14:13 GMT+09:00 Krzysztof Kozlowski <k.kozlowski@samsung.com>: > >> 2015-07-21 14:02 GMT+09:00 Kukjin Kim <kgene@kernel.org>: > >>> Krzysztof Kozlowski wrote: [...] > >>>> -- > >>> > >>> Applied above changes into fixes/non-critical, next/cleanup-samsung, > >>> next/dt-samsung and next/cpufreq-clk-samsung according to the change. > > > > Cc-ed Bartlomiej, > > > > One issue found: splitting DTS change for Exynos 5250 cpufreq to > > separate branch will break bisectability. The commit "ARM: dts: > > Exynos5250: add CPU OPP and regulator supply property": > > 1. MUST be put after "clk: samsung: exynos5250: add cpu clock > > configuration data and instantiate cpu clock" to prevent build > > failures, > > 2. should be put before "ARM: Exynos: switch to using generic cpufreq > > driver for Exynos5250" to prevent lost cpufreq functionality. > > > > Doing otherwise would lose bisectability which is really unfortunate > > when you can simply avoid it. This should remain in the same branch - > > next/cpufreq-clk-samsung. > > Dear Kukjin, > > Nothing changed since yesterday... so let me point this in a more clear > way. The way you divided the patchset causes build errors: > > -------------- > HEAD is now at 565872a601c4... ARM: dts: add CPU OPP and regulator > supply property for exynos5250 > > ERROR: Failed build: -A arm -c exynos on > 565872a601c4d91a75b917b1fb40ff27ad7ebb08 > > LOGS: > Error: ../arch/arm/boot/dts/exynos5250.dtsi:65.21-22 syntax error > FATAL ERROR: Unable to parse input tree > make[2]: *** [arch/arm/boot/dts/exynos5250-arndale.dtb] Error 1 > make[1]: *** [dtbs] Error 2 > make[1]: *** Waiting for unfinished jobs.... > make: *** [sub-make] Error 2 > -------------- > > This breaks bisectability without any special valid reason. > Hi, I couldn't check e-mail yesterday because of annual health check. Anyway, I'll look at the error and handle it soon. Thanks for your check. Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Kukjin Kim <kgene@kernel.org> |
|---|---|
| Date | 2015-07-23 10:20 +0200 |
| Message-ID | <pPjTr-11y-17@gated-at.bofh.it> |
| In reply to | #1190693 |
Kukjin Kim wrote: > > Krzysztof Kozlowski wrote: > > > > On 21.07.2015 14:21, Krzysztof Kozlowski wrote: > > > 2015-07-21 14:13 GMT+09:00 Krzysztof Kozlowski <k.kozlowski@samsung.com>: > > >> 2015-07-21 14:02 GMT+09:00 Kukjin Kim <kgene@kernel.org>: > > >>> Krzysztof Kozlowski wrote: > > [...] > > > >>>> -- > > >>> > > >>> Applied above changes into fixes/non-critical, next/cleanup-samsung, > > >>> next/dt-samsung and next/cpufreq-clk-samsung according to the change. > > > > > > Cc-ed Bartlomiej, > > > > > > One issue found: splitting DTS change for Exynos 5250 cpufreq to > > > separate branch will break bisectability. The commit "ARM: dts: > > > Exynos5250: add CPU OPP and regulator supply property": > > > 1. MUST be put after "clk: samsung: exynos5250: add cpu clock > > > configuration data and instantiate cpu clock" to prevent build > > > failures, > > > 2. should be put before "ARM: Exynos: switch to using generic cpufreq > > > driver for Exynos5250" to prevent lost cpufreq functionality. > > > > > > Doing otherwise would lose bisectability which is really unfortunate > > > when you can simply avoid it. This should remain in the same branch - > > > next/cpufreq-clk-samsung. > > > > Dear Kukjin, > > > > Nothing changed since yesterday... so let me point this in a more clear > > way. The way you divided the patchset causes build errors: > > > > -------------- > > HEAD is now at 565872a601c4... ARM: dts: add CPU OPP and regulator > > supply property for exynos5250 > > > > ERROR: Failed build: -A arm -c exynos on > > 565872a601c4d91a75b917b1fb40ff27ad7ebb08 > > > > LOGS: > > Error: ../arch/arm/boot/dts/exynos5250.dtsi:65.21-22 syntax error > > FATAL ERROR: Unable to parse input tree > > make[2]: *** [arch/arm/boot/dts/exynos5250-arndale.dtb] Error 1 > > make[1]: *** [dtbs] Error 2 > > make[1]: *** Waiting for unfinished jobs.... > > make: *** [sub-make] Error 2 > > -------------- > > > > This breaks bisectability without any special valid reason. > > > Hi, > > I couldn't check e-mail yesterday because of annual health check. > Anyway, I'll look at the error and handle it soon. > OK, the change for the include/dt-bindings/clock/exynos5250.h file which is in next/cpufreq-clk-samsung branch should be provided in next/dt-samsung branch. It should be fine tonight in my time. One more thing, the splitting changes into dt and driver side would be required generally and if it has dependency like this, proper merge topic branch is required by maintainer. But I've missed last action :( Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2015-07-23 10:20 +0200 |
| Message-ID | <pPjTs-11y-21@gated-at.bofh.it> |
| In reply to | #1190707 |
On 23.07.2015 17:11, Kukjin Kim wrote: > Kukjin Kim wrote: >> >> Krzysztof Kozlowski wrote: >>> >>> On 21.07.2015 14:21, Krzysztof Kozlowski wrote: >>>> 2015-07-21 14:13 GMT+09:00 Krzysztof Kozlowski <k.kozlowski@samsung.com>: >>>>> 2015-07-21 14:02 GMT+09:00 Kukjin Kim <kgene@kernel.org>: >>>>>> Krzysztof Kozlowski wrote: >> >> [...] >> >>>>>>> -- >>>>>> >>>>>> Applied above changes into fixes/non-critical, next/cleanup-samsung, >>>>>> next/dt-samsung and next/cpufreq-clk-samsung according to the change. >>>> >>>> Cc-ed Bartlomiej, >>>> >>>> One issue found: splitting DTS change for Exynos 5250 cpufreq to >>>> separate branch will break bisectability. The commit "ARM: dts: >>>> Exynos5250: add CPU OPP and regulator supply property": >>>> 1. MUST be put after "clk: samsung: exynos5250: add cpu clock >>>> configuration data and instantiate cpu clock" to prevent build >>>> failures, >>>> 2. should be put before "ARM: Exynos: switch to using generic cpufreq >>>> driver for Exynos5250" to prevent lost cpufreq functionality. >>>> >>>> Doing otherwise would lose bisectability which is really unfortunate >>>> when you can simply avoid it. This should remain in the same branch - >>>> next/cpufreq-clk-samsung. >>> >>> Dear Kukjin, >>> >>> Nothing changed since yesterday... so let me point this in a more clear >>> way. The way you divided the patchset causes build errors: >>> >>> -------------- >>> HEAD is now at 565872a601c4... ARM: dts: add CPU OPP and regulator >>> supply property for exynos5250 >>> >>> ERROR: Failed build: -A arm -c exynos on >>> 565872a601c4d91a75b917b1fb40ff27ad7ebb08 >>> >>> LOGS: >>> Error: ../arch/arm/boot/dts/exynos5250.dtsi:65.21-22 syntax error >>> FATAL ERROR: Unable to parse input tree >>> make[2]: *** [arch/arm/boot/dts/exynos5250-arndale.dtb] Error 1 >>> make[1]: *** [dtbs] Error 2 >>> make[1]: *** Waiting for unfinished jobs.... >>> make: *** [sub-make] Error 2 >>> -------------- >>> >>> This breaks bisectability without any special valid reason. >>> >> Hi, >> >> I couldn't check e-mail yesterday because of annual health check. >> Anyway, I'll look at the error and handle it soon. >> > OK, the change for the include/dt-bindings/clock/exynos5250.h file which is in > next/cpufreq-clk-samsung branch should be provided in next/dt-samsung branch. > It should be fine tonight in my time. > > One more thing, the splitting changes into dt and driver side would be required > generally and if it has dependency like this, proper merge topic branch is > required by maintainer. But I've missed last action :( You prepared a topic branch - next/cpufreq-clk-samsung. I think everything can be put in it and this would solve any issues. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web