Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1190369 > unrolled thread

Re: [Patch V4 1/3] usb: Add Xen pvUSB protocol description

Started byGreg KH <gregkh@linuxfoundation.org>
First post2015-07-23 01:50 +0200
Last post2015-07-23 23:40 +0200
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [Patch V4 1/3] usb: Add Xen pvUSB protocol description Greg KH <gregkh@linuxfoundation.org> - 2015-07-23 01:50 +0200
    Re: [Patch V4 1/3] usb: Add Xen pvUSB protocol description Greg KH <gregkh@linuxfoundation.org> - 2015-07-23 06:40 +0200
      Re: [Patch V4 1/3] usb: Add Xen pvUSB protocol description Juergen Gross <jgross@suse.com> - 2015-07-23 08:50 +0200
        Re: [Patch V4 1/3] usb: Add Xen pvUSB protocol description Greg KH <gregkh@linuxfoundation.org> - 2015-07-23 21:10 +0200
          Re: [Xen-devel] [Patch V4 1/3] usb: Add Xen pvUSB protocol  description Pasi Kärkkäinen <pasik@iki.fi> - 2015-07-23 23:40 +0200

#1190369 — Re: [Patch V4 1/3] usb: Add Xen pvUSB protocol description

FromGreg KH <gregkh@linuxfoundation.org>
Date2015-07-23 01:50 +0200
SubjectRe: [Patch V4 1/3] usb: Add Xen pvUSB protocol description
Message-ID<pPbVV-6bx-17@gated-at.bofh.it>
On Tue, Jun 23, 2015 at 08:53:23AM +0200, Juergen Gross wrote:
> Add the definition of pvUSB protocol used between the pvUSB frontend in
> a Xen domU and the pvUSB backend in a Xen driver domain (usually Dom0).
> 
> This header was originally provided by Fujitsu for Xen based on Linux
> 2.6.18.
> 
> Changes are:
> - adapt to Linux style guide
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
>  include/xen/interface/io/usbif.h | 252 +++++++++++++++++++++++++++++++++++++++

Why is this a different interface than the existing ones we have today
(i.e. usbip?)  Where is it documented?  Do the Xen developers /
maintainers agree with this interface and code?  I need their sign-off
before I can accept such a thing.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1190580

FromGreg KH <gregkh@linuxfoundation.org>
Date2015-07-23 06:40 +0200
Message-ID<pPgsy-4tQ-5@gated-at.bofh.it>
In reply to#1190369
On Thu, Jul 23, 2015 at 06:04:39AM +0200, Juergen Gross wrote:
> On 07/23/2015 01:46 AM, Greg KH wrote:
> >On Tue, Jun 23, 2015 at 08:53:23AM +0200, Juergen Gross wrote:
> >>Add the definition of pvUSB protocol used between the pvUSB frontend in
> >>a Xen domU and the pvUSB backend in a Xen driver domain (usually Dom0).
> >>
> >>This header was originally provided by Fujitsu for Xen based on Linux
> >>2.6.18.
> >>
> >>Changes are:
> >>- adapt to Linux style guide
> >>
> >>Signed-off-by: Juergen Gross <jgross@suse.com>
> >>---
> >>  include/xen/interface/io/usbif.h | 252 +++++++++++++++++++++++++++++++++++++++
> >
> >Why is this a different interface than the existing ones we have today
> >(i.e. usbip?)  Where is it documented?  Do the Xen developers /
> 
> The interface definition is living in the Xen git repository for several
> years now:
> 
> git://xenbits.xen.org/xen.git -> xen/include/public/io/usbif.h

That's header file, not a document describing the api here.

> It is used e.g. in SUSE's xen kernel since 2.6.18.

I am very aware of the amount of Xen crap in SuSE's kernel, don't use
that as an excuse for me to merge it to mainline :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1190663

FromJuergen Gross <jgross@suse.com>
Date2015-07-23 08:50 +0200
Message-ID<pPium-7ld-19@gated-at.bofh.it>
In reply to#1190580
On 07/23/2015 06:36 AM, Greg KH wrote:
> On Thu, Jul 23, 2015 at 06:04:39AM +0200, Juergen Gross wrote:
>> On 07/23/2015 01:46 AM, Greg KH wrote:
>>> On Tue, Jun 23, 2015 at 08:53:23AM +0200, Juergen Gross wrote:
>>>> Add the definition of pvUSB protocol used between the pvUSB frontend in
>>>> a Xen domU and the pvUSB backend in a Xen driver domain (usually Dom0).
>>>>
>>>> This header was originally provided by Fujitsu for Xen based on Linux
>>>> 2.6.18.
>>>>
>>>> Changes are:
>>>> - adapt to Linux style guide
>>>>
>>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>>> ---
>>>>   include/xen/interface/io/usbif.h | 252 +++++++++++++++++++++++++++++++++++++++
>>>
>>> Why is this a different interface than the existing ones we have today
>>> (i.e. usbip?)  Where is it documented?  Do the Xen developers /
>>
>> The interface definition is living in the Xen git repository for several
>> years now:
>>
>> git://xenbits.xen.org/xen.git -> xen/include/public/io/usbif.h
>
> That's header file, not a document describing the api here.

I suppose you want to tell me I should add something like:

Documentation/DocBook/usb/API-struct-urb.html

I can do this, of course.

>> It is used e.g. in SUSE's xen kernel since 2.6.18.
>
> I am very aware of the amount of Xen crap in SuSE's kernel, don't use
> that as an excuse for me to merge it to mainline :)

:-)

Wasn't meant as an excuse, just a hint why the interface can't be the
same as for usbip. We have to ensure compatibility with those kernels
and possibly other operating systems (BSD?, Windows?) which already
might be using pvUSB with a Dom0 based on the SUSE xen kernel.


Juergen

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1191240

FromGreg KH <gregkh@linuxfoundation.org>
Date2015-07-23 21:10 +0200
Message-ID<pPu2u-7g6-31@gated-at.bofh.it>
In reply to#1190663
On Thu, Jul 23, 2015 at 08:46:17AM +0200, Juergen Gross wrote:
> On 07/23/2015 06:36 AM, Greg KH wrote:
> >On Thu, Jul 23, 2015 at 06:04:39AM +0200, Juergen Gross wrote:
> >>On 07/23/2015 01:46 AM, Greg KH wrote:
> >>>On Tue, Jun 23, 2015 at 08:53:23AM +0200, Juergen Gross wrote:
> >>>>Add the definition of pvUSB protocol used between the pvUSB frontend in
> >>>>a Xen domU and the pvUSB backend in a Xen driver domain (usually Dom0).
> >>>>
> >>>>This header was originally provided by Fujitsu for Xen based on Linux
> >>>>2.6.18.
> >>>>
> >>>>Changes are:
> >>>>- adapt to Linux style guide
> >>>>
> >>>>Signed-off-by: Juergen Gross <jgross@suse.com>
> >>>>---
> >>>>  include/xen/interface/io/usbif.h | 252 +++++++++++++++++++++++++++++++++++++++
> >>>
> >>>Why is this a different interface than the existing ones we have today
> >>>(i.e. usbip?)  Where is it documented?  Do the Xen developers /
> >>
> >>The interface definition is living in the Xen git repository for several
> >>years now:
> >>
> >>git://xenbits.xen.org/xen.git -> xen/include/public/io/usbif.h
> >
> >That's header file, not a document describing the api here.
> 
> I suppose you want to tell me I should add something like:
> 
> Documentation/DocBook/usb/API-struct-urb.html

Somewhere that people can refer to that describes this public-facing API
that "must not ever be broken or changed".  If you want to put it in a
documentation file, or a .h file, I don't care.

> >>It is used e.g. in SUSE's xen kernel since 2.6.18.
> >
> >I am very aware of the amount of Xen crap in SuSE's kernel, don't use
> >that as an excuse for me to merge it to mainline :)
> 
> :-)
> 
> Wasn't meant as an excuse, just a hint why the interface can't be the
> same as for usbip. We have to ensure compatibility with those kernels

This shouldn't be a kernel/kernel compability issue, as the api talks
between Xen and the OS, not between different OSs, right?

> and possibly other operating systems (BSD?, Windows?) which already
> might be using pvUSB with a Dom0 based on the SUSE xen kernel.

Are there other operating system drivers today that use this API?  Is
this an API in the Xen core today that we have to support?

Some more background / descriptions would be nice to have.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1191330 — Re: [Xen-devel] [Patch V4 1/3] usb: Add Xen pvUSB protocol description

FromPasi Kärkkäinen <pasik@iki.fi>
Date2015-07-23 23:40 +0200
SubjectRe: [Xen-devel] [Patch V4 1/3] usb: Add Xen pvUSB protocol description
Message-ID<pPwnE-2cG-15@gated-at.bofh.it>
In reply to#1191240
On Thu, Jul 23, 2015 at 12:08:01PM -0700, Greg KH wrote:
> 
> Somewhere that people can refer to that describes this public-facing API
> that "must not ever be broken or changed".  If you want to put it in a
> documentation file, or a .h file, I don't care.
> 
> > >>It is used e.g. in SUSE's xen kernel since 2.6.18.
> > >
> > >I am very aware of the amount of Xen crap in SuSE's kernel, don't use
> > >that as an excuse for me to merge it to mainline :)
> > 
> > :-)
> > 
> > Wasn't meant as an excuse, just a hint why the interface can't be the
> > same as for usbip. We have to ensure compatibility with those kernels
> 
> This shouldn't be a kernel/kernel compability issue, as the api talks
> between Xen and the OS, not between different OSs, right?
> 
> > and possibly other operating systems (BSD?, Windows?) which already
> > might be using pvUSB with a Dom0 based on the SUSE xen kernel.
> 
> Are there other operating system drivers today that use this API?  Is
> this an API in the Xen core today that we have to support?
> 
> Some more background / descriptions would be nice to have.
>

For example Xen "GPLPV" drivers for Windows do have PVUSB frontend driver..


-- Pasi

 
> thanks,
> 
> greg k-h
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web