Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1190649 > unrolled thread

Re: [PATCH 1/3] KVM: MTRR: fix memory type handling if MTRR is completely disabled

Started byPaolo Bonzini <pbonzini@redhat.com>
First post2015-07-23 08:30 +0200
Last post2015-07-23 09:20 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 1/3] KVM: MTRR: fix memory type handling if MTRR is  completely disabled Paolo Bonzini <pbonzini@redhat.com> - 2015-07-23 08:30 +0200
    Re: [PATCH 1/3] KVM: MTRR: fix memory type handling if MTRR is completely  disabled Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2015-07-23 08:40 +0200
      Re: [PATCH 1/3] KVM: MTRR: fix memory type handling if MTRR is  completely disabled Paolo Bonzini <pbonzini@redhat.com> - 2015-07-23 09:20 +0200

#1190649 — Re: [PATCH 1/3] KVM: MTRR: fix memory type handling if MTRR is completely disabled

FromPaolo Bonzini <pbonzini@redhat.com>
Date2015-07-23 08:30 +0200
SubjectRe: [PATCH 1/3] KVM: MTRR: fix memory type handling if MTRR is completely disabled
Message-ID<pPiaZ-6YI-9@gated-at.bofh.it>

On 16/07/2015 06:10, Alex Williamson wrote:
> On Thu, 2015-07-16 at 03:25 +0800, Xiao Guangrong wrote:
>> > From: Xiao Guangrong <guangrong.xiao@intel.com>
>> > 
>> > Currently code uses default memory type if MTRR is fully disabled,
>> > fix it by using UC instead
>> > 
>> > Signed-off-by: Xiao Guangrong <guangrong.xiao@intel.com>
>> > ---
> Seems to work for me.  I don't see a 0th patch, but for the series:
> 
> Tested-by: Alex Williamson <alex.williamson@redhat.com>

In fact this is the same quirk already implemented for SVM as
KVM_QUIRK_CD_NW_CLEARED, so we can reuse the bit.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1190652 — Re: [PATCH 1/3] KVM: MTRR: fix memory type handling if MTRR is completely disabled

FromXiao Guangrong <guangrong.xiao@linux.intel.com>
Date2015-07-23 08:40 +0200
SubjectRe: [PATCH 1/3] KVM: MTRR: fix memory type handling if MTRR is completely disabled
Message-ID<pPikF-79S-3@gated-at.bofh.it>
In reply to#1190649

On 07/23/2015 02:21 PM, Paolo Bonzini wrote:
>
>
> On 16/07/2015 06:10, Alex Williamson wrote:
>> On Thu, 2015-07-16 at 03:25 +0800, Xiao Guangrong wrote:
>>>> From: Xiao Guangrong <guangrong.xiao@intel.com>
>>>>
>>>> Currently code uses default memory type if MTRR is fully disabled,
>>>> fix it by using UC instead
>>>>
>>>> Signed-off-by: Xiao Guangrong <guangrong.xiao@intel.com>
>>>> ---
>> Seems to work for me.  I don't see a 0th patch, but for the series:
>>
>> Tested-by: Alex Williamson <alex.williamson@redhat.com>
>
> In fact this is the same quirk already implemented for SVM as
> KVM_QUIRK_CD_NW_CLEARED, so we can reuse the bit.

Sounds good to me. I will drop the new bit and reuse as your suggestion.
And i think we need document this whole staff in API.txt ...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1190678

FromPaolo Bonzini <pbonzini@redhat.com>
Date2015-07-23 09:20 +0200
Message-ID<pPiXo-88k-9@gated-at.bofh.it>
In reply to#1190652

On 23/07/2015 08:29, Xiao Guangrong wrote:
>> In fact this is the same quirk already implemented for SVM as
>> KVM_QUIRK_CD_NW_CLEARED, so we can reuse the bit.
> 
> Sounds good to me. I will drop the new bit and reuse as your suggestion.
> And i think we need document this whole staff in API.txt ...

No problem, I've already pushed it to kvm/queue.  I'm running tests now
and will send a pull request to Linus tomorrow if all goes well.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web