Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1191726 > unrolled thread

Re: [GIT PULL] Non-critical fixes for v4.3

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [GIT PULL] Non-critical fixes for v4.3 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-07-24 13:10 +0200
    Re: [GIT PULL] Non-critical fixes for v4.3 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-24 13:50 +0200
      RE: [GIT PULL] Non-critical fixes for v4.3 Kukjin Kim <kgene@kernel.org> - 2015-07-25 04:00 +0200

#1191726 — Re: [GIT PULL] Non-critical fixes for v4.3

Hi,

On Friday, July 24, 2015 03:34:55 PM Krzysztof Kozlowski wrote:
> Dear Kukjin,
> 
> Previously you did not picked up the fix for cpufreq memory leak.
> I am sending it again with respective acks from LKML. Also another
> minor improvement in the set.
> 
> Best regards,
> Krzysztof
> 
> 
> The following changes since commit 1c4c7159ed2468f3ac4ce5a7f08d79663d381a93:
> 
>   Merge tag 'ext4_for_linus_stable' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 (2015-07-05 16:24:54 -0700)
> 
> are available in the git repository at:
> 
> 
>   https://github.com/krzk/linux.git tags/samsung-fixes-non-critical-v4.3-2
> 
> for you to fetch changes up to 434213f727c12fab8657c8db3d23da4b0463365d:
> 
>   video: fbdev: s3c-fb: Constify platform_device_id (2015-07-24 15:17:32 +0900)
> 
> ----------------------------------------------------------------
> Improvements for Exynos boards:
> 1. Fix memory leak in cpufreq error path.
> 2. Constify platform_device_id in video/fbdev/s3c-fb.
> 
> ----------------------------------------------------------------
> Krzysztof Kozlowski (1):
>       video: fbdev: s3c-fb: Constify platform_device_id
> 
> Shailendra Verma (1):
>       cpufreq: exynos: Fix for memory leak in case SOC name does not match

I would suggest merging this fix in v4.2 not v4.3:

- it is obvious and touches only error paths

- (hopefully) in v4.3 the exynos-cpufreq driver will be completely
  replaced by using cpufreq-dt for Exynos platforms (thus there will be
  no benefits of having this fix in v4.3 but there will be potential
  risk of merge conflicts due to exynos-cpufreq driver removal)

>  drivers/cpufreq/exynos-cpufreq.c | 6 ++++--
>  drivers/video/fbdev/s3c-fb.c     | 2 +-
>  2 files changed, 5 insertions(+), 3 deletions(-)

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1191747

2015-07-24 20:04 GMT+09:00 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>:
>
> Hi,
>
> On Friday, July 24, 2015 03:34:55 PM Krzysztof Kozlowski wrote:
>> Dear Kukjin,
>>
>> Previously you did not picked up the fix for cpufreq memory leak.
>> I am sending it again with respective acks from LKML. Also another
>> minor improvement in the set.
>>
>> Best regards,
>> Krzysztof
>>
>>
>> The following changes since commit 1c4c7159ed2468f3ac4ce5a7f08d79663d381a93:
>>
>>   Merge tag 'ext4_for_linus_stable' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 (2015-07-05 16:24:54 -0700)
>>
>> are available in the git repository at:
>>
>>
>>   https://github.com/krzk/linux.git tags/samsung-fixes-non-critical-v4.3-2
>>
>> for you to fetch changes up to 434213f727c12fab8657c8db3d23da4b0463365d:
>>
>>   video: fbdev: s3c-fb: Constify platform_device_id (2015-07-24 15:17:32 +0900)
>>
>> ----------------------------------------------------------------
>> Improvements for Exynos boards:
>> 1. Fix memory leak in cpufreq error path.
>> 2. Constify platform_device_id in video/fbdev/s3c-fb.
>>
>> ----------------------------------------------------------------
>> Krzysztof Kozlowski (1):
>>       video: fbdev: s3c-fb: Constify platform_device_id
>>
>> Shailendra Verma (1):
>>       cpufreq: exynos: Fix for memory leak in case SOC name does not match
>
> I would suggest merging this fix in v4.2 not v4.3:
>
> - it is obvious and touches only error paths

Indeed, good point, thanks for pointing this. Although these are not
regressions for issues introduced in current release but they are are
non-intrusive.

Kukjin, do you agree? Can you pull them for second round of v4.2 fixes (not 4.3)

>
> - (hopefully) in v4.3 the exynos-cpufreq driver will be completely
>   replaced by using cpufreq-dt for Exynos platforms (thus there will be
>   no benefits of having this fix in v4.3 but there will be potential
>   risk of merge conflicts due to exynos-cpufreq driver removal)
>

We'll see... The Exynos 4x12 requires OPP patches. Are these ready for 4.3?

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1192239

Krzysztof Kozlowski wrote:
> 
> 2015-07-24 20:04 GMT+09:00 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>:
> >
> > Hi,
> >
> > On Friday, July 24, 2015 03:34:55 PM Krzysztof Kozlowski wrote:
> >> Dear Kukjin,
> >>
> >> Previously you did not picked up the fix for cpufreq memory leak.
> >> I am sending it again with respective acks from LKML. Also another
> >> minor improvement in the set.
> >>
> >> Best regards,
> >> Krzysztof
> >>
> >>
> >> The following changes since commit 1c4c7159ed2468f3ac4ce5a7f08d79663d381a93:
> >>
> >>   Merge tag 'ext4_for_linus_stable' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4
> (2015-07-05 16:24:54 -0700)
> >>
> >> are available in the git repository at:
> >>
> >>
> >>   https://github.com/krzk/linux.git tags/samsung-fixes-non-critical-v4.3-2
> >>
> >> for you to fetch changes up to 434213f727c12fab8657c8db3d23da4b0463365d:
> >>
> >>   video: fbdev: s3c-fb: Constify platform_device_id (2015-07-24 15:17:32 +0900)
> >>
> >> ----------------------------------------------------------------
> >> Improvements for Exynos boards:
> >> 1. Fix memory leak in cpufreq error path.
> >> 2. Constify platform_device_id in video/fbdev/s3c-fb.
> >>
> >> ----------------------------------------------------------------
> >> Krzysztof Kozlowski (1):
> >>       video: fbdev: s3c-fb: Constify platform_device_id
> >>
> >> Shailendra Verma (1):
> >>       cpufreq: exynos: Fix for memory leak in case SOC name does not match
> >
> > I would suggest merging this fix in v4.2 not v4.3:
> >
> > - it is obvious and touches only error paths
> 
> Indeed, good point, thanks for pointing this. Although these are not
> regressions for issues introduced in current release but they are are
> non-intrusive.
> 
> Kukjin, do you agree? Can you pull them for second round of v4.2 fixes (not 4.3)
> 
Agreed. OK.

> > - (hopefully) in v4.3 the exynos-cpufreq driver will be completely
> >   replaced by using cpufreq-dt for Exynos platforms (thus there will be
> >   no benefits of having this fix in v4.3 but there will be potential
> >   risk of merge conflicts due to exynos-cpufreq driver removal)
> >
> 
> We'll see... The Exynos 4x12 requires OPP patches. Are these ready for 4.3?
> 
I think, if any conflicts based on fixes during -rc, can be handled by
maintainer.

Thanks,
Kukjin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web