Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1191713 > unrolled thread

Re: [PATCH 1/5] staging: rtl8712: fix buggy size calculation

Started byDan Carpenter <dan.carpenter@oracle.com>
First post2015-07-24 13:00 +0200
Last post2015-07-24 13:00 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 1/5] staging: rtl8712: fix buggy size calculation Dan Carpenter <dan.carpenter@oracle.com> - 2015-07-24 13:00 +0200

#1191713 — Re: [PATCH 1/5] staging: rtl8712: fix buggy size calculation

FromDan Carpenter <dan.carpenter@oracle.com>
Date2015-07-24 13:00 +0200
SubjectRe: [PATCH 1/5] staging: rtl8712: fix buggy size calculation
Message-ID<pPIRP-3xl-7@gated-at.bofh.it>
On Thu, Jul 23, 2015 at 09:38:33PM -0700, Joshua Clayton wrote:
> r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
> where the underlying struct has a 6 * unsigned char.
> Simplify the calculation by just subtracting the variable part from
> the size of the struct.
> 
> This also gets rid of a use of typedef NDIS_802_11_RATES_EX
> 
> Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>

Looks like you are right.

Reviewed-by: Dan Carpenter

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web