Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1191464 > unrolled thread
| Started by | Hanjun Guo <hanjun.guo@linaro.org> |
|---|---|
| First post | 2015-07-24 05:00 +0200 |
| Last post | 2015-07-24 05:00 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH V7 4/5] arm64: apei: implement arch_apei_get_mem_attributes() Hanjun Guo <hanjun.guo@linaro.org> - 2015-07-24 05:00 +0200
| From | Hanjun Guo <hanjun.guo@linaro.org> |
|---|---|
| Date | 2015-07-24 05:00 +0200 |
| Subject | Re: [PATCH V7 4/5] arm64: apei: implement arch_apei_get_mem_attributes() |
| Message-ID | <pPBnk-156-5@gated-at.bofh.it> |
On 07/22/2015 05:59 AM, Jonathan (Zhixiong) Zhang wrote:
> From: "Jonathan (Zhixiong) Zhang" <zjzhang@codeaurora.org>
>
> If the physical address has memory attributes defined by EFI
> memmap as EFI_MEMORY_UC, the page protection type is
> PROT_DEVICE_nGnRE. Otherwise, the page protection type is
> PAGE_KERNEL.
...
[...]
> +#ifdef CONFIG_ACPI_APEI
> +/*
> + * According to "Table 8 Map: EFI memory types to AArch64 memory types"
> + * of UEFI 2.5 section 2.3.6.1, each EFI memory type is mapped to
> + * corresponding MAIR attribute encoding.
> + */
> +static inline pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr)
> +{
> + pgprot_t prot;
> +
> + prot = efi_mem_attributes(addr);
> + if (prot & EFI_MEMORY_UC)
> + return PROT_DEVICE_nGnRnE;
> + if (prot & EFI_MEMORY_WC)
> + return PROT_NORMAL_NC;
> + if (prot & EFI_MEMORY_WT)
> + return PROT_NORMAL_WT;
> + return PAGE_KERNEL;
> +}
The change log is not matching the code here, and the PROT_DEVICE_nGnRE
in the change log is wrong, if you fix that,
Acked-by: Hanjun Guo <hanjun.guo@linaro.org>
Thanks
Hanjun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to top | Article view | linux.kernel
csiph-web