Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1189938 > unrolled thread

[PATCH V4] x86/mm/pat: Do a small optimization and fix in reserve_memtype

Back to article view | Back to linux.kernel

Contents

  [PATCH V4] x86/mm/pat: Do a small optimization and fix in reserve_memtype Pan Xinhui <xinhuix.pan@intel.com> - 2015-07-22 15:30 +0200
    Re: [PATCH V4] x86/mm/pat: Do a small optimization and fix in  reserve_memtype Borislav Petkov <bp@alien8.de> - 2015-07-22 16:50 +0200
    RE: [PATCH V4] x86/mm/pat: Do a small optimization and fix in  reserve_memtype "Elliott, Robert (Server Storage)" <Elliott@hp.com> - 2015-07-22 16:50 +0200

#1189938 — [PATCH V4] x86/mm/pat: Do a small optimization and fix in reserve_memtype

From: Pan Xinhui <xinhuix.pan@intel.com>

It's more reasonable to unlock memtype_lock right after
rbt_memtype_check_insert. All pat_rbtree operations need to be performed
while holding the memtype_lock. But codes like kfree, pr_info, etc have
nothing to do with this lock. So move spin_unlock a little ahead.

If *new* succeed to be stored into the rb-tree, we might hit panic.
Because we access *new* in dprintk "cattr_name(new->type)". Data stored
in the rb-tree might be freed at any possible time. It's obviously wrong
to access such data without lock held.

We use actual_type instead of new->type in dprintk. Two benefits, 1) We
don't touch *new* here now so panic can be avoided. 2) As new->type is
same with *new_type, We needn't to print it again, what's more, this
actual_type's output can help debug. When new_type is NULL, actual_type
is equal to new->type, So no key information is lost.

Do a minor codes style improvement.

Signed-off-by: Pan Xinhui <xinhuix.pan@intel.com>
---
change from v3:
	output actual_type instead of new->type.
	codes style improvement.
	update comments.
change from v2:
	update comments.
change from V1:
	fix an access of *new* without memtype_lock held.
---
 arch/x86/mm/pat.c | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c
index 188e3e0..8fa1f07 100644
--- a/arch/x86/mm/pat.c
+++ b/arch/x86/mm/pat.c
@@ -521,10 +521,7 @@ int reserve_memtype(u64 start, u64 end, enum page_cache_mode req_type,
 
 	is_range_ram = pat_pagerange_is_ram(start, end);
 	if (is_range_ram == 1) {
-
-		err = reserve_ram_pages_type(start, end, req_type, new_type);
-
-		return err;
+		return reserve_ram_pages_type(start, end, req_type, new_type);
 	} else if (is_range_ram < 0) {
 		return -EINVAL;
 	}
@@ -538,22 +535,19 @@ int reserve_memtype(u64 start, u64 end, enum page_cache_mode req_type,
 	new->type	= actual_type;
 
 	spin_lock(&memtype_lock);
-
 	err = rbt_memtype_check_insert(new, new_type);
+	spin_unlock(&memtype_lock);
+
 	if (err) {
 		pr_info("x86/PAT: reserve_memtype failed [mem %#010Lx-%#010Lx], track %s, req %s\n",
 			start, end - 1,
 			cattr_name(new->type), cattr_name(req_type));
 		kfree(new);
-		spin_unlock(&memtype_lock);
-
 		return err;
 	}
 
-	spin_unlock(&memtype_lock);
-
 	dprintk("reserve_memtype added [mem %#010Lx-%#010Lx], track %s, req %s, ret %s\n",
-		start, end - 1, cattr_name(new->type), cattr_name(req_type),
+		start, end - 1, cattr_name(actual_type), cattr_name(req_type),
 		new_type ? cattr_name(*new_type) : "-");
 
 	return err;
-- 
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1190024 — Re: [PATCH V4] x86/mm/pat: Do a small optimization and fix in reserve_memtype

On Wed, Jul 22, 2015 at 02:38:28PM +0000, Elliott, Robert (Server Storage) wrote:
> With each branch now just one line, the {} can be removed.

... and I had suggested it without the {}.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1190032 — RE: [PATCH V4] x86/mm/pat: Do a small optimization and fix in reserve_memtype

DQoNCi0tLQ0KUm9iZXJ0IEVsbGlvdHQsIEhQIFNlcnZlciBTdG9yYWdlDQoNCj4gLS0tLS1Pcmln
aW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogbGludXgta2VybmVsLW93bmVyQHZnZXIua2VybmVs
Lm9yZyBbbWFpbHRvOmxpbnV4LWtlcm5lbC0NCj4gb3duZXJAdmdlci5rZXJuZWwub3JnXSBPbiBC
ZWhhbGYgT2YgUGFuIFhpbmh1aQ0KPiBTZW50OiBXZWRuZXNkYXksIEp1bHkgMjIsIDIwMTUgODoy
NyBBTQ0KLi4uDQo+IGRpZmYgLS1naXQgYS9hcmNoL3g4Ni9tbS9wYXQuYyBiL2FyY2gveDg2L21t
L3BhdC5jDQo+IGluZGV4IDE4OGUzZTAuLjhmYTFmMDcgMTAwNjQ0DQo+IC0tLSBhL2FyY2gveDg2
L21tL3BhdC5jDQo+ICsrKyBiL2FyY2gveDg2L21tL3BhdC5jDQo+IEBAIC01MjEsMTAgKzUyMSw3
IEBAIGludCByZXNlcnZlX21lbXR5cGUodTY0IHN0YXJ0LCB1NjQgZW5kLCBlbnVtDQo+IHBhZ2Vf
Y2FjaGVfbW9kZSByZXFfdHlwZSwNCj4gDQo+ICAJaXNfcmFuZ2VfcmFtID0gcGF0X3BhZ2VyYW5n
ZV9pc19yYW0oc3RhcnQsIGVuZCk7DQo+ICAJaWYgKGlzX3JhbmdlX3JhbSA9PSAxKSB7DQo+IC0N
Cj4gLQkJZXJyID0gcmVzZXJ2ZV9yYW1fcGFnZXNfdHlwZShzdGFydCwgZW5kLCByZXFfdHlwZSwg
bmV3X3R5cGUpOw0KPiAtDQo+IC0JCXJldHVybiBlcnI7DQo+ICsJCXJldHVybiByZXNlcnZlX3Jh
bV9wYWdlc190eXBlKHN0YXJ0LCBlbmQsIHJlcV90eXBlLCBuZXdfdHlwZSk7DQo+ICAJfSBlbHNl
IGlmIChpc19yYW5nZV9yYW0gPCAwKSB7DQo+ICAJCXJldHVybiAtRUlOVkFMOw0KPiAgCX0NCg0K
V2l0aCBlYWNoIGJyYW5jaCBub3cganVzdCBvbmUgbGluZSwgdGhlIHt9IGNhbiBiZSByZW1vdmVk
Lg0KDQoNCg0K
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web