Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1189896 > unrolled thread
| Started by | Rabin Vincent <rabin@rab.in> |
|---|---|
| First post | 2015-07-22 15:10 +0200 |
| Last post | 2015-07-22 15:10 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
[PATCH 1/3] gpio: etraxfs: fix set register flag Rabin Vincent <rabin@rab.in> - 2015-07-22 15:10 +0200
| From | Rabin Vincent <rabin@rab.in> |
|---|---|
| Date | 2015-07-22 15:10 +0200 |
| Subject | [PATCH 1/3] gpio: etraxfs: fix set register flag |
| Message-ID | <pP1Wx-7Id-9@gated-at.bofh.it> |
BGPIO_F_UNREADABLE_REG_SET is incorrect, since the set register _is_ readable. What's really required is BGPIO_F_READ_OUTPUT_REG_SET: reading the set register reads the set output value. Signed-off-by: Rabin Vincent <rabin@rab.in> --- drivers/gpio/gpio-etraxfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-etraxfs.c b/drivers/gpio/gpio-etraxfs.c index 28071f4..c1ce80d 100644 --- a/drivers/gpio/gpio-etraxfs.c +++ b/drivers/gpio/gpio-etraxfs.c @@ -140,7 +140,7 @@ static int etraxfs_gpio_probe(struct platform_device *pdev) NULL, /* clr */ regs + port->oe, /* dirout */ NULL, /* dirin */ - BGPIOF_UNREADABLE_REG_SET); + BGPIOF_READ_OUTPUT_REG_SET); if (ret) return ret; -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to top | Article view | linux.kernel
csiph-web