Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1188679 > unrolled thread
| Started by | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| First post | 2015-07-21 07:50 +0200 |
| Last post | 2015-07-21 08:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] gpio: remove unneeded initializer in gpiochip_add_to_list() Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-07-21 07:50 +0200
Re: [PATCH] gpio: remove unneeded initializer in gpiochip_add_to_list() Alexandre Courbot <gnurou@gmail.com> - 2015-07-21 08:00 +0200
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2015-07-21 07:50 +0200 |
| Subject | [PATCH] gpio: remove unneeded initializer in gpiochip_add_to_list() |
| Message-ID | <pOyBb-7Dd-3@gated-at.bofh.it> |
This variable is used as an iterator and initialized in the
list_for_each() loop.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/gpio/gpiolib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index bf4bd1d..adb03c6 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -190,7 +190,7 @@ EXPORT_SYMBOL_GPL(gpiod_get_direction);
*/
static int gpiochip_add_to_list(struct gpio_chip *chip)
{
- struct list_head *pos = &gpio_chips;
+ struct list_head *pos;
struct gpio_chip *_chip;
int err = 0;
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Alexandre Courbot <gnurou@gmail.com> |
|---|---|
| Date | 2015-07-21 08:00 +0200 |
| Message-ID | <pOyKR-7PR-9@gated-at.bofh.it> |
| In reply to | #1188679 |
On Tue, Jul 21, 2015 at 2:45 PM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> This variable is used as an iterator and initialized in the
> list_for_each() loop.
>
Looks good, thanks!
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> drivers/gpio/gpiolib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index bf4bd1d..adb03c6 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -190,7 +190,7 @@ EXPORT_SYMBOL_GPL(gpiod_get_direction);
> */
> static int gpiochip_add_to_list(struct gpio_chip *chip)
> {
> - struct list_head *pos = &gpio_chips;
> + struct list_head *pos;
> struct gpio_chip *_chip;
> int err = 0;
>
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web