Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1189659 > unrolled thread

Re: [PATCH] cgroup: net_cls: fix false-positive "suspicious RCU usage"

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] cgroup: net_cls: fix false-positive "suspicious RCU  usage" David Miller <davem@davemloft.net> - 2015-07-22 07:30 +0200

#1189659 — Re: [PATCH] cgroup: net_cls: fix false-positive "suspicious RCU usage"

From: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Date: Tue, 21 Jul 2015 19:46:29 +0300

> @@ -23,7 +23,8 @@ static inline struct cgroup_cls_state *css_cls_state(struct cgroup_subsys_state
>  
>  struct cgroup_cls_state *task_cls_state(struct task_struct *p)
>  {
> -	return css_cls_state(task_css(p, net_cls_cgrp_id));
> +       return css_cls_state(task_css_check(p, net_cls_cgrp_id,
> +			       rcu_read_lock_bh_held()));

You've made a serious mess of the indentation here.

First of all, you've changed the correct plain "TAB" before the 'return' line
into a TAB and two SPACE characters.

Secondly, the second line needs to be precisely indented to the exact column
following the openning parenthesis of the task_css_check() call on the
previous line.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web