Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1186828 > unrolled thread
| Started by | kbuild test robot <fengguang.wu@intel.com> |
|---|---|
| First post | 2015-07-17 15:40 +0200 |
| Last post | 2015-07-17 15:50 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[pinctrl:devel 30/37] drivers/pinctrl/pinconf.c:205:6: sparse: symbol 'pinconf_show_config' was not declared. Should it be static? kbuild test robot <fengguang.wu@intel.com> - 2015-07-17 15:40 +0200
[PATCH pinctrl] pinctrl: pinconf: pinconf_show_config() can be static kbuild test robot <fengguang.wu@intel.com> - 2015-07-17 15:40 +0200
Re: [PATCH pinctrl] pinctrl: pinconf: pinconf_show_config() can be static Linus Walleij <linus.walleij@linaro.org> - 2015-07-17 15:50 +0200
| From | kbuild test robot <fengguang.wu@intel.com> |
|---|---|
| Date | 2015-07-17 15:40 +0200 |
| Subject | [pinctrl:devel 30/37] drivers/pinctrl/pinconf.c:205:6: sparse: symbol 'pinconf_show_config' was not declared. Should it be static? |
| Message-ID | <pNe1Q-6Sg-13@gated-at.bofh.it> |
tree: git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel head: 16c06171faa4ad430393ca896fc62eb9e2e6dd40 commit: d96310aeddc692cf1f06861cf722c4843e0a3f28 [30/37] pinctrl: pinconf: Fix display of configs reproduce: # apt-get install sparse git checkout d96310aeddc692cf1f06861cf722c4843e0a3f28 make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/pinctrl/pinconf.c:205:6: sparse: symbol 'pinconf_show_config' was not declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | kbuild test robot <fengguang.wu@intel.com> |
|---|---|
| Date | 2015-07-17 15:40 +0200 |
| Subject | [PATCH pinctrl] pinctrl: pinconf: pinconf_show_config() can be static |
| Message-ID | <pNe1R-6Sg-39@gated-at.bofh.it> |
| In reply to | #1186828 |
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
pinconf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
index cbf26a6..078e58d 100644
--- a/drivers/pinctrl/pinconf.c
+++ b/drivers/pinctrl/pinconf.c
@@ -202,7 +202,7 @@ int pinconf_apply_setting(struct pinctrl_setting const *setting)
#ifdef CONFIG_DEBUG_FS
-void pinconf_show_config(struct seq_file *s, struct pinctrl_dev *pctldev,
+static void pinconf_show_config(struct seq_file *s, struct pinctrl_dev *pctldev,
unsigned long *configs, unsigned num_configs)
{
const struct pinconf_ops *confops;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2015-07-17 15:50 +0200 |
| Subject | Re: [PATCH pinctrl] pinctrl: pinconf: pinconf_show_config() can be static |
| Message-ID | <pNebx-73F-31@gated-at.bofh.it> |
| In reply to | #1186833 |
On Fri, Jul 17, 2015 at 3:37 PM, kbuild test robot <fengguang.wu@intel.com> wrote: > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web