Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1186502 > unrolled thread

Re: [RFC PATCH 0/2] thermal: Add generic devfreq cooling device

Back to article view | Back to linux.kernel

Contents

  Re: [RFC PATCH 0/2] thermal: Add generic devfreq cooling device MyungJoo Ham <myungjoo.ham@samsung.com> - 2015-07-17 08:50 +0200
    Re: [RFC PATCH 0/2] thermal: Add generic devfreq cooling device Chanwoo Choi <cw00.choi@samsung.com> - 2015-07-17 09:20 +0200

#1186502 — Re: [RFC PATCH 0/2] thermal: Add generic devfreq cooling device

PiAgIA0KPiAgVGhpcyBwYXRjaHNldCBpbnRyb2R1Y2UgdGhlIGdlbmVyaWMgZGV2ZnJlcSBjb29s
aW5nIGRldmljZSBmb3IgZ2VuZXJpYyB0aGVybWFsDQo+IGZyYW1ld29yay4gVGhlIGRldmZyZXEg
ZGV2aWNlcyBhcmUgdXNlZCBhZCBjb29saW5nIGRldmljZSB0byByZWR1Y2UgdGhlDQo+IG92ZXJo
ZWF0aW5nIHRlbXBlcmF0dXJlLiBUaGlzIHBhdGNoIGlzIGJhc2VkIG9uIGRyaXZlcnMvdGhlcm1h
bC9jcHVfY29vbGluZy5jLg0KPiBUaGUgZGV2ZnJlcSBjb29saW5nIGRldmljZSBjYW4gY2hhbmdl
IHRoZSByYWduZSBvZiB0aGUgZnJlcXVlbmN5IHRhYmxlIG9mDQo+IGRldmZyZXEgZGV2aWNlIGFj
Y29yZGluZyB0byBjb29saW5nIGxldmVsIGluIGRldmljZSB0cmVlIGZpbGUuDQoNCkhpLA0KDQoN
CjEuIFlvdSd2ZSBleHBvcnRlZCAidXBkYXRlX2RldmZyZXEoKSIgaW4gMS8yIGFuZCBkaWRuJ3Qg
dXNlIGl0IGFueXdoZXJlLg0KMi4gSWYgeW91J3ZlIGFkZGVkICJ1cGRhdGVfZGV2ZnJlcSgpIiB0
byBub3RpZnkgZGV2ZnJlcSBkcml2ZXIgd2hlbiBhIG5ldw0KIG1heC9taW4gaXMgZGVmaW5lZCwg
eW91J2xsIG5lZWQgdG8gYWRkIGl0IGF0IHNldF9zdGF0ZSwgT1INCiAgIFlvdSBtYXkgZG8gaXQg
d2l0aCBvcHBfZW5hYmxlKCkvb3BwX2Rpc2FibGUoKSBmdW5jdGlvbiBhbmQgbGV0IG9wcA0KIG5v
dGlmaWVycyBkbyB0aGUgaG9tZXdvcmsgZm9yIHlvdS4gKG5vIG5lZWQgdG8gdXBkYXRlX2RldmZy
ZXEoKS4NCg0KQ2hlZXJzLA0KTXl1bmdKb28NCg0K


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1186516

Dear Myungjoo,

On 07/17/2015 03:40 PM, MyungJoo Ham wrote:
>>   
>>  This patchset introduce the generic devfreq cooling device for generic thermal
>> framework. The devfreq devices are used ad cooling device to reduce the
>> overheating temperature. This patch is based on drivers/thermal/cpu_cooling.c.
>> The devfreq cooling device can change the ragne of the frequency table of
>> devfreq device according to cooling level in device tree file.
> 
> Hi,
> 
> 
> 1. You've exported "update_devfreq()" in 1/2 and didn't use it anywhere.
> 2. If you've added "update_devfreq()" to notify devfreq driver when a new
>  max/min is defined, you'll need to add it at set_state, OR
>    You may do it with opp_enable()/opp_disable() function and let opp
>  notifiers do the homework for you. (no need to update_devfreq().

It is my mistake. The devfreq_set_cur_state() in patch2 use the update_devfreq()
to change the maximum frequency of devfreq device as following:

+       /* Set the limited frequency to maximum frequency of devfreq */
+       devfreq_dev->devfreq->max_freq = limited_freq;
+       update_devfreq(devfreq_dev->devfreq);

I'll resent v2 patch-set.

Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web